Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: eip6963 connection issues #1700

Merged
merged 2 commits into from
Jan 4, 2024
Merged

fix: eip6963 connection issues #1700

merged 2 commits into from
Jan 4, 2024

Conversation

tomiir
Copy link
Contributor

@tomiir tomiir commented Jan 3, 2024

Breaking Changes

N/A

Changes

  • feat:
  • fix: issue where auto connects would trigger pop ups from locked wallets
  • chore:

Associated Issues

#1698

@vercel Vercel
Copy link

vercel bot commented Jan 3, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
web3modal-gallery ✅ Ready (Inspect) Visit Preview Jan 4, 2024 10:38am
web3modal-laboratory ✅ Ready (Inspect) Visit Preview Jan 4, 2024 10:38am
web3modal-react-wagmi-ex ✅ Ready (Inspect) Visit Preview Jan 4, 2024 10:38am
web3modal-vue-wagmi-ex ✅ Ready (Inspect) Visit Preview Jan 4, 2024 10:38am

glitch-txs
glitch-txs approved these changes Jan 3, 2024
View reviewed changes
Copy link
Member

@glitch-txs glitch-txs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

arein
arein approved these changes Jan 3, 2024
View reviewed changes
Copy link
Member

@arein arein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

since this is a hotfix this looks good.

But can you please cut a ticket to cover this in unit/functional tests?

@tomiir
Copy link
Contributor Author

tomiir commented Jan 4, 2024

@arein left it written down here. Feel free to modify/move/update #1704

@tomiir tomiir merged commit 5b6b17e into V3 Jan 4, 2024
11 of 12 checks passed
@tomiir tomiir deleted the fix/autoconnect-on-lock branch January 4, 2024 14:29
@tomiir tomiir mentioned this pull request Jan 4, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arein arein arein approved these changes

@glitch-txs glitch-txs glitch-txs approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@tomiir @arein @glitch-txs @svenvoskamp