Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: test improvements #1936

Merged
merged 30 commits into from Feb 27, 2024
Merged

feat: test improvements #1936

merged 30 commits into from Feb 27, 2024

Conversation

lukaisailovic
Copy link
Contributor

@lukaisailovic lukaisailovic commented Feb 16, 2024 •
edited

Changes

  • Use deeplinks for connecting instead of copy pasting URI
  • Added separate test for QR code connection
  • General improvements and optimizations to tests

Closes

#1775

@vercel Vercel
Copy link

vercel bot commented Feb 16, 2024 •
edited

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
web3modal-gallery ✅ Ready (Inspect) Visit Preview Feb 27, 2024 10:54am
web3modal-laboratory ✅ Ready (Inspect) Visit Preview Feb 27, 2024 10:54am
web3modal-react-wagmi-ex ✅ Ready (Inspect) Visit Preview Feb 27, 2024 10:54am
web3modal-vue-wagmi-ex ✅ Ready (Inspect) Visit Preview Feb 27, 2024 10:54am

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Feb 21, 2024 •
edited

Warnings
⚠️ Changes were made to one or more package.json(s), but not to package-lock.json

Generated by 🚫 dangerJS against e4d0fe2

@lukaisailovic lukaisailovic marked this pull request as ready for review February 27, 2024 10:50
svenvoskamp
svenvoskamp approved these changes Feb 27, 2024
View reviewed changes
Copy link
Contributor

@svenvoskamp svenvoskamp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ✨

@lukaisailovic lukaisailovic merged commit 642015e into V4 Feb 27, 2024
13 checks passed
@lukaisailovic lukaisailovic deleted the feat/test-improvements branch February 27, 2024 11:20
@lukaisailovic lukaisailovic mentioned this pull request Feb 27, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@svenvoskamp svenvoskamp svenvoskamp approved these changes

Assignees
No one assigned
Labels
tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@lukaisailovic @svenvoskamp