Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Siwe package #1957

Merged
merged 38 commits into from Feb 28, 2024
Merged

Siwe package #1957

merged 38 commits into from Feb 28, 2024

Conversation

glitch-txs
Copy link
Member

@glitch-txs glitch-txs commented Feb 22, 2024 •
edited

Breaking Changes

N/A

Changes

  • feat:

  • fix:

    • Removed unused SIWE code from Scaffold
    • Moved SIWE code to its own package -> Core/ui/Scaffold/Client
    • Remove ts-expect-error declarations in Wagmi package
    • SIWE types were being exported from @web3modal/core which is a sub-dependency, types were moved to the SIWE package

  • chore:

Associated Issues

closes #...

@vercel Vercel
Copy link

vercel bot commented Feb 22, 2024 •
edited

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
web3modal-gallery ✅ Ready (Inspect) Visit Preview Feb 28, 2024 0:47am
web3modal-laboratory ✅ Ready (Inspect) Visit Preview Feb 28, 2024 0:47am
web3modal-react-wagmi-ex ✅ Ready (Inspect) Visit Preview Feb 28, 2024 0:47am
web3modal-vue-wagmi-ex ✅ Ready (Inspect) Visit Preview Feb 28, 2024 0:47am

@glitch-txs glitch-txs marked this pull request as draft February 22, 2024 05:39
tomiir
tomiir reviewed Feb 27, 2024
View reviewed changes
turbo.json Show resolved Hide resolved
tomiir
tomiir reviewed Feb 28, 2024
View reviewed changes
Copy link
Contributor

@tomiir tomiir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm ser 🚀

@glitch-txs glitch-txs merged commit b7ad4fc into V4 Feb 28, 2024
13 checks passed
@glitch-txs glitch-txs deleted the fix/siwe branch February 28, 2024 00:51
Cali93
Cali93 reviewed Feb 28, 2024
View reviewed changes
Copy link
Contributor

@Cali93 Cali93 left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I tried it on labs and it still works as expected 💪
Did it have an impact on bundle size ?

@glitch-txs
Copy link
Member Author

Thanks @Cali93 ! Haven't tested its bundle size yet, we'll see 👀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Cali93 Cali93 Cali93 left review comments

@tomiir tomiir tomiir approved these changes

@xzilja xzilja Awaiting requested review from xzilja

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@glitch-txs @xzilja @tomiir @Cali93