Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: refactor email tests #2012

Merged
merged 10 commits into from
Mar 1, 2024
Merged

chore: refactor email tests #2012

merged 10 commits into from
Mar 1, 2024

Conversation

lukaisailovic
Copy link
Contributor

@lukaisailovic lukaisailovic commented Feb 29, 2024 •
edited

Fix email tests and expand email testing suite

@vercel Vercel
Copy link

vercel bot commented Feb 29, 2024 •
edited

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
web3modal-gallery ✅ Ready (Inspect) Visit Preview Mar 1, 2024 0:24am
web3modal-laboratory ✅ Ready (Inspect) Visit Preview Mar 1, 2024 0:24am
web3modal-react-wagmi-ex ✅ Ready (Inspect) Visit Preview Mar 1, 2024 0:24am
web3modal-vue-wagmi-ex ✅ Ready (Inspect) Visit Preview Mar 1, 2024 0:24am

@lukaisailovic lukaisailovic changed the title fix: email tests chore: refactor email tests Mar 1, 2024
@lukaisailovic lukaisailovic marked this pull request as ready for review March 1, 2024 10:20
svenvoskamp
svenvoskamp approved these changes Mar 1, 2024
View reviewed changes
Copy link
Contributor

@svenvoskamp svenvoskamp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! LGTM ✨

bkrem
bkrem approved these changes Mar 1, 2024
View reviewed changes
Copy link
Member

@bkrem bkrem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

apps/laboratory/tests/shared/utils/email.ts Show resolved Hide resolved
@lukaisailovic lukaisailovic merged commit 91f1254 into V4 Mar 1, 2024
13 checks passed
@lukaisailovic lukaisailovic deleted the fix/email-tests branch March 1, 2024 13:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bkrem bkrem bkrem approved these changes

@svenvoskamp svenvoskamp svenvoskamp approved these changes

@tomiir tomiir Awaiting requested review from tomiir

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@lukaisailovic @bkrem @svenvoskamp