Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

:feat integrating account balance #2030

Merged
merged 21 commits into from Mar 7, 2024
Merged

Conversation

svenvoskamp
Copy link
Contributor

@svenvoskamp svenvoskamp commented Mar 5, 2024

Changes

  • Adding wui-list-token composite
  • Adding wui-list-description composite
  • Added switch tab logic to show right content for chosen tab
  • Adjusted wui-tabs composite to fix state in account view
  • Adjusted wui-tag composite
  • Added w3m-account-activity-widget for activity tab content
  • Added w3m-account-nft-widget for nft tab content
  • Added w3m-account-token-widget for nft token content
  • Added w3m-activity-list to share ui/logic for activity content
  • Added getBalance function to BlockChainApiController
  • Added fetchTokenBalance function to AccountController
  • Added tokenBalance state to AccountController

Copy link

vercel bot commented Mar 5, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
web3modal-gallery ✅ Ready (Inspect) Visit Preview Mar 7, 2024 8:19am
web3modal-laboratory ✅ Ready (Inspect) Visit Preview Mar 7, 2024 8:19am
web3modal-react-wagmi-ex ✅ Ready (Inspect) Visit Preview Mar 7, 2024 8:19am
web3modal-vue-wagmi-ex ✅ Ready (Inspect) Visit Preview Mar 7, 2024 8:19am

Copy link
Contributor

github-actions bot commented Mar 5, 2024

Fails
🚫 packages/scaffold/src/partials/w3m-activity-list/index.ts should use relative imports instead of direct package access
🚫 New composites were added, but not exported in ui/utils/JSXTypeUtil.ts

Generated by 🚫 dangerJS against 974ed8b

<wui-tabs
.onTabChange=${this.onTabChange.bind(this)}
.activeTab=${this.currentTab}
localTabWidth="104px"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this ok ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes normally localTabWidth is 100px, but we set wui-tabs to width:100%, so 100px is not enough anymore.

Copy link
Contributor

@tomiir tomiir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, though I don't really understand how fetchGetBalance works

@svenvoskamp
Copy link
Contributor Author

Looks good, though I don't really understand how fetchGetBalance works

It will make a call to the get method from the FetchUtil. It will create the url based on the arguments passed in. Then it will fetch this url and return the response.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants