Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: prevent account not found error on disconnect #2073

Merged

Conversation

codergon
Copy link
Contributor

Breaking Changes

N/A

Changes

  • fix: Updated disconnection logic to prevent account not found error

Associated Issues

closes #2066

Copy link

vercel bot commented Mar 26, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
web3modal-gallery ✅ Ready (Inspect) Visit Preview Mar 27, 2024 1:14pm
web3modal-laboratory ✅ Ready (Inspect) Visit Preview Mar 27, 2024 1:14pm
web3modal-vue-wagmi-ex ✅ Ready (Inspect) Visit Preview Mar 27, 2024 1:14pm

Copy link

vercel bot commented Mar 26, 2024

@codergon is attempting to deploy a commit to the WalletConnect Team on Vercel.

A member of the Team first needs to authorize it.

@codergon codergon changed the title Fix/account not found error on disconnect fix: account not found error on disconnect Mar 26, 2024
@codergon codergon changed the title fix: account not found error on disconnect fix: prevent account not found error on disconnect Mar 26, 2024
Copy link
Contributor

@tomiir tomiir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍
cc @svenvoskamp

Copy link
Contributor

@svenvoskamp svenvoskamp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tomiir tomiir merged commit 39c78b8 into WalletConnect:V4 Mar 27, 2024
5 of 12 checks passed
@tomiir tomiir mentioned this pull request Mar 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[bug] - Account not found error while disconnecting
3 participants