fix: email update

[ignaciosantise]

Changes

• fix: use updateEmail response to decide whether to redirect to first or second OTP screen

Steps to reproduce issue in production:

1. Create a NEW email account using an unused email
2. After connecting, change your email to a new one fast
3. Magic will send an OTP code directly to the new email and not to the current one
4. This causes the view to hang waiting for UPDATE_EMAIL_SUCCESS event

Associated Issues

https://linear.app/walletconnect/issue/W3M-171/%5Bbug%5D-freeze-update-email-flow-when-otp-is-sent-to-new-email-only

Related

Secure site PR 120

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
web3modal-demo	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Apr 19, 2024 1:33pm
web3modal-gallery	✅ Ready (Inspect)	Visit Preview		Apr 19, 2024 1:33pm
web3modal-laboratory	✅ Ready (Inspect)	Visit Preview		Apr 19, 2024 1:33pm

[tomiir]

This looks OK, just wondering if zod will break when secure site starts returning new data and old versions can't handle it.

Did you try new secure site with older versions of w3m?

[ignaciosantise]

@tomiir yes, i tested the new secure site with an old version of w3m and it doesn't break because zod.parse removes the extra data. But i'll test everything again to be 100% sure.

Log using old w3m and new secure-site -> zod filters the new payload in UPDATE_EMAIL_SUCCESS

• The first log is before frameEvent.parse and show the new secure site payload
• the second log is what the provider receives in the event data

[ignaciosantise]

@arein @lukaisailovic added update email tests

[lukaisailovic]

New change has been merged in V4 that uses random emails for each tests. Refer to that and update so we use that approach for this test as well