Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Impossible to tell if local Bitcoin Core client data is used #1229

Closed
john951 opened this issue Mar 13, 2019 · 10 comments
Closed

Impossible to tell if local Bitcoin Core client data is used #1229

john951 opened this issue Mar 13, 2019 · 10 comments

Comments

@john951
Copy link

john951 commented Mar 13, 2019

The Issue

When Wasabi Wallet is started there is no way to tell if the wallet is using the Bitcoin Core client data or not.

Expected Behaviour

Wasabi wallet shows in bottom status bar that it's connected to local Bitcoin Core client (same way it shows it's connected to Tor).

Additional Notes

Running it on Ubuntu 18.04 LTS using the provided Debian package (Wasabi-1.1.1.deb).

@nopara73
Copy link
Contributor

nopara73 commented Mar 13, 2019

ACK. Well, you can tell by looking at the logs where the block is downloaded from, but generally this is one of the issue with "partial bitcoin core integration".

There are some thoughts about how we plan to show things to the user here: #1197 (comment)

@john951
Copy link
Author

john951 commented Mar 13, 2019

So is it fair to assume if I see in log "INFO WalletService: Block acquired from local P2P connection" it is actually ok?
What would be the message for logs outside the local P2P connection?

@nopara73
Copy link
Contributor

So is it fair to assume if I see in log "INFO WalletService: Block acquired from local P2P connection" it is actually ok?

Yes, that is exactly what you should be looking for.

What would be the message for logs outside the local P2P connection?

2019-03-12 12:46:58 INFO WalletService: Disconnected node: ###. Block downloaded: ###

@yunier2002
Copy link

I'm using Wasabi in Windows 10 and running Bitcoin Core too. When looking at logs it seems it's not using my local node at all, is Wasabi fully working in this setup in Windows? My node data is in a different location not default one maybe that's why it's not detecting it or it uses a different way to detect it?

I also agree, a UI way to check if the local node is being used or not is very useful for users.

@nopara73
Copy link
Contributor

On a general note: The UI doesn't know if the node is connected, because you never connect to your node, until you need a block, and after you get your block you immediately disconnect, so that's the blocker currently of showing up that we are using Core or not. (Also I think it'd be misleading to show we're using your Core on the UI, because it's a partial untrusted integration, only used for block fetching.)

Wasabi fully working in this setup in Windows?

It works on Windows.

My node data is in a different location not default one maybe that's why it's not detecting it or it uses a different way to detect it?

No, it doesn't affect it.

What can be the issue?

  1. What do you see in the logs?
  2. Didn't you trun off listening in your bitcoin.conf?
  3. Maybe you should whitebind all the requests coming to your localhost's P2P port in your bitcoin.conf.
main.whitebind=127.0.0.1:8333
test.whitebind=127.0.0.1:18333
regtest.whitebind=127.0.0.1:18444

@yunier2002
Copy link

I have added those lines to my bitcoin.conf file but seems still not working. Here is what's showing up in my log

2019-04-22 16:09:29 INFO WalletService: Disconnected node: ::ffff:164.132.229.117. Block downloaded: 0000000000000000003bf55e5913d06cc407a93902e2d977b00748399a2df039 2019-04-22 16:09:29 INFO WalletService: TCP Connection succeeded, handshaking... 2019-04-22 16:09:29 WARNING WalletService: System.InvalidOperationException: The node is not in a connected state at NBitcoin.Protocol.NodeListener.ReceivePayload[TPayload](CancellationToken cancellationToken) at NBitcoin.Protocol.Node.VersionHandshake(NodeRequirement requirements, CancellationToken cancellationToken) at WalletWasabi.Services.WalletService.GetOrDownloadBlockAsync(uint256 hash, CancellationToken cancel) 2019-04-22 16:09:29 WARNING UnobservedTaskException: System.AggregateException: A Task's exception(s) were not observed either by Waiting on the Task or accessing its Exception property. As a result, the unobserved exception was rethrown by the finalizer thread. (The peer has been disconnected) ---> System.OperationCanceledException: The peer has been disconnected --- End of inner exception stack trace --- ---> (Inner Exception #0) System.OperationCanceledException: The peer has been disconnected<---

@nopara73
Copy link
Contributor

@yunier2002 Yes, it means you're not using the node. Can you try it by building from source code? https://github.com/zkSNACKs/WalletWasabi#build-from-source-code

@nopara73
Copy link
Contributor

nopara73 commented May 6, 2019

Waiting for dependency: #845

@MaxHillebrand
Copy link
Contributor

fixed with #2495, I think we can close this now? or do you want more notifications other than Bitcoin Core is syncing / is synced?

@john951
Copy link
Author

john951 commented Nov 14, 2019

Yes it's fine by me now. Please /close.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants