Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify Alice and Bob #25

Closed
FrancisPouliot opened this issue May 14, 2017 · 8 comments
Closed

Clarify Alice and Bob #25

FrancisPouliot opened this issue May 14, 2017 · 8 comments

Comments

@FrancisPouliot
Copy link
Contributor

Not sure that the "Move coins between Alice and Bob only by mixing!" message means.

Also not sure why there are two wallets Alice and Bob? What are they for? What's the difference between the two? There seems to be only one wallet file.

@nopara73
Copy link
Contributor

Great note, I was hoping it's clear, but I am actually hoping more it'll be clear after TumbleBit integration. If the confusion still persists I reopen the issue.

@nopara73
Copy link
Contributor

On second thought, it's better to keep it open until the issue is resolved.

@nopara73 nopara73 reopened this May 16, 2017
@nopara73
Copy link
Contributor

Braindump. Account/Identity vs wallet files: #24 (comment)

@nopara73
Copy link
Contributor

nopara73 commented Sep 30, 2017

With ZeroLink the accounts system will likely be redisigned. Keep the issue open. https://github.com/nopara73/ZeroLink/

@wintercooled
Copy link
Contributor

I think this needs revisiting now.

For new users (and those participating in testing) it is unclear what the Alice and Bob wallets are.

I don't think many people will realise that they are essentially two wallets generated from the one mnemonic phrase.

It is also unclear as to why they are called Alice and Bob.

Perhaps we could have one of the following:

Pre-mix and Post-mix
Normal and Mixed

...that kind of thing.

To reduce the amount of bugs changing Alice and Bob could cause in the code I'd suggest keeping the back end code using "ALICE" and "BOB" and just changing the GUI text to show the new names.

Perhaps adding a mouse over pop up text explaining what they are used for would also be useful (it would).

@nopara73
Copy link
Contributor

I think this issue can be closed. Now that we have a mixer, which can move coins between Alice and Bob wallets, and also a couple of hint messages, it becomes more obvious what Alice and Bob is.

I realize this is not a complete, clean resolution, however I don't see any way to fix it without complete redesign of the GUI, which will be due for the stable version.
Maybe renaming the tabs can be a slight improvement.

Pre-mix and Post-mix
Normal and Mixed

Not good, because mixing is two way.

To reduce the amount of bugs changing Alice and Bob could cause in the code I'd suggest keeping the back end code using "ALICE" and "BOB" and just changing the GUI text to show the new names.

Agree in principle, if we want to change that's what we have to do. I'd just like to note multiple renamings would be needed. For example renaming the select box in the mixer tab, renaming some in some of the hints, etc...

@wintercooled
Copy link
Contributor

Even Wallet A and Wallet B might be better. I am used to Alice and Bob now but I think it confuses new users. Anyway....

@nopara73
Copy link
Contributor

nopara73 commented Apr 9, 2018

In the new version: Wallet Wasabi, this will be handled with good coin control, instead of separate wallets.

@nopara73 nopara73 closed this as completed Apr 9, 2018
soosr pushed a commit that referenced this issue Jun 25, 2023
* Rename WalletListModel to WalletRepository

* fix compile

* compile fix

* merge

---------

Co-authored-by: ichthus1604 <ichthus1604@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants