musicbox message stuck at waiting for confirmed coins, while all coins confirmed and none banned

[MarnixCroes]

There have been some more musicbox waiting for confirmed coins issues, in combination with banned coins.

This seems to be a different one.
on a small testnet wallet: all coins confirmed, none banned
stuck at waiting for confirmed coins

this might be related/causing it:

2022-08-01 12:34:49.095 [33] DEBUG      CoinJoinManager.HandleCoinJoinFinalizationAsync (389)   WalletWasabi.WabiSabi.Client.RoundStateAwaiters.NoCoinsToMixException: No coin was selected from '4' number of coins. Probably it was not economical, total amount of coins were: 0.00019132 BTC.
   at WalletWasabi.WabiSabi.Client.CoinJoinClient.StartCoinJoinAsync(IEnumerable`1 coinCandidates, CancellationToken cancellationToken) in WalletWasabi\WabiSabi\Client\CoinJoinClient.cs:line 179
   at WalletWasabi.WabiSabi.Client.CoinJoinManager.HandleCoinJoinFinalizationAsync(CoinJoinTracker finishedCoinJoin, ConcurrentDictionary`2 trackedCoinJoins, CancellationToken cancellationToken) in WalletWasabi\WabiSabi\Client\CoinJoinManager.cs:line 374

[yahiheb]

Similar to #8181

[stale]

This has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

[stale]

This has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

[Pule08]

@MarnixCroes do you still experiencing that one?

[MarnixCroes]

@MarnixCroes do you still experiencing that one?

I'm not sure.
Feel free to close this issue

[yahiheb]

@BTCparadigm This is the issue you have faced yesterday?

[BTCparadigm]

@yahiheb yep, seems similar.

[Pule08]

thanks guys. @soosr it looks like the issue is still something to handle :(

[Pule08]

hello @MarnixCroes ,

Could you still reproduce this one?

[MarnixCroes]

hello @MarnixCroes ,

Could you still reproduce this one?

I have not encountered this in the meantime

[Pule08]

if someone can reproduce, please reopen it

[MarnixCroes]

I just had a similar case on current master c6318c6.
Where the musicbox said Insufficient funds eligible for coinjoin (new message for "Waiting for confirmed funds")
After a while the coinjoin client continued normally.
The coinlist showed everything normal, no banned coins etc.

At the same time this was in the logs:

2023-06-19 13:05:11.420 [12] INFO	CoinJoinClient.CreateRegisterAndConfirmCoinsAsync (451)	Round (43a594a2da0c967ad761bd38dc64eefb3200ceaeefa3cc1e30e339bc1aeb1e8f): 29c84b9c0e4b8ca60b961746b8a4d755aea018e1951ade1ae55f67c21997405f-1 is spent according to the backend. The wallet is not fully synchronized or corrupted.
2023-06-19 13:05:17.570 [12] INFO	CoinJoinClient.CreateRegisterAndConfirmCoinsAsync (451)	Round (43a594a2da0c967ad761bd38dc64eefb3200ceaeefa3cc1e30e339bc1aeb1e8f): 29c84b9c0e4b8ca60b961746b8a4d755aea018e1951ade1ae55f67c21997405f-0 is spent according to the backend. The wallet is not fully synchronized or corrupted.
2023-06-19 13:05:21.553 [12] INFO	CoinJoinClient.CreateRegisterAndConfirmCoinsAsync (451)	Round (43a594a2da0c967ad761bd38dc64eefb3200ceaeefa3cc1e30e339bc1aeb1e8f): cdb1af3f864add6acd358c6d9a286fcc18c0692b1c234f9c212a6b391fc4e4b6-2 is spent according to the backend. The wallet is not fully synchronized or corrupted.

[yahiheb]

I guess everything is working as expected, according to Insufficient funds eligible for coinjoin your wallet tried to participate in coinjoin but for different reasons (the user doesn't need to know the details) the coins that you had at that moment where not eligible for coinjoin which makes more sense than what we had before, i.e. Waiting for confirmed funds.

[Kruwed]

I guess everything is working as expected, according to Insufficient funds eligible for coinjoin your wallet tried to participate in coinjoin but for different reasons (the user doesn't need to know the details) the coins that you had at that moment where not eligible for coinjoin which makes more sense than what we had before, i.e. Waiting for confirmed funds.

"Insufficient funds eligible for coinjoin" makes far less sense than "Waiting for confirmed funds" when the pending coin is actually unconfirmed and not banned. "Insufficient funds" misleads people into thinking there is a problem with the amount of BTC they have. The original instructions in the music box to "wait" is correct since the solution is to wait for the current transaction to confirm, not to send more unconfirmed funds.

I do agree that the "Waiting for confirmed funds" message appearing when inputs are banned makes no sense at all, but if the coinjoin isn't starting due to inputs being banned, that is when a message such as "Funds are ineligible for coinjoin" should appear.

[turbolay]

The problem with this is just that this message is a placeholder for many many different problems.

There is a conflict between 2 views: Add messages to give more insight VS remove some messages to be less confusing.

Currently, and since quite some time now, we are in the between. Our lack of decision making (even if we tend to be removing messages) creates this kind of terribly confusing situations where the message is precise enough for users to think it gives them insight but too general for them to exactly understand what's going on.