-
Notifications
You must be signed in to change notification settings - Fork 492
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
"Insufficient funds eligible for coinjoin" message is misleading/confusing when coins are unconfirmed #10947
Comments
for new wallet creation UX it's definitly more confusing. |
If we are going to rollback this I believe it should be before the release, otherwise it would look ridiculous to change then rollback... |
The decision to change
https://github.com/search?q=repo%3AzkSNACKs%2FWalletWasabi+Waiting+for+confirmed+funds&type=issues |
I am planning to bring this topic up at a @zkSNACKs/ux-team meeting. Because I think what we did was not the best approach. I 100% agree that we should have as fewer messages as possible in the With this most users would see very few messages in most cases, but we would also give clear explanations in rare edge cases if those happen. |
On v2.0.4 RC1/Windows 10, I got the "Hurray! All your funds are private!" message while I had semi private coins that were still unconfirmed. Once the transaction confirmed, the message disappeared and the timer began again. The "Waiting for confirmed funds" message would be correct here instead: I don't know if this step, is necessary to reproduce the Hurray! message, but it appeared after I clicked pause and play again while the "Successful coinjoin! Continuing..." message was still in the music box from the previous round. Related? #9887 |
@Kruwed This seems to be a different one. Try to reproduce it again on master and if you can open an different issue for it. |
Fixed by #11083 |
Discussed here - #8830 (comment)
Previously, the "Waiting for confirmed funds" message would appear in the music box in different cases
Now, the message has been changed to say "Insufficient funds eligible for coinjoin". While this more accurately describes the second case, it less accurately describes the first case. Instead of trying to come up with a single phrase that covers multiple scenarios, the better solution is to use a distinct message for each case ("Waiting for confirmed funds" and "Funds are ineligible for coinjoin") .
If possible, it would help inform the user even more if the ban message in the musicbox would also show the countdown timer until they are unbanned since it is not easy to find the ban length from the UTXOs screen.
The text was updated successfully, but these errors were encountered: