-
Notifications
You must be signed in to change notification settings - Fork 492
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[VDG] UI Decoupling #16 #10576
[VDG] UI Decoupling #16 #10576
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tACK
@SuperJMN @ichthus1604 Merging Receive 3 caused conflict here, please take a look. |
My comments above can be addressed in any follow up pull request, so this one won't be blocked from merging. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tACK
NavBarItemViewModel
from the inheritance hierarchy ofDialogViewModelBase
, and hence all ViewModels for dialogs in the entire software.INavBarToggle
andINavBarButton
interfaces, which enables the NavBar to interact with ViewModels that implement them, instead of relying on a common base type.WalletPageViewModel
which controls the different states and screens shown for each wallet in the wallet list:Login
->Loading
->WalletViewModel
RoutableViewModel
andWalletViewModel
.