Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Trivial] Fix QR Code in lowercase #10816

Merged
merged 1 commit into from
May 31, 2023
Merged

[Trivial] Fix QR Code in lowercase #10816

merged 1 commit into from
May 31, 2023

Conversation

SuperJMN
Copy link
Contributor

Fixes #10812

@SuperJMN SuperJMN marked this pull request as ready for review May 30, 2023 12:15
MarnixCroes
MarnixCroes approved these changes May 30, 2023
View reviewed changes
Copy link
Contributor

@MarnixCroes MarnixCroes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tACK fb5f87f

yahiheb
yahiheb reviewed May 31, 2023
View reviewed changes
Copy link
Collaborator

@yahiheb yahiheb left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not fixed for me. But the thing is even with v2.0.3 the QR Code is in lowercase for me, idk why. (Win10)

image

@soosr
Copy link
Contributor

soosr commented May 31, 2023

This is not fixed for me. But the thing is even with v2.0.3 the QR Code is in lowercase for me, idk why. (Win10)

image

If I can scan this QR I get upper case result

@SuperJMN
Copy link
Contributor Author

This is not fixed for me. But the thing is even with v2.0.3 the QR Code is in lowercase for me, idk why. (Win10)
If I can scan this QR I get upper case result

Yes, I preserved the behavior that was already there:

  • The address in the screen is lowercase
  • The QR Code is uppercase.

For me, it would be better if both have the same casing. Either lower or upper.

Opinions?

yahiheb
yahiheb approved these changes May 31, 2023
View reviewed changes
Copy link
Collaborator

@yahiheb yahiheb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dismiss my previous comment it is wrong.

tACK

For me, it would be better if both have the same casing. Either lower or upper.

That is actually why I got confused and I thought the QR Code should be displayed in uppercase upon generation.

@soosr soosr merged commit 840d29f into WalletWasabi:master May 31, 2023
6 checks passed
@molnard molnard mentioned this pull request Jun 27, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yahiheb yahiheb yahiheb approved these changes

@MarnixCroes MarnixCroes MarnixCroes approved these changes

Assignees
No one assigned
Labels
size/XS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Scanning Wasabi receive address QR code is undercase characters on current master
4 participants
@SuperJMN @soosr @yahiheb @MarnixCroes