Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use NoCoinsEligibleToMix instead of AllCoinsPrivate if all candidates are private #11086

Merged
merged 1 commit into from
Aug 1, 2023

Conversation

turbolay
Copy link
Collaborator

@turbolay turbolay commented Jul 22, 2023

Fixes #11072

As always, with this part of the codebase, not sure if this breaks something else.

The idea is that if we're L206, we passed L191. Hence, the NoCoinsEligibleToMix message is factually correct at this point (we have some non-private coins, but they are not eligible for coinjoin), but not AllCoinsPrivate (because we have some non-private coins).

@soosr
Copy link
Collaborator

soosr commented Jul 24, 2023

FTR @nopara73 and I will fix every scenario including this here #11083

@turbolay
Copy link
Collaborator Author

FTR @nopara73 and I will fix every scenario including this here #11083

AFAICS #11083 doesn't include this fix.
Also, how come both things are assigned the same priority? This PR is a no-brainer bugfix, #11083 is an improvement that might take time if wanted to do correctly.

@soosr
Copy link
Collaborator

soosr commented Jul 24, 2023

FTR @nopara73 and I will fix every scenario including this here #11083

AFAICS #11083 doesn't include this fix. Also, how come both things are assigned the same priority? This PR is a no-brainer bugfix, #11083 is an improvement that might take time if wanted to do correctly.

The PR is nowhere ready atm, we are waiting for @Kruwed and @MarnixCroes to gather every case, and all of them will be fixed and included in the release.

Just be clear, I am not nACKing your PR, I am just saying that there is a high chance that we will modify your solution either way to have an accurate message.

@turbolay
Copy link
Collaborator Author

turbolay commented Jul 24, 2023

Just be clear, I am not nACKing your PR, I am just saying that there is a high chance that we will modify your solution either way to have an accurate message.

Thank you for the clarification, sounds perfect to me!

@soosr soosr merged commit 4486632 into WalletWasabi:master Aug 1, 2023
7 checks passed
@turbolay turbolay deleted the fixHurray branch February 26, 2024 04:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

MusicBox: "hurray all coins private" while having (unconfirmed) non-private coin.
2 participants