[VDG] Fix wrong algorithm to create pockets

[SuperJMN]

Fixes #11101

Our previous algorithm failed when the first element had no labels al all.

Includes tests®

[MarnixCroes]

Could you merge master once again please?
It currently doesn't build, #11248

[yahiheb]

tACK

[MarnixCroes]

t̶A̶C̶K̶ e7a63e4

[MarnixCroes]

a label/pocket of mine is missing in coin control?

Screencast.from.11-08-2023.11.50.04.webm

[yahiheb]

a label/pocket of mine is missing in coin control?

The weird thing is that coin shouldn't have labels since it has AS 8.

Can you reproduce this on master?

[MarnixCroes]

a label/pocket of mine is missing in coin control?

The weird thing is that coin shouldn't have labels since it has AS 8.

Can you reproduce this on master?

It's at a different wallet as well. Where pocket has AS 2, AS target is 5, pocket is missing from Coin Control

[yahiheb]

Where pocket has AS 2, AS target is 5

Any coin with AS 2 or above shouldn't have any label, this is the issue.

pocket is missing from Coin Control

I am sure it is not missing, and it is part of the private coins since its AS is above the target.

[MarnixCroes]

@yahiheb
ah yes of course.
Probably different bug then

it is part of the private coins since its AS is above the target

*it's not above the target, it's semi-private

[yahiheb]

*it's not above the target, it's semi-private

Why? From the video that coin has AS 8 and you said the AS target is 5.

[MarnixCroes]

*it's not above the target, it's semi-private

Why? From the video that coin has AS 8 and you said the AS target is 5.

that's at a different wallet #11242 (comment)

It's at a different wallet as well. Where pocket has AS 2, AS target is 5, pocket is missing from Coin Control

[MarnixCroes]

@soosr this should be merged to 2.0.4 branch as well?

[soosr]

@soosr this should be merged to 2.0.4 branch as well?

Done #11284