[VDG] UI Decoupling #50 #11644

ichthus1604 · 2023-10-06T05:08:28Z

Introduces TransactionModel
Introduces TransactionTreeBuilder
Decouples HistoryViewModel
Decouples CoinjoinHistoryItemViewModel
Decouples CoinjoinsHistoryItemViewModel
Decouples HistoryItemViewModelBase
Decouples SpeedUpHistoryItemViewModel
Decouples TransactionHistoryItemViewModel

soosr · 2023-10-06T09:13:08Z

@ichthus1604 Could you fix conflicts?

ichthus1604 · 2023-10-09T19:58:07Z

@soosr Ready for review ;)

soosr · 2023-10-12T10:52:55Z

2023-10-12 12:25:13.019 [1] ERROR       HistoryViewModel.Update (267)   System.NotImplementedException: Unsupported Transaction Type: Unknown
   at WalletWasabi.Fluent.ViewModels.Wallets.Home.History.HistoryViewModel.CreateViewModel(TransactionModel transaction, HistoryItemViewModelBase parent) in WalletWasabi.Fluent\ViewModels\Wallets\Home\History\HistoryViewModel.cs:line 282
   at WalletWasabi.Fluent.ViewModels.Wallets.Home.History.HistoryViewModel.<Update>b__22_0(TransactionModel x) in WalletWasabi.Fluent\ViewModels\Wallets\Home\History\HistoryViewModel.cs:line 256
   at System.Linq.Enumerable.SelectEnumerableIterator`2.ToList()
   at WalletWasabi.Fluent.ViewModels.Wallets.Home.History.HistoryViewModel.Update(IEnumerable`1 transactions) in WalletWasabi.Fluent\ViewModels\Wallets\Home\History\HistoryViewModel.cs:line 255

One of my wallet has a CJ item which was detected as a self spend transaction and the transaction fee is higher than the amount the wallet received back which causes the history to have an item with a negative outgoing amount.
This is a bug that can mostly come out on RegTest and TestNet and obviously should be fixed.

However, the History building shouldn't fail. On master currently, the icon is empty and that's all.

soosr · 2023-10-12T11:13:22Z

If I remove the exception and just return a transactionviewmodel in the issue mentioned before.

I get another exception.

2023-10-12 12:57:16.899 [1] ERROR       HistoryViewModel.Update (267)   System.ArgumentNullException: Value cannot be null. (Parameter 'parent')
   at WalletWasabi.Fluent.ViewModels.Wallets.Home.History.HistoryViewModel.CreateViewModel(TransactionModel transaction, HistoryItemViewModelBase parent) in WalletWasabi.Fluent\ViewModels\Wallets\Home\History\HistoryViewModel.cs:line 281
   at WalletWasabi.Fluent.ViewModels.Wallets.Home.History.HistoryViewModel.<Update>b__22_0(TransactionModel x) in WalletWasabi.Fluent\ViewModels\Wallets\Home\History\HistoryViewModel.cs:line 256
   at System.Linq.Enumerable.SelectEnumerableIterator`2.ToList()
   at WalletWasabi.Fluent.ViewModels.Wallets.Home.History.HistoryViewModel.Update(IEnumerable`1 transactions) in WalletWasabi.Fluent\ViewModels\Wallets\Home\History\HistoryViewModel.cs:line 255

On master I can see it was a CPFP speed up transaction.

transaction = TransactionModel
 Amount = {Money} 0.20000000
 Balance = {Money} 1.70424800
 CanCancelTransaction = {bool} false
 CanSpeedUpTransaction = {bool} false
 Changed = Cast<object, IReactivePropertyChangedEventArgs<IReactiveObject>>
 Changing = Cast<object, IReactivePropertyChangedEventArgs<IReactiveObject>>
 Children = {List<TransactionModel>} Count = 2
 Confirmations = {int} 23
 ConfirmedTooltip = {string} "Confirmed (23 confirmations)"
 Date = {DateTimeOffset} 09/05/2023 10:18:20 +02:00
 DateString = {string} "2023-09-05 10:18"
 Fee = {Money} null
 Id = {uint256} 25fce942d9b5f2eec77bec61541d8f48acee813664403dff63f20e77e1cf2b38
 IncomingAmount = {Money} 0.20000000
 IsCancellation = {bool} false
 IsChild = {bool} false
 IsCoinjoin = {bool} false
 IsCoinjoinGroup = {bool} false
 IsConfirmed = {bool} true
 Labels = {LabelsArray} asd, TestCoins
 OrderIndex = {int} 102
 OutgoingAmount = {Money} null
 Status = {TransactionStatus} Confirmed
 ThrownExceptions = ScheduledSubject<Exception>
 TransactionSummary = TransactionSummary
 Type = {TransactionType} CPFP
 _changed = {Lazy<IObservable<IReactivePropertyChangedEventArgs<IReactiveObject>>>} ThreadSafetyMode=null, IsValueCreated=true, IsValueFaulted=false, Value=Cast<object, IReactivePropertyChangedEventArgs<IReactiveObject>>
 _changing = {Lazy<IObservable<IReactivePropertyChangedEventArgs<IReactiveObject>>>} ThreadSafetyMode=null, IsValueCreated=true, IsValueFaulted=false, Value=Cast<object, IReactivePropertyChangedEventArgs<IReactiveObject>>
 _children = {List<TransactionModel>} Count = 2
 _propertyChangedEventsSubscribed = {Lazy<Unit>} ThreadSafetyMode=PublicationOnly, IsValueCreated=false, IsValueFaulted=false, Value=()
 _propertyChangingEventsSubscribed = {Lazy<Unit>} ThreadSafetyMode=PublicationOnly, IsValueCreated=false, IsValueFaulted=false, Value=()
 _thrownExceptions = {Lazy<IObservable<Exception>>} ThreadSafetyMode=null, IsValueCreated=true, IsValueFaulted=false, Value=ScheduledSubject<Exception>

soosr

Couldn't continue the testing due to the issues above.

…etWasabi into UI-Decoupling50

soosr

History initial sorting is wrong

soosr

Speeding up a self spend, doesn't work properly. It should have replaced the original transaction in the history, instead of adding new items.

Same is true for canceling. (Order is wrong too, but that doesn't matter)

Child items order is wrong in a CPFP Speed up.

soosr · 2023-10-24T07:23:14Z

@ichthus1604 @SuperJMN What's the status of this PR?

SuperJMN · 2023-10-24T09:14:57Z

@ichthus1604 @SuperJMN What's the status of this PR?

As of this weekend, it still had some problems with speed up. Not sure if @ichthus1604 has fixed it, though.
I'll ask him when he's available to offer some help.

soosr · 2023-10-24T10:50:21Z

Speeding up a self spend, doesn't work properly. It should have replaced the original transaction in the history, instead of adding new items.

Same is true for canceling. (Order is wrong too, but that doesn't matter)

Child items order is wrong in a CPFP Speed up.

Might be related: #11788

ichthus1604 · 2023-10-24T15:09:25Z

@soosr there is an issue I haven't identified yet, which causes the problem you described here. We've been doing pair debugging together with @SuperJMN several times in the last few days, and haven't been able to figure out the cause yet.

Basically, the Model returns a list of 2 items and the TDG shows 3. The root cause of this is yet unknown. The TransactionTreeBuilder logic returns the proper structure (self-spend showing as accelerated and with speedup child), but that's not reflected in the UI.

We will continue to debug this.

…etWasabi into UI-Decoupling50

SuperJMN · 2023-10-25T09:21:38Z

Should fix #11788

SuperJMN · 2023-10-25T09:28:56Z

OK, here's the cause for the record:

The changesets we were generating could only contain additions or updates, but never deletions. Why? Because we always refreshed items in an additive way. Thus, items could be new or updated ONLY. We never actually compared the 'previous state' to the 'new state", so there was no way to know which items were deleted.

What I have done is precisely a new way of updating that generates a full list of diffs, by introducing a class that acts as a 'facilitator.' Underneath, it uses a SourceCache that actually manages all the differences for us.

If you have any more questions or need further assistance, feel free to ask.

soosr · 2023-10-25T12:25:36Z

The order of CPFP speed up children is still reversed:

I got a crash when I tried to speed up a transaction that I sent from wallet A to wallet B (both wallets are in Wasabi).

Exception type: System.ArgumentNullException

Message: Value cannot be null. (Parameter 'parent')

Stack Trace:    at WalletWasabi.Fluent.ViewModels.Wallets.Home.History.HistoryViewModel.CreateViewModel(TransactionModel transaction, HistoryItemViewModelBase parent) in WalletWasabi.Fluent\ViewModels\Wallets\Home\History\HistoryViewModel.cs:line 246
   at WalletWasabi.Fluent.ViewModels.Wallets.Home.History.HistoryViewModel.<OnActivated>b__17_1(TransactionModel x) in WalletWasabi.Fluent\ViewModels\Wallets\Home\History\HistoryViewModel.cs:line 223
   at DynamicData.Cache.Internal.Transform`3.<RunImpl>b__6_0(ChangeAwareCache`2 cache, IChangeSet`2 changes) in /_/src/DynamicData/Cache/Internal/Transform.cs:line 95
   at System.Reactive.Linq.ObservableImpl.Scan`2._.OnNext(TSource value) in /_/Rx.NET/Source/src/System.Reactive/Linq/Observable/Scan.cs:line 49
--- End of stack trace from previous location ---
   at System.Reactive.PlatformServices.ExceptionServicesImpl.Rethrow(Exception exception) in /_/Rx.NET/Source/src/System.Reactive/Internal/ExceptionServicesImpl.cs:line 19
   at System.Reactive.ExceptionHelpers.Throw(Exception exception) in /_/Rx.NET/Source/src/System.Reactive/Internal/ExceptionServices.cs:line 16
   at System.Reactive.Stubs.<>c.<.cctor>b__2_1(Exception ex) in /_/Rx.NET/Source/src/System.Reactive/Internal/Stubs.cs:line 16
   at System.Reactive.AnonymousObserver`1.OnErrorCore(Exception error) in /_/Rx.NET/Source/src/System.Reactive/AnonymousObserver.cs:line 73
   at System.Reactive.ObserverBase`1.OnError(Exception error) in /_/Rx.NET/Source/src/System.Reactive/ObserverBase.cs:line 59
   at System.Reactive.AutoDetachObserver`1.OnErrorCore(Exception exception) in /_/Rx.NET/Source/src/System.Reactive/Internal/AutoDetachObserver.cs:line 77
   at System.Reactive.ObserverBase`1.OnError(Exception error) in /_/Rx.NET/Source/src/System.Reactive/ObserverBase.cs:line 59
   at System.Reactive.Sink`1.ForwardOnError(Exception error) in /_/Rx.NET/Source/src/System.Reactive/Internal/Sink.cs:line 60
   at System.Reactive.Sink`2.OnError(Exception error) in /_/Rx.NET/Source/src/System.Reactive/Internal/Sink.cs:line 94
   at System.Reactive.Sink`1.ForwardOnError(Exception error) in /_/Rx.NET/Source/src/System.Reactive/Internal/Sink.cs:line 60
   at System.Reactive.Concurrency.Synchronize`1._.OnError(Exception error) in /_/Rx.NET/Source/src/System.Reactive/Concurrency/Synchronization.Synchronize.cs:line 50
   at System.Reactive.AutoDetachObserver`1.OnErrorCore(Exception exception) in /_/Rx.NET/Source/src/System.Reactive/Internal/AutoDetachObserver.cs:line 77
   at System.Reactive.ObserverBase`1.OnError(Exception error) in /_/Rx.NET/Source/src/System.Reactive/ObserverBase.cs:line 59
   at System.Reactive.Sink`1.ForwardOnError(Exception error) in /_/Rx.NET/Source/src/System.Reactive/Internal/Sink.cs:line 60
   at System.Reactive.Sink`2.OnError(Exception error) in /_/Rx.NET/Source/src/System.Reactive/Internal/Sink.cs:line 94
   at System.Reactive.Sink`1.ForwardOnError(Exception error) in /_/Rx.NET/Source/src/System.Reactive/Internal/Sink.cs:line 60
   at System.Reactive.Sink`2.OnError(Exception error) in /_/Rx.NET/Source/src/System.Reactive/Internal/Sink.cs:line 94
   at System.Reactive.Sink`1.ForwardOnError(Exception error) in /_/Rx.NET/Source/src/System.Reactive/Internal/Sink.cs:line 60
   at System.Reactive.Sink`2.OnError(Exception error) in /_/Rx.NET/Source/src/System.Reactive/Internal/Sink.cs:line 94
   at System.Reactive.Sink`1.ForwardOnError(Exception error) in /_/Rx.NET/Source/src/System.Reactive/Internal/Sink.cs:line 60
   at System.Reactive.Sink`2.OnError(Exception error) in /_/Rx.NET/Source/src/System.Reactive/Internal/Sink.cs:line 94
   at System.Reactive.Sink`1.ForwardOnError(Exception error) in /_/Rx.NET/Source/src/System.Reactive/Internal/Sink.cs:line 60
   at System.Reactive.Sink`2.OnError(Exception error) in /_/Rx.NET/Source/src/System.Reactive/Internal/Sink.cs:line 94
   at System.Reactive.Sink`1.ForwardOnError(Exception error) in /_/Rx.NET/Source/src/System.Reactive/Internal/Sink.cs:line 60
   at System.Reactive.Sink`2.OnError(Exception error) in /_/Rx.NET/Source/src/System.Reactive/Internal/Sink.cs:line 94
   at System.Reactive.Sink`1.ForwardOnError(Exception error) in /_/Rx.NET/Source/src/System.Reactive/Internal/Sink.cs:line 60
   at System.Reactive.Linq.ObservableImpl.Scan`2._.OnNext(TSource value) in /_/Rx.NET/Source/src/System.Reactive/Linq/Observable/Scan.cs:line 49
   at System.Reactive.AutoDetachObserver`1.OnNextCore(T value) in /_/Rx.NET/Source/src/System.Reactive/Internal/AutoDetachObserver.cs:line 71
   at System.Reactive.Subjects.Subject`1.OnNext(T value) in /_/Rx.NET/Source/src/System.Reactive/Subjects/Subject.cs:line 141
   at System.Collections.ObjectModel.ObservableCollection`1.OnCollectionChanged(NotifyCollectionChangedEventArgs e)
   at DynamicData.Binding.ObservableCollectionAdaptor`2.Adapt(IChangeSet`2 changes, IObservableCollection`1 collection) in /_/src/DynamicData/Binding/ObservableCollectionAdaptor.cs:line 112
   at DynamicData.ObservableCacheEx.<>c__DisplayClass26_0`2.<Bind>b__1(IChangeSet`2 changes) in /_/src/DynamicData/Cache/ObservableCacheEx.cs:line 642
   at System.Reactive.Linq.ObservableImpl.Select`2.Selector._.OnNext(TSource value) in /_/Rx.NET/Source/src/System.Reactive/Linq/Observable/Select.cs:line 48
--- End of stack trace from previous location ---
   at System.Reactive.PlatformServices.ExceptionServicesImpl.Rethrow(Exception exception) in /_/Rx.NET/Source/src/System.Reactive/Internal/ExceptionServicesImpl.cs:line 19
   at System.Reactive.ExceptionHelpers.Throw(Exception exception) in /_/Rx.NET/Source/src/System.Reactive/Internal/ExceptionServices.cs:line 16
   at System.Reactive.Stubs.<>c.<.cctor>b__2_1(Exception ex) in /_/Rx.NET/Source/src/System.Reactive/Internal/Stubs.cs:line 16
   at System.Reactive.AnonymousObserver`1.OnErrorCore(Exception error) in /_/Rx.NET/Source/src/System.Reactive/AnonymousObserver.cs:line 73
   at System.Reactive.ObserverBase`1.OnError(Exception error) in /_/Rx.NET/Source/src/System.Reactive/ObserverBase.cs:line 59
   at System.Reactive.AutoDetachObserver`1.OnErrorCore(Exception exception) in /_/Rx.NET/Source/src/System.Reactive/Internal/AutoDetachObserver.cs:line 77
   at System.Reactive.ObserverBase`1.OnError(Exception error) in /_/Rx.NET/Source/src/System.Reactive/ObserverBase.cs:line 59
   at System.Reactive.Sink`1.ForwardOnError(Exception error) in /_/Rx.NET/Source/src/System.Reactive/Internal/Sink.cs:line 60
   at System.Reactive.Linq.ObservableImpl.Select`2.Selector._.OnNext(TSource value) in /_/Rx.NET/Source/src/System.Reactive/Linq/Observable/Select.cs:line 48
   at System.Reactive.Concurrency.Synchronize`1._.OnNext(TSource value) in /_/Rx.NET/Source/src/System.Reactive/Concurrency/Synchronization.Synchronize.cs:line 44
   at System.Reactive.AutoDetachObserver`1.OnNextCore(T value) in /_/Rx.NET/Source/src/System.Reactive/Internal/AutoDetachObserver.cs:line 71
   at System.Reactive.Subjects.Subject`1.OnNext(T value) in /_/Rx.NET/Source/src/System.Reactive/Subjects/Subject.cs:line 141
   at DynamicData.ObservableCache`2.InvokeNext(ChangeSet`2 changes) in /_/src/DynamicData/Cache/ObservableCache.cs:line 239
   at DynamicData.ObservableCache`2.UpdateFromSource(Action`1 updateAction) in /_/src/DynamicData/Cache/ObservableCache.cs:line 226
   at WalletWasabi.Fluent.Helpers.SignaledFetcher`2.<>c__DisplayClass1_1.<.ctor>b__1(IEnumerable`1 items) in WalletWasabi.Fluent\Helpers\SignaledFetcher.cs:line 20
   at System.Reactive.Linq.ObservableImpl.Do`1.OnNext._.OnNext(TSource value) in /_/Rx.NET/Source/src/System.Reactive/Linq/Observable/Do.cs:line 47
--- End of stack trace from previous location ---
   at System.Reactive.PlatformServices.ExceptionServicesImpl.Rethrow(Exception exception) in /_/Rx.NET/Source/src/System.Reactive/Internal/ExceptionServicesImpl.cs:line 19
   at System.Reactive.ExceptionHelpers.Throw(Exception exception) in /_/Rx.NET/Source/src/System.Reactive/Internal/ExceptionServices.cs:line 16
   at System.Reactive.Stubs.<>c.<.cctor>b__2_1(Exception ex) in /_/Rx.NET/Source/src/System.Reactive/Internal/Stubs.cs:line 16
   at System.Reactive.AnonymousSafeObserver`1.OnError(Exception error) in /_/Rx.NET/Source/src/System.Reactive/AnonymousSafeObserver.cs:line 62
   at System.Reactive.Sink`1.ForwardOnError(Exception error) in /_/Rx.NET/Source/src/System.Reactive/Internal/Sink.cs:line 60
   at System.Reactive.Linq.ObservableImpl.Do`1.OnNext._.OnNext(TSource value) in /_/Rx.NET/Source/src/System.Reactive/Linq/Observable/Do.cs:line 47
   at System.Reactive.ObserveOnObserverNew`1.DrainStep(ConcurrentQueue`1 q) in /_/Rx.NET/Source/src/System.Reactive/Internal/ScheduledObserver.cs:line 573
   at System.Reactive.ObserveOnObserverNew`1.DrainShortRunning(IScheduler recursiveScheduler) in /_/Rx.NET/Source/src/System.Reactive/Internal/ScheduledObserver.cs:line 516
   at Avalonia.ReactiveUI.AvaloniaScheduler.<>c__DisplayClass4_1`1.<Schedule>b__1()
   at Avalonia.Threading.DispatcherOperation.InvokeCore()
   at Avalonia.Threading.DispatcherOperation.Execute()
   at Avalonia.Threading.Dispatcher.ExecuteJob(DispatcherOperation job)
   at Avalonia.Threading.Dispatcher.ExecuteJobsCore(Boolean fromExplicitBackgroundProcessingCallback)
   at Avalonia.Threading.Dispatcher.Signaled()
   at Avalonia.Win32.Win32Platform.WndProc(IntPtr hWnd, UInt32 msg, IntPtr wParam, IntPtr lParam)
   at Avalonia.Win32.Interop.UnmanagedMethods.DispatchMessage(MSG& lpmsg)
   at Avalonia.Win32.Win32DispatcherImpl.RunLoop(CancellationToken cancellationToken)
   at Avalonia.Threading.DispatcherFrame.Run(IControlledDispatcherImpl impl)
   at Avalonia.Threading.Dispatcher.PushFrame(DispatcherFrame frame)
   at Avalonia.Threading.Dispatcher.MainLoop(CancellationToken cancellationToken)
   at Avalonia.Controls.ApplicationLifetimes.ClassicDesktopStyleApplicationLifetime.Start(String[] args)
   at Avalonia.ClassicDesktopStyleApplicationLifetimeExtensions.StartWithClassicDesktopLifetime(AppBuilder builder, String[] args, ShutdownMode shutdownMode)
   at WalletWasabi.Fluent.Desktop.WasabiAppExtensions.<>c__DisplayClass0_0.<RunAsGuiAsync>b__0() in WalletWasabi.Fluent.Desktop\Program.cs:line 196
   at WalletWasabi.Daemon.WasabiApplication.RunAsync(Func`1 afterStarting) in WalletWasabi.Daemon\WasabiAppBuilder.cs:line 66
   at WalletWasabi.Fluent.Desktop.WasabiAppExtensions.RunAsGuiAsync(WasabiApplication app) in WalletWasabi.Fluent.Desktop\Program.cs:line 150
   at WalletWasabi.Fluent.Desktop.Program.Main(String[] args) in WalletWasabi.Fluent.Desktop\Program.cs:line 63

Inner Exception:

ichthus1604 · 2023-10-25T15:10:31Z

@soosr Latest commit fixes the crash.

Credit to @SuperJMN for fixing the sorting issue ;)

soosr

tACK

History Grid Decoupling

739acb0

pull-request-size bot added the size/XXL label Oct 6, 2023

ichthus1604 added 6 commits October 9, 2023 10:33

fix

da035ae

Merge branch 'master' into UI-Decoupling50

abc61d5

fixes

c777841

Create SpeedUp/Cancelling Transaction

b8078bf

fixes

6709466

Fixes

7806155

ichthus1604 marked this pull request as ready for review October 9, 2023 19:57

soosr added 3 commits October 10, 2023 11:10

Merge branch 'master' into UI-Decoupling50

c97189a

remove redundant sorting

f3ccd11

fix build

a3692bf

ichthus1604 mentioned this pull request Oct 10, 2023

UI Decoupling progress tracking #10761

Open

soosr suggested changes Oct 12, 2023

View reviewed changes

ichthus1604 and others added 9 commits October 17, 2023 12:23

Merge branch 'master' into UI-Decoupling50

b6516ad

fix merge from master

c140672

fixes

aac784c

Fixes

0f38741

Merge branch 'UI-Decoupling50' of https://github.com/ichthus1604/Wall…

c96af2d

…etWasabi into UI-Decoupling50

Move to OnActivate

8bcf28e

fix SpeedupGroup

c2ae243

Merge branch 'UI-Decoupling50' of https://github.com/ichthus1604/Wall…

e20a545

…etWasabi into UI-Decoupling50

Use auto property

d8aecc8

kiminuo mentioned this pull request Oct 18, 2023

Wallet: Add TryGetTransactionSummary and use it #11703

Closed

ichthus1604 added 2 commits October 18, 2023 10:18

Add sorting back

4d9de14

Merge branch 'master' into UI-Decoupling50

57db41f

merge fix

a97e10e

soosr suggested changes Oct 18, 2023

View reviewed changes

ichthus1604 added 3 commits October 18, 2023 15:55

add IsEmpty

c2c8d5b

fix sorting

bc5600e

Inline temporary variable

420fda3

soosr reviewed Oct 18, 2023

View reviewed changes

ichthus1604 and others added 3 commits October 19, 2023 11:10

Merge branch 'master' into UI-Decoupling50

dfa2c61

master merge fix

3439718

Improve code

726206e

Merge branch 'master' into UI-Decoupling50

f0778bf

SuperJMN added 3 commits October 25, 2023 10:56

Fix History update issues

dde6f98

Merge branch 'UI-Decoupling50' of https://github.com/ichthus1604/Wall…

a9c9f42

…etWasabi into UI-Decoupling50

Merge from master

04f9151

SuperJMN mentioned this pull request Oct 25, 2023

Wallet Coins doesn't update coins, old spent coins are still displayed #11788

Closed

Fix inability to remove items

f9b2acc

SuperJMN mentioned this pull request Oct 25, 2023

BuildHistorySummary's result gets blocked in HistoryViewModel.UpdateAsync #11682

Closed

SuperJMN and others added 2 commits October 25, 2023 17:00

Reverse order of SpeedUp Children

5bad2e3

remove exception for null parent of CPFP

98f8f15

ichthus1604 requested a review from soosr October 25, 2023 17:11

soosr approved these changes Oct 25, 2023

View reviewed changes

soosr merged commit d998765 into WalletWasabi:master Oct 25, 2023
5 of 7 checks passed

soosr mentioned this pull request Oct 31, 2023

Private Balance vs Total Balance #11756

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[VDG] UI Decoupling #50 #11644

[VDG] UI Decoupling #50 #11644

ichthus1604 commented Oct 6, 2023 •

edited

Loading

soosr commented Oct 6, 2023

ichthus1604 commented Oct 9, 2023

soosr commented Oct 12, 2023

soosr commented Oct 12, 2023

soosr left a comment

soosr left a comment

soosr left a comment

soosr commented Oct 24, 2023

SuperJMN commented Oct 24, 2023

soosr commented Oct 24, 2023

ichthus1604 commented Oct 24, 2023

SuperJMN commented Oct 25, 2023

SuperJMN commented Oct 25, 2023

soosr commented Oct 25, 2023

ichthus1604 commented Oct 25, 2023

soosr left a comment

[VDG] UI Decoupling #50 #11644

[VDG] UI Decoupling #50 #11644

Conversation

ichthus1604 commented Oct 6, 2023 • edited Loading

soosr commented Oct 6, 2023

ichthus1604 commented Oct 9, 2023

soosr commented Oct 12, 2023

soosr commented Oct 12, 2023

soosr left a comment

Choose a reason for hiding this comment

soosr left a comment

Choose a reason for hiding this comment

soosr left a comment

Choose a reason for hiding this comment

soosr commented Oct 24, 2023

SuperJMN commented Oct 24, 2023

soosr commented Oct 24, 2023

ichthus1604 commented Oct 24, 2023

SuperJMN commented Oct 25, 2023

SuperJMN commented Oct 25, 2023

soosr commented Oct 25, 2023

ichthus1604 commented Oct 25, 2023

soosr left a comment

Choose a reason for hiding this comment

ichthus1604 commented Oct 6, 2023 •

edited

Loading