Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[master] FOSS UpdateManager + Remove LegalChecker #13101

Merged
merged 12 commits into from
May 31, 2024

Conversation

turbolay
Copy link
Collaborator

This PR is a port of all the PRs that have been made on the Downsize+FOSS branch about LegalChecker and UpdateManager

#12980
#13027
#13050
#13098
#13085
#13100

There is only one tweak: #12980 breaks backward compatibility as the backend doesn't return a LegalDocument which breaks at least the UpdateManager. So I reverted changes backend side.

I didn't have time to test on Regtest so maybe I forgot some stuff, would be great to have some reviews/tests

@lontivero
Copy link
Collaborator

What's the purpose of this PR?

@turbolay
Copy link
Collaborator Author

What's the purpose of this PR?

As we mentioned last week, it is better to merge the UpdateManager to master right now so the client keeps discovering releases if the backend is not available.

Considering that the new UpdateManager is built on one of your commit to remove LegalDocuments, and that the coinjoin service is stopped, I also included the removal of legal documents.

@lontivero
Copy link
Collaborator

I see, it makes sense. thank you

lontivero
lontivero previously approved these changes May 30, 2024
yahiheb
yahiheb previously approved these changes May 30, 2024
Copy link
Collaborator

@yahiheb yahiheb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested this a bit, I don't get the Legal Documents, so this partially fixes #13096.

@turbolay
Copy link
Collaborator Author

I'm testing this extensively today and will merge tonight if no problem arise

@turbolay turbolay dismissed stale reviews from yahiheb and lontivero via b3e40e9 May 31, 2024 00:50
Copy link
Collaborator Author

@turbolay turbolay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tACK, this PR is a big improvement in many ways, as it fixes many problems on production or that have been introduced in Downsize+FOSS by #13027

Also thanks to this PR the auto-updater will work on 2.0.8 when we will transition to the Downsize+FOSS branch. On the other hand, it will be broken on all prior versions.

@turbolay turbolay merged commit c26e5f5 into WalletWasabi:master May 31, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants