-
Notifications
You must be signed in to change notification settings - Fork 492
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[master] FOSS UpdateManager + Remove LegalChecker #13101
Conversation
Refactor UpdateManager and remove UpdateChecker
What's the purpose of this PR? |
As we mentioned last week, it is better to merge the UpdateManager to master right now so the client keeps discovering releases if the backend is not available. Considering that the new UpdateManager is built on one of your commit to remove LegalDocuments, and that the coinjoin service is stopped, I also included the removal of legal documents. |
I see, it makes sense. thank you |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested this a bit, I don't get the Legal Documents, so this partially fixes #13096.
I'm testing this extensively today and will merge tonight if no problem arise |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tACK, this PR is a big improvement in many ways, as it fixes many problems on production or that have been introduced in Downsize+FOSS
by #13027
Also thanks to this PR the auto-updater will work on 2.0.8 when we will transition to the Downsize+FOSS
branch. On the other hand, it will be broken on all prior versions.
This PR is a port of all the PRs that have been made on the
Downsize+FOSS
branch aboutLegalChecker
andUpdateManager
#12980
#13027
#13050
#13098
#13085
#13100
There is only one tweak: #12980 breaks backward compatibility as the backend doesn't return a
LegalDocument
which breaks at least theUpdateManager
. So I reverted changes backend side.I didn't have time to test on Regtest so maybe I forgot some stuff, would be great to have some reviews/tests