Fix UpdateManager on Linux #13120
Merged
Fix UpdateManager on Linux #13120
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
turbolay
commented
May 31, 2024
| private record ReleaseInfo(Version LatestClientVersion, List<string> AssetDownloadLinks) | ||
| { | ||
| public string InstallerDownloadUrl { get; set; } = ""; | ||
| public string InstallerFileName { get; set; } = ""; |
There was a problem hiding this comment.
I didn't want to deal with Nullable
turbolay
commented
May 31, 2024
| @@ -248,22 +246,22 @@ private async Task DownloadAndValidateWasabiSignatureAsync(string sha256SumsFile | |||
| } | |||
| } | |||
|
|
|||
| private (string url, string fileName) GetAssetToDownload(List<string> assetDownloadURLs) | |||
| private (string url, string fileName) GetAssetToDownload(List<string> assetDownloadLinks) | |||
There was a problem hiding this comment.
assetDownloadURLs gives a Warning
turbolay
commented
May 31, 2024
| @@ -28,7 +28,7 @@ public UpdateManager(TimeSpan period, string dataDir, bool downloadNewVersion, I | |||
| GithubHttpClient = githubHttpClient; | |||
| WasabiClient = sharedWasabiClient; | |||
| // The feature is disabled on linux at the moment because we install Wasabi Wallet as a Debian package. | |||
| DownloadNewVersion = downloadNewVersion && !RuntimeInformation.IsOSPlatform(OSPlatform.Linux); | |||
| DownloadNewVersion = downloadNewVersion && (RuntimeInformation.IsOSPlatform(OSPlatform.OSX) || RuntimeInformation.IsOSPlatform(OSPlatform.Windows)); | |||
There was a problem hiding this comment.
Here I changed slightly because it better fits with the rest of the logic in GetAssetToDownload
MarnixCroes
approved these changes
May 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #13118