-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Script does not play nicely with Umbrel instance #1
Comments
Hi @anthony-robin! As for this issue, if I'm not mistaken anyone could add an instance URL to match in Tampermonkey : in the dashboard, click on the script then on the As you can understand, since there's an undefined number of IV instances, It's impossible to match all of them right out of the box in the script. That's why I decided to only match the main ones listed on their api website (the https ones to be precise as I don't know how to deal with the other protocoles). However, although I'm not familiar with Umbrel, I could add the URLs if by default they are the same (with the same port) for all users who install and use IV through it (and for any other OS that has a common default local IV url). Finally, we are left with the |
I added support for http protocol. however for Umbrel, I'm waiting for you to confirm to me that IV always (or by default at least) uses the port 3420, as I'm looking into how I could make it work. |
Thank you very much for your quick reply and for considering my issue :) I can confirm you that everybody installing Invidious from Umbrel would have default port to I think it is not a big deal to have to add manually these URL in Tampermonkey settings as long as Thank you :) |
Hi, |
Your script did not work on my Umbrel instance, port did not get append to the host. Why not using It seems also that After updating the code as following, script worked again: // @match *://umbrel.local:3420/*
// @match *://umbrel:3420/*
// ...
const IVinstance = protocol + "//" + window.location.host;
// ... First What do you think about this ? :) |
oh I didn't know about thank you for your help! |
You're welcome :) |
Thank you very much for this script, this feature is so nice to have on Invidious ! ❤️
I tried it with my Umbrel Invidious self-hosted app and I had to make some adjustements to make it work. After investigating the script, I found that
const IVinstance = "https://" + window.location.hostname;
:https
(Umbrel does not yet support it)Would you consider supporting out of the box Umbrel instance for these default URLs:
http://umbrel.local:3420
(from same network as Umbrel)http://umbrel:3420
(from external network using Tailscale VPN)or, maybe adapt
IVinstance
to not forcehttps
but allowing custom port, then letting users to manually add any Invidious self-hosted instance in Tampermonkey settings ?What do you think about this ?
Thank you :)
The text was updated successfully, but these errors were encountered: