Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Smooth rotations: Use rate_func for CubeMove #6

Open
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

vvolhejn
Copy link

This change makes CubeMove use the rate_func parameter that specifies how the animation progresses. So by default, the rotation will be smooth, whereas the current default is a linear function (constant speed). To revert back to the old behavior, rate_func=linear can be passed to Scene.play, e.g.

self.play(CubeMove(cube, "F"), run_time=1, rate_func=linear)

@WampyCakes
Copy link
Owner

I'm not really ready to merge either of your PRs as I have a lot of changes locally that I think should be incorporated first. I think you have made some good suggestions and improvements, and I will look to incorporate some of them in the future (depending on how much you care about contributions on GH, either directly or through an edited PR by you). I am currently unable to give an estimate of when I'll do this. In the meantime, you're getting a nice local edit of manim-rubikscube going that should serve you well!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants