former : evolve

Wandalen · Apr 20, 2024 · 28a7503 · 28a7503
1 parent 074bcdd
commit 28a7503
Show file tree

Hide file tree

Showing 9 changed files with 8 additions and 44 deletions.
diff --git a/module/core/former/src/hash_map.rs b/module/core/former/src/hash_map.rs
@@ -171,7 +171,7 @@ where
 
 // pub type HashMapSubformer< K, E, Context, End > = ContainerSubformer::< ( K, E ), HashMapDefinition< K, E, Context, End > >;
 
-// xxx : update documentation
+// zzz : update documentation
 // pub type HashMapSubformer< K, E, Context, End > = ContainerSubformer::< K, HashMapDefinition< K, E, Context, End > >;
 pub type HashMapSubformer< K, E, Context, Formed, End > =
 ContainerSubformer::< ( K, E ), HashMapDefinition< K, E, Context, Formed, End > >;

diff --git a/module/core/former/src/hash_set.rs b/module/core/former/src/hash_set.rs
@@ -120,7 +120,7 @@ where
 /// # }
 /// ```
 
-// xxx : update documentation
+// zzz : update documentation
 // write: instead of writing long version with ContainerSubformer it's possible to be more concise with help of the type alias
 //
 pub type HashSetSubformer< K, Context, Formed, End > =

diff --git a/...sts/only_test/with_field_under_feature.rs → ...sts/inc/former_tests/attribute_feature.rs b/...sts/only_test/with_field_under_feature.rs → ...sts/inc/former_tests/attribute_feature.rs
@@ -1,4 +1,5 @@
 // xxx : need to fix
+
 // #[ derive( Former ) ]
 // struct Foo
 // {

diff --git a/module/core/former/tests/inc/former_tests/container_former_common.rs b/module/core/former/tests/inc/former_tests/container_former_common.rs
@@ -42,7 +42,7 @@ fn definitions()
 fn begin_and_custom_end()
 {
 
-  // xxx : make example with that
+  // zzz : make example with that
 
   // basic case
 
@@ -94,7 +94,7 @@ fn begin_and_custom_end()
 fn custom_definition()
 {
 
-  // xxx : make example of that
+  // zzz : make example of that
 
   struct Return13;
   impl former::FormerDefinitionTypes for Return13
@@ -152,7 +152,7 @@ fn custom_definition()
 fn custom_definition_parametrized()
 {
 
-  // xxx : make example of that
+  // zzz : make example of that
 
   struct Return13< E >( ::core::marker::PhantomData< E > );
 

diff --git a/module/core/former/tests/inc/former_tests/only_test/basic.rs b/module/core/former/tests/inc/former_tests/only_test/basic.rs
@@ -34,7 +34,6 @@ tests_impls!
 
   //
 
-// xxx : uncomment
   fn custom_definition_params()
   {
 

diff --git a/module/core/former/tests/inc/former_tests/parametrized_struct_manual.rs b/module/core/former/tests/inc/former_tests/parametrized_struct_manual.rs
@@ -183,7 +183,6 @@ impl< K, > former :: StoragePreform for CommandFormerStorage< K, > where K : cor
   }
 }
 
-  // xxx
 pub struct CommandFormer< K, Definition = CommandFormerDefinition< K, (), Command< K, >, former::ReturnPreformed >, >
 where
   K : core::hash::Hash + std::cmp::Eq,
@@ -290,7 +289,7 @@ where
   }
 }
 
-// xxx
+//
 
 impl< K, Definition, > CommandFormer< K, Definition, >
 where

diff --git a/module/core/former/tests/inc/former_tests/subformer_basic.rs b/module/core/former/tests/inc/former_tests/subformer_basic.rs
@@ -106,40 +106,6 @@ where
   pub commands : collection_tools::HashMap< String, Command< K > >,
 }
 
-// xxx : remove
-// pub type CommandSubformerWithClosure< K, Superformer > = CommandFormer
-// <
-//   K,
-//   CommandFormerDefinition
-//   <
-//     K,
-//     Superformer,
-//     Superformer,
-//     former::FormingEndClosure< CommandFormerDefinitionTypes< K, Superformer, Superformer > >,
-//   >,
-// >;
-//
-// pub trait CommandSubformerEnd< K, SuperFormer >
-// where
-//   K : core::hash::Hash + std::cmp::Eq,
-//   Self : the_module::FormingEnd
-//   <
-//     CommandFormerDefinitionTypes< K, SuperFormer, SuperFormer >,
-//   >
-// {
-// }
-//
-// impl< K, SuperFormer, T > CommandSubformerEnd< K, SuperFormer >
-// for T
-// where
-//   K : core::hash::Hash + std::cmp::Eq,
-//   Self : the_module::FormingEnd
-//   <
-//     CommandFormerDefinitionTypes< K, SuperFormer, SuperFormer >,
-//   >
-// {
-// }
-
 // ==
 
 include!( "./only_test/subformer_basic.rs" );
diff --git a/module/core/former/tests/inc/former_tests/subformer_custom_experimental.rs b/module/core/former/tests/inc/former_tests/subformer_custom_experimental.rs
@@ -102,7 +102,6 @@ where
 
 //
 
-/// xxx : extend description
 /// get container for a field out of a storage
 pub trait FormerStorageExtractContainer< Target >
 {
@@ -131,7 +130,6 @@ where
 
 //
 
-/// xxx : extend description
 /// extract storage from a former
 pub trait FormerExtractStorage
 {

diff --git a/module/core/former/tests/inc/mod.rs b/module/core/former/tests/inc/mod.rs
@@ -31,6 +31,7 @@ mod former_tests
   mod attribute_perform;
   mod attribute_setter;
   mod attribute_alias;
+  // mod attribute_feature; // xxx : write test
 
   mod string_slice_manual;
   mod string_slice;