AUTO : Forward from alpha to beta #1240
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Re-use help for dot help and other variants Re-work help related things in aggregator to be removed after use
READY : Rename & fix
READY : Facade for dependencies
Revamp the existing difference functionality by introducing a new enum 'DiffItem' that now allows to specify differences both in file and in content separately. This change significantly increases the level of detail in displaying what has changed between files or contents. The 'similar' crate has been added to assist in providing this improved diff functionality.
…o wca_re_work_help_generation
The `DiffReport` struct is now cloneable, and received two new methods: `exclude` and `has_changes`. The former allows for exclusion of specified items from a report, while the latter checks if there are changes within the `DiffItems`. The commit also modifies the `crate_diff` function to compare two crate archives more accurately, as well as incorporating the `IGNORE_LIST` in the `publish_diff` and `package` modules to exclude certain files from the differential report.
The IGNORE_LIST constant in `module/move/willbe/src/entity/package.rs` file has been updated. Instead of ignoring "Cargo.toml.orig", the updated list now ignores "Cargo.toml". This change aligns with the fact that "Cargo.toml" files are more crucial to track for changes.
READY : (willbe): Update diff functionality and improve detail
The constant `IGNORE_LIST`, containing file names that are safe to be changed without affecting functionality, has been moved from `publish_diff.rs` and `package.rs` to `diff.rs`. This centralizes tracking of ignored files in our code and simplifies iterations across other modules. Now, `publish_diff` and `package` reference this constant from `diff.rs`, enhancing code readability and maintenance.
READY: (willbe): Move ignore list constant to diff module
The "Cargo.lock" file was added to the PUBLISH_IGNORE_LIST constant. This change ensures that when we are analyzing changes between different commits, the "Cargo.lock" file is ignored alongside ".cargo_vcs_info.json" and "Cargo.toml".
READY: (willbe): Add "Cargo.lock" to PUBLISH_IGNORE_LIST constant
This commit adds a description for `Cargo.lock` in the constant array `PUBLISH_IGNORE_LIST`. It provides an understanding that, `Cargo.lock` is an auto-generated file by Cargo having versions of dependencies which doesn't impact functionality.
READY: (willbe): Add details about `Cargo.lock` in PUBLISH_IGNORE_LIST
READY: (wca): Re-work help generation and removing unsafe code
READY : Cicd fix
HelpGeneratorArgs has been renamed to HelpGeneratorOptions to better reflect its purpose. The help content generator now makes use of a new table formatting tool which simplifies the generation and formatting of tables. This tool exists in the newly created 'tool' module which might encompass more general-purpose tools in the future.
Removed unused files command.rs and runtime.rs under the executor module and simplified executor.rs structure for clearer logic and readability. Updated context.rs to use get() function instead of get_ref(). Also, revised the function signature in help.rs for enhanced clarity.
The parsing and verification process for commands has been streamlined. Redundant conditions were removed and replaced with a more straightforward approach. Additionally, support has been added for identifying internal commands, a flag has been added in the command structure for this purpose. These changes lead to cleaner and more intuitive code.
The code now supports the execution of internal commands. It removes the previously standalone `dot_command` mechanism, transforming it into part of the broader command execution process. Additionally, it introduces a new `search` function in the dictionary that finds commands matching a given name.
READY: (wca): Enhance command parsing and verification and impose internal command execution
RADY : add facade for `preatytable`
READY : toposort with grouping
READY (willbe) : Readme fix
READY : (wca): Refactor help generator and implement table formatting tool
Renamed HelpGeneratorArgs to HelpGeneratorOptions and made generate_help_content function more accessible for internal crate use. Adjusted how command is parsed within the help and executor modules, notably by handling command prefixes differently. Made minor changes to table formatting for better output and removed unnecessary test cases in command.rs.
READY: (wca): Refactor help command handling and clean up tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an automated pull request to update from branch alpha