Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add TOML Config File Feature #13

Closed
wants to merge 9 commits into from
Closed

Conversation

alikhan1998
Copy link

@alikhan1998 alikhan1998 commented Oct 5, 2023

/Ready for Review

Purpose:
This Pull Request introduces the TOML config file feature to enhance the flexibility and user-friendliness of the CLI application. The need for a configuration file arises from the desire to allow users to specify options more conveniently and store preferences persistently.

Key Changes:

  • Added support for parsing TOML config files.
  • Implemented command-line option to specify the config file path.
  • Integrated TOML parsing library for reliable configuration data handling.

Context:
This enhancement is in line with the project's goal to streamline configuration management and improve the user experience. It addresses [issue link], where users requested the ability to use config files.

Note:
This Pull Request is marked as a "Draft" to indicate that further refinements and testing may be necessary. Your feedback and suggestions are welcome as we work towards the final implementation.

@alikhan1998
Copy link
Author

WangGithub0
Please note that I've completed my work on this feature. Could you please review and test the code? Thank you!

@WangGithub0
Copy link
Owner

@alikhan1998 thanks for your PR, could you provide a Config File example?

@alikhan1998
Copy link
Author

This is a TOML configuration file example

Server settings

[server]
port = 8080
hostname = "example.com"

Database settings

[database]
host = "db.example.com"
port = 5432
username = "myuser"
password = "mypassword"
database_name = "mydb"

Logging settings

[logging]
level = "info"
file_path = "/var/log/myapp.log"

@WangGithub0
Copy link
Owner

@alikhan1998 could you add a file in the project, and also revise the README

@WangGithub0
Copy link
Owner

@alikhan1998 my main usage is java src/ConvertTxtToHtml.java
could you provide me how to combine your code and my old part? thanks

Copy link

@humphd humphd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is Python code, I'm unclear why you're submitting it when the project is written in Java.

Please fix your PR to use the proper language.

@alikhan1998
Copy link
Author

I have done all the changes. Kindly recheck it

@WangGithub0
Copy link
Owner

@alikhan1998 I can't find --config in the src/ConvertTxtToHtml.java file in your PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants