Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add drag and zoom to gui #212

Merged
merged 2 commits into from
Oct 25, 2017
Merged

Add drag and zoom to gui #212

merged 2 commits into from
Oct 25, 2017

Conversation

kevinzg
Copy link
Contributor

@kevinzg kevinzg commented Oct 19, 2017

This solves #174 #175
Hope it is useful

@hryniuk hryniuk requested review from hryniuk and removed request for hryniuk October 19, 2017 20:20
@hryniuk hryniuk self-assigned this Oct 19, 2017
@hryniuk
Copy link
Member

hryniuk commented Oct 19, 2017

Thank you a lot, I'll check it during this weekend.

@hryniuk
Copy link
Member

hryniuk commented Oct 25, 2017

Seems OK for me, sorry for the delay. I see two things to do here:

  • adding a "Reset" ("Reset view" or similar) button for restoring the original view (zoom and position)
  • (optional) adding buttons/slider for zoom-in and zoom-out

...but they should be done in a separate PRs.

Before merging I'll try to fix these builds.

@hryniuk
Copy link
Member

hryniuk commented Oct 25, 2017

There're missing files (CustomGraphicsView) in .vcxproj files, I'll push them separately.

Thank you :)!

@hryniuk hryniuk merged commit 180bfd3 into Wangscape:master Oct 25, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hryniuk hryniuk hryniuk approved these changes

Assignees

@hryniuk hryniuk

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@kevinzg @hryniuk