Simplify getting SourceText in source generator
#138
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There's no reason to create a `SyntaxTree` first. The text will be reparsed anyway by Roslyn. This change avoid doing additional work in the source generator for no benefit. The recommended way to add a source from a `CompilationUnitSyntax` is to use `compilationUnit.GetText(Encoding.UTF8)`. See https://github.com/dotnet/roslyn/issues/61506
amis92
approved these changes
May 25, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There's no reason to create a
SyntaxTreefirst. The text will be reparsed anyway by Roslyn. This change avoids doing additional work in the source generator for no benefit. The best way to add a source from aCompilationUnitSyntaxis to usecompilationUnit.GetText(Encoding.UTF8). See dotnet/roslyn-analyzers#6017I noticed this in dotnet/roslyn#122, which I found a link to in https://github.com/AArnott/CodeGeneration.Roslyn.