Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add in Covenant Abilities #11

Closed
7 tasks done
seanpeters86 opened this issue Jul 28, 2020 · 3 comments
Closed
7 tasks done

Add in Covenant Abilities #11

seanpeters86 opened this issue Jul 28, 2020 · 3 comments
Assignees
@seanpeters86
Labels
apl Action Priority List in SimC simc SimC Module work
Milestone
Covenant Systems

Comments

@seanpeters86
Copy link
Contributor

seanpeters86 commented Jul 28, 2020 •
edited
Loading

Need to add in the new Covenant abilities. This might be partially blocked as we wait for generic SimC module support to be done. We could still build the spells and just not link them in yet though, TBD.

ACs:

  • Unholy Nova implemented and added to the APL
  • Mindgames implemented and added to the APL
  • Boon of the Ascended implemented and added to the APL (along with Ascended Nova and Ascended Blast)
  • Fae Blessings implemented and added to the APL
  • Add option to fae blessings to reduce CDR chance from 100%
  • Add Unholy Transfusion to Unholy Nova
  • Make Mindgames insanity configurable
@seanpeters86 seanpeters86 added simc SimC Module work apl Action Priority List in SimC blocked Can't be worked on labels Jul 28, 2020
@seanpeters86 seanpeters86 removed the blocked Can't be worked on label Jul 28, 2020
@seanpeters86
Copy link
Contributor Author

Looks like Demon Hunters have gone ahead with covenant abilities, we should be good to start: simulationcraft/simc@7574fa0

@seanpeters86 seanpeters86 mentioned this issue Jul 29, 2020
Closed
12 tasks
@seanpeters86
Copy link
Contributor Author

started work here: simulationcraft/simc#5191

@seanpeters86 seanpeters86 self-assigned this Aug 1, 2020
@seanpeters86
Copy link
Contributor Author

kyrian pr: simulationcraft/simc#5193

@seanpeters86 seanpeters86 added this to the Covenant Systems milestone Aug 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@seanpeters86 seanpeters86

Labels
apl Action Priority List in SimC simc SimC Module work
Projects
None yet
Milestone
Covenant Systems
Development

No branches or pull requests
1 participant
@seanpeters86