New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Human mission 10 instantly fails #458
Comments
I verified that stratagus PR 626 (Check each trigger-condition in each cycle) causes the failure. |
More details:
In GameCycle=1 the units are still of type unit-peasant. In GameCycle=2 the units are of type unit-attack-peasant. Before PR 626, in GameCycle=1 the first trigger was checked (IfRescuedNearUnit). In GameCycle=2 the second trigger (the problematic one, GetPlayerData ....) was executed. Switching the order of triggers would also have broken it. Now all triggers are executed in each cycle and it fails now in GameCycle=1 running the second trigger. Options to fix it:
|
With the original TransformUnit the unit-peasant become unit-attack-peasant only in GameCycle=2. But the Defeat-Trigger that counts them is already executed in in GameCycle=1. This trigger then counts 0 units of type 'unit-attack-peasant' and the mission is lost. Closes: Wargus#458
With the original TransformUnit the unit-peasant become unit-attack-peasant only in GameCycle=2. But the Defeat-Trigger that counts them is already executed in in GameCycle=1. This trigger then counts 0 units of type 'unit-attack-peasant' and the mission is lost. This happens since Wargus/stratagus#626 was merged: b5e5bb0c6a18ccbf ("Merge pull request #626 from zzam/trigger-each-cycle") Before the code was fragile but it worked due to the ordering of triggers. Closes: Wargus#458
With the original TransformUnit the unit-peasant become unit-attack-peasant only in GameCycle=2. But the Defeat-Trigger that counts them is already executed in in GameCycle=1. This trigger then counts 0 units of type 'unit-attack-peasant' and the mission is lost. This happens since Wargus/stratagus#626 was merged: b5e5bb0c6a18ccbf ("Merge pull request #626 from zzam/trigger-each-cycle") Before the code was fragile but it worked due to the ordering of triggers. Closes: Wargus#458
With the original TransformUnit the unit-peasant become unit-attack-peasant only in GameCycle=2. But the Defeat-Trigger that counts them is already executed in in GameCycle=1. This trigger then counts 0 units of type 'unit-attack-peasant' and the mission is lost. This happens since Wargus/stratagus#626 was merged: b5e5bb0c6a18ccbf ("Merge pull request #626 from zzam/trigger-each-cycle") Before the code was fragile but it worked due to the ordering of triggers. Closes: #458
Describe the bug
DileriumL reported in Discord:
When starting the human mission 10 in wargus then the mission is immediately lost.
To Reproduce
Steps to reproduce the behavior:
Expected behavior
The game starts and can be played
Screenshots and Logs
Desktop (please complete the following information):
The text was updated successfully, but these errors were encountered: