Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix package installation for yarn, add support for bun.lock #51

Conversation

shimizu-izumi
Copy link
Contributor

I added a new private function between getPackageManager and installDependency to get the installation command based on the package manager.

I made 4 blank next.js shadcn/ui projects to test it, one for each package manager and install and dev install work for all package managers now.

The install command is hardcoded to i in the current version which only works for NPM according to documentations of the package managers.

@WarningImHack3r
Copy link
Owner

Thanks for your contribution!
I did hardcode i as it's supposed to work with all package managers despite not being listed in some of them's docs. However I just tried with yarn (the only one I never used), which I never did before, and it's indeed not supported, sorry!

@WarningImHack3r WarningImHack3r changed the title Depdency install fix: Update DependencyManager.kt to use package mana… Fix package installation for yarn Jun 22, 2024
@shimizu-izumi
Copy link
Contributor Author

I tried adding the requested changes by trying a few things but I don't know enough about the codebase and Kotlin to do it.

@WarningImHack3r
Copy link
Owner

Alright no problem, I’ll take it from here, thank you very much for your time and investigation!

@WarningImHack3r WarningImHack3r changed the title Fix package installation for yarn Fix package installation for yarn, add support for bun.lock Jun 22, 2024
@WarningImHack3r WarningImHack3r merged commit 38bc0f2 into WarningImHack3r:main Jun 22, 2024
4 of 5 checks passed
@shimizu-izumi shimizu-izumi deleted the fix/no_dependency_install_yarn branch June 22, 2024 20:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants