-
Notifications
You must be signed in to change notification settings - Fork 0
Ticket to be used to hold the template dumps from the "legs" console command. #1687
Comments
Buginator commented (In [10313]) Add template dumping code. New console command, "legs" The file is created in your config logs/ directory. |
Cyp uploaded file Crash on sprintf(templateName, "%s", templatelist->pName); |
Cyp commented Above crashdump was tags/2.3_beta11a + commit [10313] + commit [10314]. Orange was just legs, hadn't seen cyborgs from other players. Assuming the players were in default position and colour, it's orange that caused the crash. First game since starting program, so probably not a resetting-stuff issue. logs/template_00-Sk-bagdad8-T1_232236.txt is 2617 bytes. (Will attach _00, but probably doesn't show anything useful.) |
Cyp uploaded file Templates from a player that probably had normal cyborgs. |
Buginator commented (In [10334]) Fix crash in "legs" routine. sprintf() doesn't handle NULLs very well in non windows version it seems. refs #1687 |
Cyp commented Hmmm...
prints “Hello world! (null) and sprintf (null)!” on my linux machine. Without crashing. |
Cyp commented Steps to reproduce:
I'm guessing the previous crash on "legs" earlier was "just" random corruption. The steps to reproduce involve clients being in nonsensical positions. I don't know if there's a way to reproduce without that (but if there isn't, then I already fixed the bug...). |
Buginator commented Replying to Warzone2100/old-trac-import#1687 (comment:4):
ermm... that isn't the same thing.
will crash every time I tried it.
will NOT crash, it does (null) correctly. |
Buginator commented Anyway, for the "legs" bug, (big thanks for the info on how to reproduce!), what happens is, we don't load the stats for the weapons. It looks like, when a player leaves the lobby, something gets reset that shouldn't. player 0 is host.
loadDroidWeapons() should be called for every player, and it is doing that for player 0 (host), the AI, but 'not for player 2, which is us. (38681e0) Why isn't it loading it for player 2 (us)? Dunno yet, didn't have time to find out, but I am inputting what is going on here, so perhaps someone else can fix it before I get back. :) |
Per uploaded file Could this be the solution to the problem? |
Cyp changed type from |
Cyp commented After applying fixlegs.diff, but forgetting to compile:
After applying fixlegs.diff and compiling:
I think that's a good sign. |
Per commented (In [10351]) Make sure all templates get all weapons. This hopefully fixes #1687 ie the cyborg leg issue. |
Per changed status from |
Per set resolution to |
Per commented (In [10352]) 2.3: Make sure all templates get all weapons. This hopefully fixes #1687 ie the cyborg leg issue. |
Git SVN Gateway <gateway@...> commented (In Warzone2100/warzone2100@b911060) Make sure all templates get all weapons. This hopefully fixes #1687 ie the cyborg leg issue. git-svn-id: https://warzone2100.svn.sourceforge.net/svnroot/warzone2100/trunk@10351 4a71c877-e1ca-e34f-864e-861f7616d084 |
Safety0ff commented This test case is no longer relevant, because of that break statement, having a AI/ no player in a slot lower than a human would cause the human to miss out on the cyborgs weapons. With that fix, it no longer breaks out, which fixes the test case. |
Git SVN Gateway <gateway@...> commented In Warzone2100/warzone2100@b911060:
|
resolution_fixed
type_patch (an actual patch, not a request for one)
| by BuginatorIf you run into "legs" in your multiplayer battles then enter legs into the console. (hit enter, type legs then hit enter again)
It will generate a few files for us to investigate what is going on.
The files will be in your config directory under logs/ and they will follow the following format:
Issue migrated from trac:1687 at 2022-04-15 21:13:25 -0700
The text was updated successfully, but these errors were encountered: