Skip to content
This repository has been archived by the owner on Apr 17, 2022. It is now read-only.

d395bafd040c79932187ad657232e2471819ab4a breaks VS2013 builds! #4466

Closed
wzdev-ci opened this issue Aug 8, 2016 · 24 comments
Closed

d395bafd040c79932187ad657232e2471819ab4a breaks VS2013 builds! #4466

wzdev-ci opened this issue Aug 8, 2016 · 24 comments

Comments

@wzdev-ci
Copy link
Contributor

wzdev-ci commented Aug 8, 2016

resolution_fixed type_bug | by alistar


please revert back to old system!
old system works for both VS2013 & VS2015 (I have both!)

new system breaks VS2013 and has hard code paths and the new system tries to download packages when I am on metered connection! NO!!!!!!
very bad design to download packages when they are already in old system way in devpkg!

please change back!


Issue migrated from trac:4466 at 2022-04-16 12:34:16 -0700

@wzdev-ci
Copy link
Contributor Author

wzdev-ci commented Aug 8, 2016

alistar commented


I forgot to say that it breaks vs2015 also since I no allow it to download anything!

@wzdev-ci
Copy link
Contributor Author

wzdev-ci commented Aug 8, 2016

Vincent changed _comment0 which not transferred by tractive

@wzdev-ci
Copy link
Contributor Author

wzdev-ci commented Aug 8, 2016

Vincent commented


devpkg is no more available. I searched on sourceforge and gna but it's nowhere to be found.

@wzdev-ci
Copy link
Contributor Author

wzdev-ci commented Aug 8, 2016

alistar changed _comment0 which not transferred by tractive

@wzdev-ci
Copy link
Contributor Author

wzdev-ci commented Aug 8, 2016

alistar commented


you download what needed and put everything in \devpkg it is very easy.
vs2015 free is not free it will not work offline! it requires online activation every time period which is bad. :( 2013 no have this problem!
why have C:\Qt\5.7\msvc2015_64\include;C:\Users\vljn_000\Documents\GitHub\warzone2100\3rdparty\physfs-2.0.3;?
not all qt install there! I no have vljn_000 user!
why use nuget to download as part build process? if it can not get it fails!

sry for my bad english

@wzdev-ci
Copy link
Contributor Author

wzdev-ci commented Aug 8, 2016

Vincent commented


Where did you find quesoglc? The official bin zip is missing glc32.lib.
There is no more binary physfs build either.

@wzdev-ci
Copy link
Contributor Author

wzdev-ci commented Aug 8, 2016

alistar commented


https://sourceforge.net/projects/quesoglc/files/0.7.2/ is download for quesoglc and http://icculus.org/pipermail/physfs/2012-October/001056.html is for physfs.
no binary! must compile all by hand to function correct.

@wzdev-ci
Copy link
Contributor Author

wzdev-ci commented Aug 8, 2016

alistar commented


same with qt 5 and rest of library need for game.
all compile by hand then move files to \devpkg and then works for both vs2013 & vs2015 but new system can only open in 2015 NOT 2013!

@wzdev-ci
Copy link
Contributor Author

wzdev-ci commented Aug 8, 2016

Per changed blocking which not transferred by tractive

@wzdev-ci
Copy link
Contributor Author

wzdev-ci commented Aug 8, 2016

Per changed blockedby which not transferred by tractive

@wzdev-ci
Copy link
Contributor Author

wzdev-ci commented Aug 8, 2016

Per commented


Don't know much about this change, but stopping support for Visual Studio at some old version (ie 2013) is not an acceptable solution, in my opinion. AFAIK VS2013's support for c++11 is somewhat sketchy, and we use that all over the place nowadays.

@wzdev-ci
Copy link
Contributor Author

wzdev-ci commented Aug 8, 2016

alistar commented


I do not understand?
vs2013 works fine with the game!
again old solution file support both vs2013 & vs2015!
there was no problem before this patch so why break things now?

@wzdev-ci
Copy link
Contributor Author

wzdev-ci commented Aug 9, 2016

Vincent commented


I'm not the only one who had trouble building with VS (even 2013) in the past :
http://forums.wz2100.net/viewtopic.php?f=32&t=11914&p=129943&hilit=visual+studio#p129943
On IRC it seemed that nobody know how to build wz2100 with Visual Studio either.

Compiling every dependencies by hand is not a solution in my opinion since there are a lot of (non trivial) dependencies here. I spent almost a day trying to gather all deps until I gave up and opted to use Nuget which acts as a package manager. Making compilation nearly impossible with VS is keeping a lot of potential contributors at bay.

I can make a patch that would duplicate solutions and project so that you can still build wz2100 while allowing people to build wz2100 with VS2015 with a single F5 press.

@wzdev-ci
Copy link
Contributor Author

wzdev-ci commented Aug 9, 2016

alistar commented


you mean make double solution file?
one for offline and other use nuget?
yes that work.

@wzdev-ci
Copy link
Contributor Author

alistar commented


is fix come soon?

@wzdev-ci
Copy link
Contributor Author

Vincent uploaded file 0001-Fix-VS2015-build-part-2.patch (392.9 KiB)

@wzdev-ci
Copy link
Contributor Author

Vincent commented


This patch copy the old sln/vcproj/vcproj.filters. It also includes the content of the previous patch (#4467) that fixes draw_tex and netplay.

@wzdev-ci
Copy link
Contributor Author

Cyp changed status from new to closed

@wzdev-ci
Copy link
Contributor Author

Cyp changed resolution from `` to fixed

@wzdev-ci
Copy link
Contributor Author

Cyp commented


I don't have any version of MSVC to test, but if I understand right, 4988349910defdb12329615fbd0e6f85a0d18400 fixes #4466, #4467 and #4491.

@wzdev-ci
Copy link
Contributor Author

Cyp commented


P.S. It's better if the commit messages start with a one-line summary, followed by a blank line, then followed by the rest, otherwise some git tools may get slightly confused.

@wzdev-ci
Copy link
Contributor Author

Cyp commented


P.P.S. By the way (not related to this ticket), std::thread, std::mutex and std::condition_variable don't work when cross-compiling (at least not with the version we currently use), see f5c622e4e7b2f550a99339867c9075b7ffa59e9a.

@wzdev-ci
Copy link
Contributor Author

Vincent commented


Is there a replacement for packaged_task supported by cross compiler ? I think the abstraction would naturally fits the threading code in fpath.cpp (this would remove the std::list object and remove the lock to fetch work completion) ; thread and condition variable can be replaced by the current wz functions.

@wzdev-ci
Copy link
Contributor Author

Cyp commented


Don't know of a replacement, pity since it sounds like it could make the code a bit simpler.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

1 participant