Skip to content
This repository was archived by the owner on Apr 17, 2022. It is now read-only.
This repository was archived by the owner on Apr 17, 2022. It is now read-only.

"research completed" sound should not play when clicking on a researched item #60

Closed

Description

@wzdev-ci

resolution_fixed type_patch (an actual patch, not a request for one) | by rob@...


When clicking on a researched item in the objectives screen, the sample "research completed" is played for every click. Thats simply annoying.


Issue migrated from trac:60 at 2022-04-15 17:41:16 -0700

Activity

  1. wzdev-ci commented on Sep 9, 2008

    @wzdev-ci
    ContributorAuthor

    EvilGuru changed status from new to accepted

  2. wzdev-ci commented on Sep 9, 2008

    @wzdev-ci
    ContributorAuthor

    EvilGuru changed owner from `` to EvilGuru

  3. wzdev-ci commented on Sep 9, 2008

    @wzdev-ci
    ContributorAuthor

    EvilGuru commented


    This is the offending code (from intelmap.c):

    #!c
    switch(psResearch->iconID)
    {
    	case IMAGE_RES_DROIDTECH:
    		audio_PlayStream("sequenceaudio/res_droid.ogg", maxVolume, NULL, NULL);
    		break;
    	case IMAGE_RES_WEAPONTECH:
    		audio_PlayStream("sequenceaudio/res_weapons.ogg", maxVolume, NULL, NULL);
    			break;
    	case IMAGE_RES_COMPUTERTECH:
    		audio_PlayStream("sequenceaudio/res_com.ogg", maxVolume, NULL, NULL);
    				break;
    	case IMAGE_RES_POWERTECH:
    		audio_PlayStream("sequenceaudio/res_pow.ogg", maxVolume, NULL, NULL);
    			break;
    	case IMAGE_RES_SYSTEMTECH:
    		audio_PlayStream("sequenceaudio/res_systech.ogg", maxVolume, NULL, NULL);
    			break;
    	case IMAGE_RES_STRUCTURETECH:
    		audio_PlayStream("sequenceaudio/res_strutech.ogg", maxVolume, NULL, NULL);
    			break;
    	case IMAGE_RES_CYBORGTECH:
    		audio_PlayStream("sequenceaudio/res_droid.ogg", maxVolume, NULL, NULL);
    			break;
    	case IMAGE_RES_DEFENCE:
    		audio_PlayStream("sequenceaudio/res_strutech.ogg", maxVolume, NULL, NULL);
    			break;
    }
    

    If the community can reach a consensus on this I'll happily remove the code in question (or leave it alone, depending on the aforementioned consensus). For a bottle of Gin I'll make it a configurable option (with the default being whatever the consensus is).

  4. wzdev-ci commented on Sep 10, 2008

    @wzdev-ci
    ContributorAuthor

    Kreuvf commented


    The thing is that for every research-type mentioned in that piece of code in the original WZ a video has been played (that has audio that added some information on what type of research you researched) just to the right of the model.

    So a better option imho would be to extract the sound from the videos (they are GPL now, so we are allowed to do this :D) and replace the .ogg-files with the corresponding (correct) sound.

  5. wzdev-ci commented on Oct 12, 2008

    @wzdev-ci
    ContributorAuthor

    Giel changed operating_system which not transferred by tractive

  6. wzdev-ci commented on Oct 12, 2008

    @wzdev-ci
    ContributorAuthor

    Giel changed milestone from `` to 2.1

  7. wzdev-ci commented on Dec 1, 2008

    @wzdev-ci
    ContributorAuthor

    Buginator changed blocking which not transferred by tractive

  8. wzdev-ci commented on Dec 1, 2008

    @wzdev-ci
    ContributorAuthor

    Buginator changed blockedby which not transferred by tractive

  9. wzdev-ci commented on Dec 1, 2008

    @wzdev-ci
    ContributorAuthor

    Buginator commented


    The intel FMVs don't have any sound.
    It just uses the wav (.ogg) file for this. I guess since they supported more than one language.

    It repeats since we don't have a way to stop said sample. Well, easily that is.

    I was thinking we should just use a dedicated channel (source) for this, and all FMV related stuff, so we can stop it.

  10. wzdev-ci commented on May 15, 2009

    @wzdev-ci
    ContributorAuthor

    Zarel changed priority from minor to trivial

  11. wzdev-ci commented on May 15, 2009

    @wzdev-ci
    ContributorAuthor

    Zarel commented


    Well, now that we do have FMVs, thoughts?

  12. wzdev-ci commented on May 8, 2010

    @wzdev-ci
    ContributorAuthor

    Buginator removed milestone (was 2.1)

  13. wzdev-ci commented on May 8, 2010

    @wzdev-ci
    ContributorAuthor

    Buginator commented


    Milestone 2.1 deleted

  14. wzdev-ci commented on Jul 11, 2010

    @wzdev-ci
    ContributorAuthor

    Buginator changed status from accepted to closed

  15. wzdev-ci commented on Jul 11, 2010

    @wzdev-ci
    ContributorAuthor

    Buginator set resolution to fixed

  16. wzdev-ci commented on Jul 11, 2010

    @wzdev-ci
    ContributorAuthor

    Buginator commented


    (In [11147]) Prevent overlapping sounds when looking at intel information.

    fixes #60

  17. wzdev-ci commented on Jul 11, 2010

    @wzdev-ci
    ContributorAuthor

    Buginator commented


    (In [11148]) Prevent overlapping sounds when looking at intel information.

    fixes #60

    2.3:[11147]

  18. wzdev-ci commented on Jul 11, 2010

    @wzdev-ci
    ContributorAuthor

    Buginator commented


    (In [11149]) Prevent overlapping sounds when looking at intel information.

    fixes #60

    2.3: [11147]
    trunk: [11148]

  19. wzdev-ci commented on Jul 11, 2010

    @wzdev-ci
    ContributorAuthor

    Git SVN Gateway <gateway@...> commented


    (In [0dca1b06a1b7607f06d1b58a5869a3f3420e7f5b]) Prevent overlapping sounds when looking at intel information.

    fixes #60

    2.3:[11147]

    git-svn-id: https://warzone2100.svn.sourceforge.net/svnroot/warzone2100/trunk@11148 4a71c877-e1ca-e34f-864e-861f7616d084

  20. wzdev-ci commented on Jul 11, 2010

    @wzdev-ci
    ContributorAuthor

    Zarel set milestone to unspecified

  21. wzdev-ci commented on Jul 11, 2010

    @wzdev-ci
    ContributorAuthor

    Zarel commented


    I think the easier solution would be just to not play that sound at all. I mean, I don't think it's much of a benefit, and it gets kind of annoying after a while, with or without the overlap...

  22. wzdev-ci commented on Oct 9, 2010

    @wzdev-ci
    ContributorAuthor

    Git SVN Gateway <gateway@...> commented


    In [0dca1b06a1b7607f06d1b58a5869a3f3420e7f5b]:

    #CommitTicketReference repository="" revision="0dca1b06a1b7607f06d1b58a5869a3f3420e7f5b"
    Prevent overlapping sounds when looking at intel information.
    
    fixes #60
    
    2.3:[11147]
    
    git-svn-id: https://warzone2100.svn.sourceforge.net/svnroot/warzone2100/trunk@11148 4a71c877-e1ca-e34f-864e-861f7616d084
    
  23. wzdev-ci commented on Oct 14, 2010

    @wzdev-ci
    ContributorAuthor

    Git SVN Gateway <gateway@...> commented


    In [0dca1b06a1b7607f06d1b58a5869a3f3420e7f5b]:

    #CommitTicketReference repository="" revision="0dca1b06a1b7607f06d1b58a5869a3f3420e7f5b"
    Prevent overlapping sounds when looking at intel information.
    
    fixes #60
    
    2.3:[11147]
    
    git-svn-id: https://warzone2100.svn.sourceforge.net/svnroot/warzone2100/trunk@11148 4a71c877-e1ca-e34f-864e-861f7616d084
    
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

      Milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions