Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TODO: Store favorite structs in a separate JSON file #2511

Closed
past-due opened this issue Dec 19, 2021 · 2 comments · Fixed by #2935
Closed

TODO: Store favorite structs in a separate JSON file #2511

past-due opened this issue Dec 19, 2021 · 2 comments · Fixed by #2935
Labels
good first issue A good issue to tackle if you're new to contributing to this project

Comments

@past-due
Copy link
Member

Currently, they are stored in a comma-separated string list inside the config file, but this doesn't properly handle a number of edge cases.
@past-due past-due added the good first issue A good issue to tackle if you're new to contributing to this project label Dec 19, 2021
@past-due past-due mentioned this issue Dec 19, 2021
Merged
@chainlito
Copy link
Contributor

favoritestructs.json is okay for the file name?

@KJeff01
Copy link
Member

KJeff01 commented Apr 26, 2022

Yeah that will be fine.

@KJeff01 KJeff01 mentioned this issue Oct 25, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue A good issue to tackle if you're new to contributing to this project
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Move favorite structures to a JSON file KJeff01/warzone2100
3 participants
@KJeff01 @past-due @chainlito