Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

/usr/bin/.portable is installed unconditionally #2645

Closed
Piraty opened this issue Mar 22, 2022 · 2 comments · Fixed by #2808
Closed

/usr/bin/.portable is installed unconditionally #2645

Piraty opened this issue Mar 22, 2022 · 2 comments · Fixed by #2808
Labels
Milestone

Comments

@Piraty
Copy link

Piraty commented Mar 22, 2022

Describe the bug

cmake unconditionally installs /usr/bin/.portable

<...>
-- Installing: /destdir/warzone2100-4.2.7/usr/share/locale/zh_TW/LC_MESSAGES/warzone2100.mo
-- Installing: /destdir/warzone2100-4.2.7/usr/bin/warzone2100
-- Installing: /destdir/warzone2100-4.2.7/usr/bin/.portable
-- Installing: /destdir/warzone2100-4.2.7/usr/share/doc/warzone2100/copyright
<...>

Expected behavior
don't install hidden files to /usr/bin/

Your System:

Additional context

There was a funny bug side-effect encountered today on Void Linux.
Given a user has warzone2100-4.2.7 and keepassxc installed, keepassxc was tricked into portable mode by checking for .portable in it's execdir (/usr/bin/) and tried to load itsportable configuration file, then assumed at $execdir/config/keepassxc.ini (thus: /usr/bin/config/keepassxc.ini, which is nonexistent, obviously).

@past-due
Copy link
Member

Hmm. That particular file is set up as a separate PortableConfig component.

Does adding EXCLUDE_FROM_ALL to the end of that install line fix the problem for you?

@Piraty
Copy link
Author

Piraty commented Mar 22, 2022

yes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants