Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Freeze the game from large messages to chat. #2687

Closed
vaut opened this issue Apr 30, 2022 · 9 comments · Fixed by #2791
Closed

Freeze the game from large messages to chat. #2687

vaut opened this issue Apr 30, 2022 · 9 comments · Fixed by #2791
Labels
Bug good first issue A good issue to tackle if you're new to contributing to this project

Comments

@vaut
Copy link
Contributor

vaut commented Apr 30, 2022

Describe the bug
The game freezes when receiving a message that does not fit in one line.

To Reproduce

  1. enter the lobby room
  2. receiving message more than one line
    Screenshot from 2022-04-30 15-09-20
  3. watch the freeze

Your System:

  • OS: Windows 10
  • Game version: 4.2.7 portable X64. download from sourceforge
@vaut vaut added the Bug label Apr 30, 2022
@KJeff01 KJeff01 added the good first issue A good issue to tackle if you're new to contributing to this project label May 6, 2022
@chainlito
Copy link
Contributor

This issue also happens when I input a large message into the input box.
Not only receiving a large message but also inputting a large message as well.

To Reproduce

  1. Enter the skirmish game
  2. Input a large message into the chat box
  3. Then freeze

@gantsevdenis
Copy link
Contributor

@chainlito i cannot reproduce on Skirmish, 4.2.7. Even when inputting maximum-length message

@chainlito
Copy link
Contributor

Oh, I think this is happening while inputting a numbers string

@maxsupermanhd
Copy link
Member

Godash is able to consistently reproduce it but since like a year already he can not debug it.

@maxsupermanhd
Copy link
Member

Oh, I think this is happening while inputting a numbers string

Godash has freezing on literally any message in chat, maybe different issue?

@KJeff01
Copy link
Member

KJeff01 commented May 9, 2022

I can't either get a freeze though anything relevant to chat message could probably be found by searching for MAX_CONSOLE_STRING_LENGTH in the src directory.

@chainlito
Copy link
Contributor

MAX_CONSOLE_STRING_LENGTH is defined as 255, but seems like the real maximum chat length is about 72

@past-due
Copy link
Member

past-due commented May 16, 2022

This issue also happens when I input a large message into the input box. Not only receiving a large message but also inputting a large message as well.

To Reproduce

  1. Enter the skirmish game
  2. Input a large message into the chat box
  3. Then freeze

@chainlito Can you consistently reproduce this? What platform / OS are you on?

@chainlito
Copy link
Contributor

Windows 10

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug good first issue A good issue to tackle if you're new to contributing to this project
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants