Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Retain Language Identifiers for VersionInfo Resources #457

Closed
Washi1337 opened this issue Jun 22, 2023 · 1 comment
Closed

Retain Language Identifiers for VersionInfo Resources #457

Washi1337 opened this issue Jun 22, 2023 · 1 comment
Labels
enhancement pe Issues related to AsmResolver.PE win32resources Issues related to AsmResolver.PE.Win32Resources
Milestone

Comments

@Washi1337
Copy link
Owner

Washi1337 commented Jun 22, 2023

Problem Description

Win32 resources are organized by language ID at the deepest level of the internal folder structure in the data directory. Currently, VersionInfoResource::WriteToDirectory does not retain this language ID.

Proposal

Add an overload for VersionInfoResource::FromDirectory that obtains a language-specific version of the requested resource, such that their corresponding WriteToDirectory method can reuse this language ID when constructing and inserting new data entries.

Alternatives

The user could manually adjust the language IDs after calling WriteToDirectory. This is not intuitive however, as it requires looking up the newly generated and inserted resource data entries in the folder structure.

Additional Context

Related #202.

@Washi1337 Washi1337 added enhancement pe Issues related to AsmResolver.PE win32resources Issues related to AsmResolver.PE.Win32Resources labels Jun 22, 2023
@Washi1337 Washi1337 added this to the 5.4.0 milestone Jun 22, 2023
@Washi1337 Washi1337 changed the title Retain Language Identifiers for VersionInfo and Icon Resources Retain Language Identifiers for VersionInfo Resources Jul 1, 2023
@Washi1337
Copy link
Owner Author

Implemented in 72af0df

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement pe Issues related to AsmResolver.PE win32resources Issues related to AsmResolver.PE.Win32Resources
Projects
None yet
Development

No branches or pull requests

1 participant