Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow language identifiers to be customized and preserved in IconResource #533

Closed
Washi1337 opened this issue Mar 8, 2024 · 4 comments
Closed
Labels
enhancement win32resources Issues related to AsmResolver.PE.Win32Resources
Milestone

Comments

@Washi1337
Copy link
Owner

Washi1337 commented Mar 8, 2024

Problem Description

Currently, IconResource::WriteToDirectory always constructs resource directories with the language identifier 1033.

Proposal

Add Lcid properties to the classes related to icon resources, similar to how is done in VersionInfoResource (see #457).

Alternatives

None

Additional Context

No response

@Washi1337 Washi1337 added enhancement win32resources Issues related to AsmResolver.PE.Win32Resources labels Mar 8, 2024
@Washi1337 Washi1337 added this to the 6.0.0 milestone Mar 15, 2024
@caesay
Copy link

caesay commented Mar 31, 2024

I'm attempting to replace rcedit in Velopack so I can set PE resources while running on Linux, I think this should be classified as a bug rather than an enhancement. This and #532 are the current blockers.

@Washi1337
Copy link
Owner Author

Initial rework of IconResource can be found in PR #565, which should support LCID customization.

@Washi1337
Copy link
Owner Author

Washi1337 commented Jun 12, 2024

I'm attempting to replace rcedit in Velopack so I can set PE resources while running on Linux, I think this should be classified as a bug rather than an enhancement. This and #532 are the current blockers.

@caesay Sorry for the very late reply, I must have missed the notification for this. It depends on whether you simply need to copy over resources from one PE to another or actually have rich editing where you need full interpretation and reconstruction of the resource data. Copying over is already fully supported (by simply copying the directories in PEImage::Resources). This issue only refers to the latter scenario.

@caesay
Copy link

caesay commented Jun 12, 2024

No worries, I am doing rich editing (eg. setting a new icon, re-creating custom version tables) and I managed to find a workaround in the meantime. Thanks for your work on this awesome library!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement win32resources Issues related to AsmResolver.PE.Win32Resources
Projects
None yet
Development

No branches or pull requests

2 participants