Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature]: Redirect System.Object base type when member cloning #280

Merged
merged 2 commits into from
Mar 30, 2022
Merged

[Feature]: Redirect System.Object base type when member cloning #280

merged 2 commits into from
Mar 30, 2022

Conversation

ds5678
Copy link
Contributor

@ds5678 ds5678 commented Mar 25, 2022

Related: #93

@ds5678 ds5678 force-pushed the Feature/RedirectObjectBaseTypeWhenMemberCloning branch from bcea5b6 to bbfdddb Compare March 26, 2022 18:16
@Washi1337 Washi1337 added enhancement dotnet Issues related to AsmResolver.DotNet labels Mar 28, 2022
@Washi1337
Copy link
Owner

Washi1337 commented Mar 28, 2022 •
edited

I think we should add a check that the scope of the type reference is a corlib name as well (e.g. using AssemblyReference.IsCorLib or KnownCorLibs.KnownCorLibNames). It is technically possible to have a class in your own assembly called System.Object, without it actually being the System.Object that we mean here.

@ds5678
Copy link
Contributor Author

ds5678 commented Mar 28, 2022

I'll fix it 👍

@ds5678 ds5678 force-pushed the Feature/RedirectObjectBaseTypeWhenMemberCloning branch from 46ad5cc to 45e96ce Compare March 28, 2022 17:31
@ds5678
Copy link
Contributor Author

ds5678 commented Mar 28, 2022

Should be good!

@Washi1337 Washi1337 added this to the 4.10.0 milestone Mar 29, 2022
@ds5678 ds5678 changed the title Feature/Redirect System.Object base type when member cloning [Feature]: Redirect System.Object base type when member cloning Mar 29, 2022
@Washi1337
Copy link
Owner

LGTM. Thanks.

@Washi1337 Washi1337 merged commit 1b8f5f1 into Washi1337:development Mar 30, 2022
@ds5678 ds5678 deleted the Feature/RedirectObjectBaseTypeWhenMemberCloning branch March 30, 2022 13:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Washi1337 Washi1337 Washi1337 approved these changes

Assignees
No one assigned
Labels
dotnet Issues related to AsmResolver.DotNet enhancement
Projects
None yet
Milestone
4.10.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ds5678 @Washi1337