Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use IErrorListener while building managed assemblies #367

Merged
merged 5 commits into from
May 7, 2023
Merged

Use IErrorListener while building managed assemblies #367

merged 5 commits into from
May 7, 2023

Conversation

ds5678
Copy link
Contributor

@ds5678 ds5678 commented Oct 16, 2022 •
edited
Loading

No description provided.

@ds5678 ds5678 marked this pull request as draft October 16, 2022 17:39
@ds5678 ds5678 marked this pull request as ready for review October 16, 2022 18:15
@ds5678 ds5678 force-pushed the use-error-listener-while-building-assemblies branch from c92533a to 6011f7e Compare April 26, 2023 21:16
Washi1337
Washi1337 requested changes Apr 29, 2023
View reviewed changes
Copy link
Owner

@Washi1337 Washi1337 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is a good compromise until we make full breaking changes in 6.0. I have only small points of improvement, but otherwise LGTM.

src/AsmResolver.DotNet/Builder/PEImageBuildContext.cs Outdated Show resolved Hide resolved
src/AsmResolver.DotNet/Builder/PEImageBuildContext.cs Outdated Show resolved Hide resolved
src/AsmResolver.DotNet/ModuleDefinition.cs Outdated Show resolved Hide resolved
@Washi1337 Washi1337 added this to the 5.3.0 milestone Apr 29, 2023
@Washi1337 Washi1337 merged commit 7ae64f8 into Washi1337:development May 7, 2023
@Washi1337 Washi1337 added enhancement dotnet Issues related to AsmResolver.DotNet labels May 7, 2023
@ds5678 ds5678 deleted the use-error-listener-while-building-assemblies branch July 12, 2023 15:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Washi1337 Washi1337 Washi1337 requested changes

Assignees
No one assigned
Labels
dotnet Issues related to AsmResolver.DotNet enhancement
Projects
None yet
Milestone
5.3.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ds5678 @Washi1337