Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Parameter.CreateParameterDefinition helper method #418

Merged
merged 9 commits into from
Mar 2, 2023
Merged

Add Parameter.CreateParameterDefinition helper method #418

merged 9 commits into from
Mar 2, 2023

Conversation

ElektroKill
Copy link
Contributor

@ElektroKill ElektroKill commented Feb 28, 2023 •
edited

Changes:

  • Added a new method to Parameter to make the creation of ParameterDefinition objects easier
  • Don't use unbound generic types in virtual hidden this parameter.
  • Fixed a bug that resulted in incorrect parameter count calculation for signatures with ExplicitThis flag set to true.

@Washi1337 Washi1337 added bug enhancement dotnet Issues related to AsmResolver.DotNet labels Mar 1, 2023
@Washi1337 Washi1337 added this to the 5.2.0 milestone Mar 1, 2023
Washi1337
Washi1337 reviewed Mar 2, 2023
View reviewed changes
Copy link
Owner

@Washi1337 Washi1337 left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some minor comments, but otherwise LGTM.

We probably also want to add a unit test for the new helper method.

src/AsmResolver.DotNet/Collections/Parameter.cs Outdated Show resolved Hide resolved
src/AsmResolver.DotNet/Collections/ParameterCollection.cs Outdated Show resolved Hide resolved
test/AsmResolver.DotNet.Tests/Collections/ParameterCollectionTest.cs Outdated Show resolved Hide resolved
test/AsmResolver.DotNet.Tests/Collections/ParameterCollectionTest.cs Outdated Show resolved Hide resolved
Washi1337
Washi1337 approved these changes Mar 2, 2023
View reviewed changes
Copy link
Owner

@Washi1337 Washi1337 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for implementing this!

@Washi1337 Washi1337 merged commit a105ac3 into Washi1337:development Mar 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Washi1337 Washi1337 Washi1337 approved these changes

Assignees
No one assigned
Labels
bug dotnet Issues related to AsmResolver.DotNet enhancement
Projects
None yet
Milestone
5.2.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ElektroKill @Washi1337