Fix marshalling enums in CliMarshaller #133
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Washi1337
requested changes
Jul 19, 2023
src/Platforms/Echo.Platforms.AsmResolver/Emulation/CliMarshaller.cs
Outdated
Show resolved
Hide resolved
Washi1337
approved these changes
Jul 19, 2023
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #132
ElementType.Enumis only seen in custom attributes, which I don't think would ever be pushed to stack, so I removed that case and replaced it withElementType.ValueTypeinCliMarshaller.GetElementType()If you think I should add it back, just let me know :D
Also, enums can only have an underlying type of built-in integer types, so I removed the recursive call.