[Plugin] zlib [LFX 2023 Term 2] #2562
Conversation
Signed-off-by: Saikat Dey <saikatdey2100@gmail.com>
|
Hello, I am a code review bot on flows.network. Here are my reviews of code commits in this PR. The pull request "[Plugin] zlib [LFX 2023 Term 2]" mainly focuses on adding zlib plugin and its functionalities - a data compression library to the WasmEdge project. Various patches are included taking care of multiple aspects like adding the plugin to CMake build, configuring GitHub Actions workflows, adding environment for the zlib plugin, implementation of different zlib functions and adding zlib module implementation, however, several potential issues need to be addressed:
The introduction of a new library dependency, zlib-ng, could have a project-wide impact, raising further potential issues:
In conclusion, the patches bring significant additions and improvements to the project but also introduce potential risks and problems that should be addressed to ensure robustness and reliability of the solution. Regardless of apparent syntax correctness, it's crucial to add unit tests, handle exceptions meticulously, and manage memory and resources effectively to guarantee reliable and efficient operation in a multi-threaded environment. Furthermore, comprehensive documentation and meaningful descriptions would help understand the changes better and maintain code quality over iterations. DetailsCommit fcc2423258cf20e9b8d0472ee6907be69fc5ee59This update is to the If the flag Given that this is a short patch, there are no overt problems. However, there are implicit assumptions that we can discuss:
Lastly, this is patch 1/98, it is possible that following patches may depend on this one. If they are applied pre-emptively, it might create issues. Commit 2d866db038b8dd958bf723e421443ac868b19625Summary of Changes: Potential Problems:
It's crucial to test the software thoroughly after adding a new plugin, ensuring that it works as intended and doesn't interfere with the functioning of other components. Commit b4d0cc4630cc77d0247fe4a932e716126fde654bThe patch is introducing a new dependency to the project - zlib-ng, a modern, optimized version of zlib. This is a major change, depending on the size of the project. The changes are made in the CMakeLists.txt file of the plugin wasmedge_zlib, meaning it's specifically for building the zipped up version of wasmedge (which seems to be a software development kit). Key changes:
Potential issues:
Finally, if this is a large project, introducing a new dependency like this could have a significant impact, so it should be suitably reviewed and discussed by the team. Commit da6a3023eaeebcf7a4e21d52b6c2eb7c756a9149The pull request titled "[Plugin] zlib [LFX 2023 Term 2]" primarily focuses on adding a new build target for the zlib plugin for the 'build_ubuntu' job in the GitHub Actions workflow, as mentioned in 'build-extensions.yml'. Key Changes:
Potential Problems:
Commit cc0dd7cbe8c1ec08c05f259254522b66d501b53cSummary of Main Changes: The patch adds two build jobs into the YAML CI script with system platforms, manylinux2014_x86_64 (64-bit x86 architecture) and manylinux2014_aarch64 (64-bit ARM architecture). This inclusion is meant to create a build for the zlib plugin of WasmEdge on those platforms, creating a shared library output named 'libwasmedgePluginWasmEdgeZlib.so'. The cmake option '-DWASMEDGE_PLUGIN_ZLIB=ON' seems to indicate that the zlib plugin will be included at compile-time. Potential Problems:
Overall, these additions should be validated to confirm that they don't negatively impact the project's build processes. Commit 618c2e84549d2444568f7beac0101b67e79da568The invitee, Saikat Dey, has introduced an initial environment for a new zlib library plugin for the WasmEdge environment, as shown by 3 new files with 100 lines of insertions. The zlib library is usually used for data compression. In the The The There are, however, a few potential problems that may arise:
Commit c167c297a01082cb978b610b39687a4de8dbb6c1This patch introduces a new header file (zlibfunc.h) in the wasmedge_zlib directory of the project. The primary change is the creation of several classes, each of which represents a different function provided by the zlib library, a software library used for data compression. The classes are:
All the classes are inheriting from a generic template class Main findings:
Potential issues to consider:
In conclusion, while there seem to be no immediate issues with the patch, a review of the full implementation and corresponding tests is necessary for a complete understanding. Commit 9b9e14de7ddccec003de1fc96937b01527fae9ceThe change presented in this patch involves the addition of a new file named Here are the key changes:
Potential issues:
Commit fcaa19904597c16d793e680329194b8211b5ba99This pull request, by Saikat Dey, is focused on adding a new zlib module implementation to the plugin 'wasmedge_zlib'. A new file named 'zlibmodule.cpp' is created and 27 lines of code are added in it. Here are the key changes:
Each of these functions are initialized with a 'WasmEdge XYZ' function where XYZ corresponds to the respective function name. Given the information in the provided patch commit, there doesn't appear to be any critical issues in terms of syntax or missing mandatory parts. However, there are a couple of points that need to be considered for revealing potential problems:
Commit bf6adcdb00a2859bcedddcfa1c82e6a4ae961bfbThe developer, Saikat Dey, has added a file containing an implementation for a plugin, named WasmEdgeZlibDeflateInit_, in the WasmEdge project. The implementation is in a file, zlibfunc.cpp, inside the directory plugins/wasmedge_zlib. Key Changes:
Potential Problems:
Commit 9615d7b6a44ea11cea9986e913fc5a77b3fb3350The pull request involves adding a new implementation for the plugin "zlib". This implementation pertains to the zlib inflation initialization. Below are the key changes:
Potential problems:
Commit 73e1dcb76f079805fe9e5c38170d94cdbadccb0eSummary of Changes: The developer Saikat Dey has made changes in the file plugins/wasmedge_zlib/zlibfunc.cpp. A new method called In the added function, the logic includes looking up a Potential issues:
Commit 0e61ff487c0cd25a3ea59dde3fdb40d0843803e9The key changes in this pull request are the implementation of a zlib inflate functionality within the existing Summary of changes:
Potential problems:
Commit 9f692f00b9b7ef50acf6b7562dd6629745048210The pull request titled "[Plugin] zlib [LFX 2023 Term 2]" contains changes primarily in the file Summary of Key Changes:
Potential Problems:
Commit face6ab6df477905441777c8c375542b0465b793This patch represents the implementation of the Key Changes:
Potential Issues:
Commit a0cc2d24acd2f2c27ba6f939fd6c9d2748edbdc9This patch populates the 'CMakeLists.txt' file to help build and link the zlib plugin source. Key Changes:
Potential Problems:
Commit a98bca1ff6fcc073fc675c1d10ee272435fbcb86The change made to the codebase in this pull request are:
Though the commit message and code changes are clear, the following potential problem could occur:
Apart from this potential issue, everything else about this pull request seems to be in order. The developer has followed good practice by signing off the commit. Commit 2b8668580ec73cdc0a3b737107385735c13b389dThe author of this patch, Saikat Dey, has added a basic test case for the zlib plugin in the WasmEdge project. This is represented by the new file 'wasmedge_zlib.cpp' in the 'test/plugins/wasmedge_zlib' directory. Key Changes:
Potential Problems:
Commit bc857cce1c8e1299470bc85537d9ffb8d95cea0fThe commit titled "Added test/plugins/wasmedge_zlib/CMakeLists.txt to build and create zlib test executable." adds a new file, CMakeLists.txt, to the wasmedge_zlib plugin test directory. Key Changes:
Potential Problems:
Commit 7b0ed641b3777d704520bfec70e9ebaee42543caSummary of changes: This patch modifies the Potential problems:
Commit d6d969f87da1603f7926d9764e85c42d3557d5c9Summary of Changes:
Potential Issues:
Commit 2027eacfb574416c9b0ec9f8c0c969a4b72e964fChanges: The developer has made corrections to the case of the library identifier 'ZLIB' in a CMakeLists.txt file. It seems like the ZLIB library reference was case-sensitive, and the file has been updated to reflect this, changing it from 'ZLIB' to 'zlib'. This correction has been made in 4 different places in the same file:
Potential problems:
The reviewer should check for these potential issues. Commit 28cc2cf6f9c8ba90a5d53ed6b429a1afb75973e2The Pull Request is primarily changing the build pipeline for a number of plugins in build-extensions.yml. It appears to be attempting to streamline and generalize the build process across multiple plugins. Major Changes:
Potential Problems:
Commit 0d8c9b1873c1da8f5269f02e8be25cfa69ec1bc8The key changes in this Pull Request are about correcting cmake build options in the build-extensions.yml file. Specifically, the "-DWASMEDGE_PLUGIN_WASI_ZLIB=ON" option was incorrectly named and has been corrected to "-DWASMEDGE_PLUGIN_ZLIB=ON". This change is made in two places in the build-extensions.yml file. As these are string changes for build options, there seems to be no direct potential for causing problems. However, potential issues may arise if the updated flag "-DWASMEDGE_PLUGIN_ZLIB=ON" is not setup correctly in the cmake environment or if this flag has dependencies on other parts of the code. Since the same change is applied to two different parts of the file, this might imply that the same environment is being setup twice. This suggests a possible area of improvement in the code, which might be to avoid this duplicated setup. It would help if the author tested the build with the new flag, to ensure there's no further dependencies issue during build time. Also, providing a brief explanation for the change in the commit message might add clarity for future reference. Commit d5d4f36480e2f3f65f0fc3115eca91cb4066f677The provided patch concerns the CPP files for a plugin named "wasmedge_zlib". The key changes are mainly type changes made to better reflect the Zlib API. These are minor changes that involve altering the data types of the parameters for certain methods.
Due to the API type naming conventions, the change might be necessary for consistency purposes. Potential problems:
Commit a9e1bc206b6aa6f8ae23cb5e6d0136402f8f1e33The patch adds a new unit test for the zlib plugin in the Wasmedge runtime - a test for deflate and inflate operations, named
Potential problems:
Commit ba8bff1813d9d9d8aab23ddb1f34627a2bcfd94aThe key changes made in the pull request are related to the The main implication of these changes is that the Review on Potential Problems:
Commit c081bf7acba97f54db57e1471dd13e6a39a8a9f8This is a very specific patch that only modifies the
The purpose of this change appears to be ensuring that the size of the Potential problems:
Commit 8a0ab936de0d08ff13a27329ff220de9a04763fdThis patch from Saikat Dey is applied to the file 'wasmedge_zlib.cpp' and appears to change how memory is allocated in the WASM (WebAssembly) heap. The key change in this patch is that the initial address from which writing to the WASM heap begins has been shifted from address 0 to address 1. This is done to avoid a clash with the semantic meaning of address/offset 0 as a null pointer (nullptr), which is a potential source of bugs and undefined behavior. While the change itself seems straightforward, there are a few potential implications and issues:
Overall, without more context or information, while safe-per-se this change could potentially lead to unforeseen side effects. Especially when considering that memory management in WebAssembly is a critical aspect of ensuring the safe and efficient performance of WASM applications. Further testing and validation would be recommended to ensure that this does not introduce any bugs or undesired side-effects. Commit 20cf963e9d9ed67cfff06e180f920bb0f38e39e1The proposed patch primarily improves and refactors the zlib plugin for Wasmedge. The critical changes introduced are:
From a reviewer's perspective, these changes seem to significantly reduce code redundancy and improve modularity, which are highly desirable qualities. However, there are still a few potential issues that should be addressed:
To address the potential issues, maintain error logs for visibility into code execution paths. Consider adding more granular tests to validate the new changes, and think about refactoring hard-coded values in the code for ease of future updates. Commit 43def5948309900e09cc219df1bb0091b000d35dThe commit involves the changes to the The key changes in the pull request are:
Potential Problems:
Commit cce004ac0a792a9ead6dfc4708885912dc6adb5fThe key changes in this patch revolve around improving the safety of pointer usage in the areas of memory handling for Deflate and Inflate operations in the WasmEdgeZlib plugin. In detail:
Potential Problems:
Commit c74505d1cc0785cb78c6eba3afc346c05be913d3This pull request introduces in-code documentation to every field in the Wasm_z_stream struct in the file plugins/wasmedge_zlib/zlibenv.h. It seems that 18 lines were added which include comments explaining each field while two lines were deleted which likely were comments. Here is an overview of what these fields do based on the added comments:
Potential problems could be:
The most significant finding is the improved documentation which could assist in comprehensibility & maintainability of the code for the team or other contributors. However, it is necessary for the comments to be accurate and consistent with the rest of project's coding practices. Commit 89004feaa93b434d164561a5dc6c563f78162833The pull request modifies three files: plugins/wasmedge_zlib/zlibenv.h, plugins/wasmedge_zlib/zlibfunc.cpp, and test/plugins/wasmedge_zlib/wasmedge_zlib.cpp. Key Changes:
Potential Problems:
Overall, there seems to be very little potential for errors, assuming all references have been updated correctly. The renaming operation could have been automated using a refactoring tool, which would reduce the risk of missing any occurrences. The only area to pay attention to would be ensuring that all references in the codebase are updated accordingly. Commit 705dea5cf2787c0eb96753501436a273b425a810In the pull request, the author made changes to update a struct name for the compliance with LLVM's naming convention. The struct was previously named 'Wasm_z_stream' which was changed to 'WasmZStream'. This change has been done in the zlibfunc.cpp file inside the wasmedge_zlib plugin. Key Changes:
Potential Problems:
It is recommended to cross-verify in the entire project for the usage of this struct and update it accordingly to prevent inconsistency and future errors. Update all associated documentation or communication to keep every contributor on the same page. Commit c7b4de2296111970e0b9a0c08a31f30cdfcf398cThe pull request involves a change in a single line of code in one file ( The main modification is that a C-style cast ( Key change:
Potential issues:
Commit 7465495da118be34e2cc25d5830838ff1a3852c8Summary of Changes: The developer has made changes to the code in wasmedge_zlib.cpp. They modified some variable names to make them follow LLVM (Low Level Virtual Machine) standards. This is a part of the test case for the WasmEdge Zlib Plugin. Below are the changes:
The call to Potential issues:
Apart from the potential issues mentioned above, these changes are simple refactorings that improve code consistency and are unlikely to introduce new bugs themselves. Commit 4805d6daba4c3530a1f168649d0d443ef050e7b4This patch does not introduce any functionality changes but rather modifies the naming convention of some variables to align with LLVM standards. The key change here is that the Concerning this change, the following functions were affected:
Each function has a line where the Potential problems might arise if this naming scheme deviates from other parts of the application, but in general the change seems to follow LLVM's guidelines for variable naming and should be fine. It's also important to ensure that these changes are reflected in any parts of the codebase, such as documentation or tests, that may reference these variable names. Commit 731d55a5c084e8381b680487f2daa57f26d808ddThis pull request titled "[Plugin] zlib [LFX 2023 Term 2]" by Saikat Dey includes changes for improved synchronization and wrapping of zlib calls in the wasmedge_zlib plugin:
Key potential issues:
Commit 31517720ef0fb52338bd1f287b4693f78b82a3deThe developer has made changes to comments in the file Key changes include:
Potential problems:
Please note that review comments are based purely on the comments and isolated view of this patch. To fully assess the impact or potential problems, it might be useful to understand the whole context in its totality i.e., the purpose of ignored properties and whether the removal of the last comment was just a cleanup or it indicates an actual change of plan. Commit dbb9f7aac80179a320b96ebeaabfd1c3f0308557The following key changes have been made in the 'zlibfunc.cpp' file:
Potential issues identified:
Minor Note: The patch looks simple and small, and hence does not introduce a major change. The author's future contribution in the PR might further alter this functionality, make sure to consider this context while reviewing. Commit a23011d2748b85503a7845149b532f1cc1db1cf2Summary of Key Changes:
Potential Problems:
Suggested Course of Action: Commit 0bafab8428d763bdc81da762add6fbac4eb5a3e8The key changes in this Pull Request focus on adding new functionality to the zlib plugin within the WasmEdge project. The developer has introduced two new methods, Summarizing the changes in this patch, In
In
Potential Problems:
Commit e5c147e2969e6c5e35ee960cfe9a69f72406dab8The key changes in this patch are:
Potential problems:
Commit 076cd31dd377024b8da05ceebcb6063bb67efbe7Summary of Key Changes:
Potential Problems:
Commit 6242f27efe63f14a5072615cb88da5e3766b5310Summary of changes:
Potential Problems:
Commit 57df5c780ee956fb32e69b49984601d46f469d88This pull request by Saikat Dey contains two significant additions to the
From the initial review of the changes, here are some potential issues:
Commit 84a3e9cb571ce203ee31d3712500d3261d521c1bThe developer, Saikat Dey, is adding functionality to the WasmEdge Zlib plugin. Changes:
Potential issues:
In light of these issues, I would recommend adding null pointer check. Also, it would be beneficial to add error handling after calling the 'deflatePending' and 'deflatePrime' methods. Lastly, adding documentation or comments explaining the usage of these new features is recommended for better maintainability. Commit 0a9329c0faf65b2f8188d66de848f01416b3fd5dThe key changes in this pull request titled "[Plugin] zlib [LFX 2023 Term 2]" are focused on the file named "zlibenv.h" within the "wasmedge_zlib" plugin. Changes include:
The WasmGZHeader structure includes fields such as:
Potential issues:
Commit ff5154dfcb68efc9c78526207795fd58f65189b4The changes in this pull request are focused on the In the 'zlibfunc.cpp' file, a total of nine functions were added. These functions include 'WasmEdgeZlibInflateSetDictionary', 'WasmEdgeZlibInflateGetDictionary', 'WasmEdgeZlibInflateSync', 'WasmEdgeZlibInflateCopy', 'WasmEdgeZlibInflateReset', 'WasmEdgeZlibInflateReset2', 'WasmEdgeZlibInflatePrime', 'WasmEdgeZlibInflateMark', and 'WasmEdgeZlibInflateBackEnd'. Each function follows a similar pattern to find a specific pointer in the 'Env.ZStreamMap', perform a specific operation using that pointer and then return a result. However, specific operations performed by each function vary. In the 'zlibfunc.h' file, the same nine functions have been declared, each in their own class which inherits from the 'WasmEdgeZlib' base class. Potential problems:
Commit 10125fd541230e547ee361e2308603e83282f23cThis commit adds non-gz functions to a Zlib plugin for the WasmEdge runtime. Major changes include:
The potential problems and observations are:
Backward compatibility doesn't seem to be affected as this Pull Request only adds more functionalities and does not modify existing ones. Though it'll be crucial to ensure the new functionalities perform as expected. Commit 9102cbb0db678867f88a089f4c996ac8be3fd821The primary changes in the patch revolve around the addition of four new functionalities, namely
Potential Issues:
Overall the changes seem sound in terms of extending the functionality of the plugin, but they could be improved by addressing these potential issues. Commit 28bf85d99fdc87c69b6d9192ce105e6dd5720246The key change in this patch is the renaming of version variables in two jobs within a GitHub Action workflow. Specifically, the "_v2" postfix has been removed from "get_version_v2" in two instances. This change affects the naming of the uploads in the "Upload artifact - wasmedge_zlib" steps of the build-extensions.yml GitHub Action file. The important consideration associated with this change is ensuring that "needs.get_version.outputs.version" is a valid, existing reference. If the get_version action output does not exist or has not been properly initialized in the workflow, it could lead to failures in the job where the variable is used. This would result in failed attempts to name and upload the artifact correctly, potentially causing the entire workflow to fail. Another issue could be if other parts of the codebase rely on the old "_v2" postfix. If such references are not updated, this renaming could lead to further errors. It would be recommended to test this change thoroughly, as well as verify that no other jobs depend on the changed output variable name. Additionally, ensure that the versioning scheme conforms to semantic versioning standards to avoid any confusion. Commit 1e31c2d57a7110e85ab85a784c3f4698c9488826This patch from developer Saikat Dey concerns the file 'zlibfunc.cpp' in the 'wasmedge_zlib' plugin. Key changes:
Potential issues:
Commit c607f08608ae34aa0bea1c967883555ec315b415Key Changes:
Potential Problems:
Please inspect the entire codebase for the usage of these functions to confirm that no other areas are affected by this change. If tests were written for these functions, they should be updated as well to reflect the changes. Another thing is the change is quite specific with no general application or framework modification, the purpose of the change should be clearly released in the version's log and documentation to prevent unnecessary confusion. Commit bea8b35d152fcbd8af573f3a8a9f597ec6b5c574The code changes made in this patch involve the handling of In the initial code, Key issues to verify would include:
No major issues seem to be introduced by this pull request. However, extensive testing is recommended due to changes in memory handling. Commit 7ee7a324269d8cee42601c5c5e11432678c29487The pull request's title suggests adding Key Changes:
Potential problems:
The above issues should be handled before merging this pull request. Commit b54d1269ff185632a99d8c467f49a3b614899b45Summary:
Potential Problems:
Commit 5025c3d961fea830bfadfb337f014ccffe213ed5This pull request introduces three new features to the zlib plugin for the WasmEdge runtime: Here are the key changes:
It's worth noting that in each function, it searches for the However, there are some potential problems and requirements for additional information:
Ultimately, while the committed changes help enhance the functionality of the plugin, some considerations should be made towards enhancing error handling, test coverage, and input validation to ensure the robustness of the new features. Commit 08725d480c8443d42c9bb371fbcb33c50b8d24c8The key changes in this pull request are as follows:
Potential problems:
Commit 9da46e01fe3f8be30b536499de407a473e43ef7aSummary of Key Changes:
Possible Potential Problems:
Overall, the changes seem logically sound and properly implemented, but they could benefit from additional checks for error handling, thread safety, and potential memory leaks. Reducing code duplication can also improve maintainability. Commit 44689d86bf46e429ad6d22683c3ea5fa582598bfThe pull request titled "[Plugin] zlib [LFX 2023 Term 2]" from Saikat Dey has made changes in the Key Changes:
Potential Issues:
Commit ae9f871b429bf8004f1a8b71df785bf0827d8d4bThe pull request is an enhancement to the WasmEdge Zlib plugin. The developer, Saikat Dey, has added new functionalities by extending classes for multiple zlib functions. Changes:
Findings:
Recommendations:
Commit 429bda7dead85360841f03dbf8598bce4f3bc780Summary of Key Changes: Potential Problems:
Commit 5e3f68649b97f4f67d16d4871a2eade552c86217Summary of Changes: Potential Problems:
Leaving out these potential issues, the code change itself seems fine as long as 'unsigned char*' is the desired type to be used broadly across the application where these functions are being called. It's important to remember that checking the wider usage and compatibility of this change remains crucial for a successful incorporation into the codebase. Commit c18a1040a8636cec084c7b7b8af30175332eee2bThe changes in this pull request include adding new features and functionality. They involve additions and minor subtractions of the code, increasing the functionality of the Zlib plugin for WasmEdge. The key changes can be summarized as follows: File: zlibfunc.cpp Three new methods were added to the file:
File: zlibfunc.h The class WasmEdgeZlibGZGets was commented out, means it's methods and variables cannot be accessed in the plugin. Potential problems:
Commit ab3d3e0432035c37840ae1dfd9b18f8b09c633b8Key changes: Potential problems:
Commit 643e32d8860f1e96be04465f0415a1d551c5f222Key Changes: Potential problems:
For a thorough review, inspecting the full file and understanding the overall working of the plugin would be necessary. Commit 21a6c6a922dce874134868c1be0c3f610ed2c1e0From the above patch, there are a few notable changes in the file
Potential Problems:
Commit c83cb6ee29079f598d95c323c2791b27e51143f6This pull-request modifies two files Key Changes:
Potential Problems:
Commit 87b26fa532228440302a5bb35655a907c013ca32The patch introduces several new features and refactors a few existing ones in a zlib plugin. New Features:
Refactoring:
Potential problems:
Commit 13cff39912b6a2a15757dab0e1120cedf5d0e929The developer, Saikat Dey, has made several changes in the zlib plugin of a WasmEdge project. These changes span across two files, namely
Potential issues include:
Commit e72b1a22bdb353a671bf8dc3901253f14ebd418aThe pull request is made for adding a new method named
Potential Issues:
Commit f295530caffde8ceb7a70b774a87f35afce191c3This Pull Request is a code modification for a plugin named 'wasmedge_zlib', likely a zlib library for the WebAssembly Edge runtime. It has significant changes:
Regarding potential problems:
Overall, the PR adds substantial functionalities related to inflate and deflate operations but lacks testing, error handling details, and documentation, which ideally should be included. Commit d9e30b99376779fc7c80673ce1d26a1ec06ca17bThe contributor, Saikat Dey, created a patch to add a new class named Key changes:
Possible issues:
Commit 50a1032285550d3a515d4e5957a83f5b760720c3The key changes made in this pull request, specifically in the
The patch involves deleting seven lines and adding seven new ones to replace them in the Potential Problems:
It is generally good practice to remove any unused variables or objects as they take up memory space, can decrease code readability, and increase complexity unnecessarily. Nevertheless, it's important to confirm no specific reason to keep it in the first place. It is highly suggested to have unittests around the modified function to ensure its behavior remains the same. Also, the deletion won't affect any other dependent functionality. Commit 1d44df29f409a3edac08fd2a8d111be64d992a93Summary: The provided changes can be divided into 3 main sections:
Potential Problems:
Recommendation for moving forward: The changes should be thoroughly reviewed to ensure consistency across all updated files. Developers working on this codebase should be notified about these changes to ensure a smooth transition. If possible, separating such large-scale renaming into a different commit or PR would improve code review efficiency in the future. Commit b7c6368b2da387de95a0f748a2861702a15fcc51The patch addresses three major areas:
It appears that the contributor is adding more support for the Zlib functions in the plugin. This includes all essential functionality needed for working with Zlib including initialization, decompression, and compression of data, managing GZ (Gzip) files, managing zlib stream, resetting zlib state, handling buffer, managing dictionary, tuning deflate’s internal compression parameters and more.
The contributor has reformatted some commented out sections for better readability, notably within the zlib module. The refactoring also includes renaming a few functions for consistency.
The contributor incorporated error handling code within the plugin, when a value is not found in the map. However, certain potential issues to address:
Recommendations for future pull requests:
Commit 692e6ad387444cdd4082dd6f0f906551b95dd848This patch pertains to the code for the WasmEdge Zlib Plugin, which lives within a C++ test file ( Key Changes:
The patch creator, Saikat Dey, seems to be expanding the plugin's capacity by adding support for more Zlib functions, which is portrayed by the numerous added EXPECT_NE lines that check for these function exports. Potential Issues:
Commit 71c819220fd4f462bf3e2a23d520d162df1692d6The pull request introduces changes to integrate a new plugin, zlib, in the WasmEdge project. Key modifications include:
There are a few potential issues to consider:
To adequately address these issues, ensure dependencies are investigated and appropriately managed, error handling is robust and consistent with existing standards, and thorough testing is conducted to maintain system integrity. Commit df4314f5e13fe676fb727bb8f0d01a591d7fec04This patch primarily focuses on the addition of two functions, namely In In In Potential pitfalls and areas to review further:
Commit 03a15ead8ba176211e504f73f7ec1b3fd943ed78In this patch, there are several changes made, but they concern one major modification, reflected in many different places in the code of zlibfunc.cpp file. The return type of the SyncRun function has been changed from In terms of potential problems, there are no obvious syntax or logic errors in the committed changes. However, whether or not this change is suitable depends on a few things:
Therefore, thorough testing, code review, and performance evaluation are recommended before this patch can be safely merged. Commit a49a4ab5f894cc180e80114bf4864f31aedf5e18This patch is for the Key changes:
Potential Problems:
Commit 20011d07bbed96b9f9f3aca66695ef86a7485c35The key changes include:
Potential Problems:
Commit 1d0d852c224b71c772c62974d0aab80ac52b9976This commit, labelled "Added GZHeader Sync steps in SyncRun", introduces a substantial amount of changes in the 'plugins/wasmedge_zlib/zlibfunc.cpp' file entirely contained in the 'SyncRun' function. Key Changes:
Potential Problems:
Commit f37a0654feea7d4e79e5bea07a9cedccbf13dfcbThe patch adds two new methods to the "WasmEdgeZlibModule" class named "deflateSetHeader" and "inflateGetHeader". The method "deflateSetHeader" is added to the deflate set of methods which are likely dealing with compression, while "inflateGetHeader" is added to the inflate set of methods that are assumed to be about decompression.
Final Note: It would be important to ensure there are corresponding test cases and functional implementations to these method definitions. Commit 867cb647fbd9f3d17af80c51e50cd70f12dfdf69Summary: Potential Problems:
It would be wise to ensure that the overall test process covers common potential pitfalls and that these particular functions are properly implemented. It would also be helpful if the patch included some comments about the intent of the change. Commit 4e431c83cfe1f562d20f696ebd0ad2ef0fa1c806Summary of Changes: Potential Issues: Important to note the test author should ensure that the new functions are idle, and do not break existing functionality. It would be beneficial if the PR author could provide a list of the 76 functions that should be present after the changes, which would enable easier debugging if needed. Additionally, the context of how these extra functions were added or why they are necessary to the Zlib module is not given here. Commit e03337dcfe750d6bd2bd0cb043f76ceec59691a7The patch modifies Here are the summarised changes:
Potential issues:
Commit bda8761bf62ab4f5c543188b90d906a9f9061f87SummaryThese changes consist of code clean-up, removal of unused comments, and change of usage for named fields in the zlib plugin for wasmedge. The code changes mostly have to do with how elements are added to the There are also many old class declarations being removed/commented out from the file Findings
Possible Issues
Commit 2079bfee4ffef35752177c86d025240c92a04088This pull request primarily introduces additional error logging into the Zlib Plugin, particularly on error return segments in various functions. Here are the primary changes made:
The code changes seem generally good as they improve traceability and debugging, however, there are a couple of aspects that need reviewing:
Finally, it is always a good idea to add tests when code is changed (or ensure that existing tests cover these changes), but this patch does not include any tests. If tests have not been added elsewhere, you should recommend adding unit tests to ensure the errors are logged correctly. Commit 4e546be8726b5750933c775c7d00e5694d2fe2edThe key changes in this patch revolve around improving the debug experience during error cases in the WasmEdge-Zlib plugin. The primary change involves including function instance names in the log error messages, thereby providing clear context when errors occur. Additions to the code include:
Although this patch is comprehensive and improves the code quality, certain issues may arise:
Commit 1ef077e2111bf5fc7860d9b3ac227a88046e47e4The Pull Request titled "[Plugin] zlib [LFX 2023 Term 2]" includes changes made to the 'zlibfunc.cpp' file within the 'plugins/wasmedge_zlib' directory. The author of the PR is 'Saikat Dey' and the commit message states that a space was added between the error message tag and the message. The changes throughout the file are consistent with the commit message. The author introduced a whitespace in the argument tag of the 'spdlog::error' function which logs the error messages. Key Changes:
Potential Problems:
Commit 84a54ee1506193fad4d437a815f7800d5606e2afThe commit titled "[PATCH 94/98] Added info to error msg if the error is caught inside SyncRun." makes changes to the zlibfunc.cpp file in plugins/wasmedge_zlib. Key Changes:
Potential Problems: Commit 4884578b975723f22b19f528415dc0b730b8398eThe pull request titled [Plugin] zlib [LFX 2023 Term 2] by Saikat Dey removes the usage of a temporary ZRes variable where it is deemed unnecessary in the zlibfunc.cpp file. This change affects around 290 lines of code, leading to a net reduction of 94 lines (98 insertions and 192 deletions). The key change in these modifications is that the functions no longer store the result of Potential problems with this include:
Overall, these changes seem to generally follow good coding practices and shouldn't introduce any bugs if all the affected functions are working correctly. However, thorough testing would be recommended before merging this pull request. Commit 1d0ac2336eb2489473e93b9bba8cc0a29a64657fSummary of Changes: The changes in this patch primarily revolve around how gzFile_s, which is an opaque structure in the zlib plugin, interacts with the calling module (WasmEdge). Rather than passing the raw gzFile_s pointer to the module (which it shouldn't try to access directly), this patch introduces a placeholder number that functions as a pointer. Here are the key changes:
Potential Issues:
A full review would likely entail checking the usage of Commit 49018cb086054158f99e7b30fe4f13b402757cd3Summary of changes: The author of the patch made a minor style change. He made updates to two files:
Potential problems: The changes appear straightforward and I don't see any immediate potential issues as this is a simple renaming operation. However, a couple of things should be checked:
Recommendation: Before this pull request is merged, I would suggest doing a global search across the codebase to make sure Commit 8846a16981a272cf119c3e4167caba0a29ea0730This commit titled "[PATCH 98/98] Removed usage of decltype, due to gcc [error: type qualifiers ignored on cast result type]" introduces changes to the file Key Changes:
Potential Problems:
|
Signed-off-by: Saikat Dey <saikatdey2100@gmail.com>
Codecov Report
@@ Coverage Diff @@
## master #2562 +/- ##
==========================================
- Coverage 80.97% 80.96% -0.01%
==========================================
Files 150 150
Lines 21618 21618
Branches 4350 4350
==========================================
- Hits 17505 17504 -1
- Misses 2947 2949 +2
+ Partials 1166 1165 -1 see 3 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Signed-off-by: Saikat Dey <saikatdey2100@gmail.com>
Signed-off-by: Saikat Dey <saikatdey2100@gmail.com>
….yml . Signed-off-by: Saikat Dey <saikatdey2100@gmail.com>
Signed-off-by: Saikat Dey <saikatdey2100@gmail.com>
Signed-off-by: Saikat Dey <saikatdey2100@gmail.com>
Signed-off-by: Saikat Dey <saikatdey2100@gmail.com>
Signed-off-by: Saikat Dey <saikatdey2100@gmail.com>
Signed-off-by: Saikat Dey <saikatdey2100@gmail.com>
Signed-off-by: Saikat Dey <saikatdey2100@gmail.com>
Signed-off-by: Saikat Dey <saikatdey2100@gmail.com>
Signed-off-by: Saikat Dey <saikatdey2100@gmail.com>
Signed-off-by: Saikat Dey <saikatdey2100@gmail.com>
Signed-off-by: Saikat Dey <saikatdey2100@gmail.com>
…ib plugin source. Signed-off-by: Saikat Dey <saikatdey2100@gmail.com>
Signed-off-by: Saikat Dey <saikatdey2100@gmail.com>
Signed-off-by: Saikat Dey <saikatdey2100@gmail.com>
…lib test executable. Signed-off-by: Saikat Dey <saikatdey2100@gmail.com>
Signed-off-by: Saikat Dey <saikatdey2100@gmail.com>
Signed-off-by: Saikat Dey <saikatdey2100@gmail.com>
Signed-off-by: Saikat Dey <saikatdey2100@gmail.com>
Signed-off-by: Saikat Dey <saikatdey2100@gmail.com>
Signed-off-by: Saikat Dey <saikatdey2100@gmail.com>
Signed-off-by: Saikat Dey <57017288+notfathomless@users.noreply.github.com>
Signed-off-by: Saikat Dey <saikatdey2100@gmail.com>
Signed-off-by: Saikat Dey <saikatdey2100@gmail.com>
Signed-off-by: Saikat Dey <saikatdey2100@gmail.com>
Signed-off-by: Saikat Dey <saikatdey2100@gmail.com>
Signed-off-by: Saikat Dey <saikatdey2100@gmail.com>
Signed-off-by: Saikat Dey <saikatdey2100@gmail.com>
|
@hydai This PR is ready from my side. If there is anything more that I should take care of, let me know. If everything checks out well, we can start with the merging process. |
Signed-off-by: Saikat Dey <saikatdey2100@gmail.com>
…nvention fixes. Signed-off-by: Saikat Dey <saikatdey2100@gmail.com>
Signed-off-by: Saikat Dey <saikatdey2100@gmail.com>
…bug experience. Signed-off-by: Saikat Dey <saikatdey2100@gmail.com>
Signed-off-by: Saikat Dey <saikatdey2100@gmail.com>
Signed-off-by: Saikat Dey <saikatdey2100@gmail.com>
|
@hydai I have resolved all the changes requested. |
…cessary. Signed-off-by: Saikat Dey <saikatdey2100@gmail.com>
…ointer to Host gzFile_s. We don't need to pass the raw pointer to Module, since gzFile_s is an opaque structure & the zlib app shouldn't try to access any of it's fields. Signed-off-by: Saikat Dey <saikatdey2100@gmail.com>
Signed-off-by: Saikat Dey <saikatdey2100@gmail.com>
… on cast result type]. Using remove_cv to supress, would create code bloat. Signed-off-by: Saikat Dey <saikatdey2100@gmail.com>
* Include wasmedge_zlib in plugins/CMakeLists.txt .
Signed-off-by: Saikat Dey <saikatdey2100@gmail.com>
* Add Zlib Plugin as an option in root CMakeLists.txt .
Signed-off-by: Saikat Dey <saikatdey2100@gmail.com>
* Add zlib-ng dependency through FetchContent.
Signed-off-by: Saikat Dey <saikatdey2100@gmail.com>
* Added zlib build target for job 'build_ubuntu' in build-extensions.yml .
Signed-off-by: Saikat Dey <saikatdey2100@gmail.com>
* Added zlib build target for job 'build_manylinux' in build-extensions.yml .
Signed-off-by: Saikat Dey <saikatdey2100@gmail.com>
* Init env & base headers, struct Wasm_z_stream & ZStreamMap
Signed-off-by: Saikat Dey <saikatdey2100@gmail.com>
* Added basic zlib function declarations.
Signed-off-by: Saikat Dey <saikatdey2100@gmail.com>
* Added zlib env implementation & PluginDescriptor.
Signed-off-by: Saikat Dey <saikatdey2100@gmail.com>
* Added zlib module implementation, and added Host Functions.
Signed-off-by: Saikat Dey <saikatdey2100@gmail.com>
* Added zlib plugin WasmEdgeZlibDeflateInit_ implementation.
Signed-off-by: Saikat Dey <saikatdey2100@gmail.com>
* Added zlib plugin WasmEdgeZlibInflateInit_ implementation.
Signed-off-by: Saikat Dey <saikatdey2100@gmail.com>
* Added zlib plugin WasmEdgeZlibDeflate implementation.
Signed-off-by: Saikat Dey <saikatdey2100@gmail.com>
* Added zlib plugin WasmEdgeZlibInflate implementation.
Signed-off-by: Saikat Dey <saikatdey2100@gmail.com>
* Added zlib plugin WasmEdgeZlibDeflateEnd implementation.
Signed-off-by: Saikat Dey <saikatdey2100@gmail.com>
* Added zlib plugin WasmEdgeZlibInflateEnd implementation.
Signed-off-by: Saikat Dey <saikatdey2100@gmail.com>
* Populated plugins/wasmedge_zlib/CMakeLists.txt to build & link the zlib plugin source.
Signed-off-by: Saikat Dey <saikatdey2100@gmail.com>
* Fix: Added ZLIB as link dep to wasmedge_zlib plugin.
Signed-off-by: Saikat Dey <saikatdey2100@gmail.com>
* Added basic test for zlib plugin; WIP/TODO.
Signed-off-by: Saikat Dey <saikatdey2100@gmail.com>
* Added test/plugins/wasmedge_zlib/CMakeLists.txt to build and create zlib test executable.
Signed-off-by: Saikat Dey <saikatdey2100@gmail.com>
* Include zlib plugin test sub directory in test/plugins/CMakeLists.txt.
Signed-off-by: Saikat Dey <saikatdey2100@gmail.com>
* Fixed naming convention by omitting namespace prefix from function name.
Signed-off-by: Saikat Dey <saikatdey2100@gmail.com>
* Fix case sensitivity in CMake of zlib library.
Signed-off-by: Saikat Dey <saikatdey2100@gmail.com>
* Refactor build-extensions.yml to be in-line with upstream master.
Signed-off-by: Saikat Dey <saikatdey2100@gmail.com>
* Fix typo in build-extensions.yml on zlib cmake option
Signed-off-by: Saikat Dey <saikatdey2100@gmail.com>
* Minor type changes to better reflect the Zlib API.
Signed-off-by: Saikat Dey <saikatdey2100@gmail.com>
* Added Deflate Inflate Integration Test
Signed-off-by: Saikat Dey <saikatdey2100@gmail.com>
* Removed unnecessary nulling of wasm module's z_stream allocators | The host ignores them.
Signed-off-by: Saikat Dey <saikatdey2100@gmail.com>
* Added static_assert on Wasm_z_stream struct size.
Signed-off-by: Saikat Dey <saikatdey2100@gmail.com>
* Start writing to the wasm heap from address 1 onwards, to nto collide with the semantic meaning of address/offset 0 as nullptr.
Signed-off-by: Saikat Dey <saikatdey2100@gmail.com>
* Fix: Correct Version Check and Stream Size Check Error code, and API behaviour, along with relevant test case changes.
Signed-off-by: Saikat Dey <saikatdey2100@gmail.com>
* Added in-code documentation/pointer/reason on why we just compare only the first character of zlib version strings.
Signed-off-by: Saikat Dey <saikatdey2100@gmail.com>
* Remove unsafe usage of wasm MemStart(pointer from base{0}). Converted to offset based pointer calculation, based on pointer increment after zlib operation..
Signed-off-by: Saikat Dey <saikatdey2100@gmail.com>
* Added in-code documentation to every field in Wasm_z_stream.
Signed-off-by: Saikat Dey <saikatdey2100@gmail.com>
* Honor LLVM Naming Convention: Change 'Wasm_z_stream' struct name to 'WasmZStream'.
Signed-off-by: Saikat Dey <saikatdey2100@gmail.com>
* Honor LLVM Naming Convention: Change 'Wasm_z_stream' struct name to 'WasmZStream'.
Signed-off-by: Saikat Dey <saikatdey2100@gmail.com>
* Changed c style cast to static_cast.
Signed-off-by: Saikat Dey <saikatdey2100@gmail.com>
* Updated a few variable name to reflect LLVM standards.
Signed-off-by: Saikat Dey <saikatdey2100@gmail.com>
* Updated a few more variable name to reflect LLVM standards.
Signed-off-by: Saikat Dey <saikatdey2100@gmail.com>
* Added a more comprehensive Host and Wasm ZStream Syncronization Func, and wrapped all zlib calls with it.
Signed-off-by: Saikat Dey <saikatdey2100@gmail.com>
* Change few comments.
Signed-off-by: Saikat Dey <saikatdey2100@gmail.com>
* Add Condition to only add ZStream to internal registry, if init succeeded.
Signed-off-by: Saikat Dey <saikatdey2100@gmail.com>
* Remove unnecessary zlib version check in wasmedge, delegated it to the zlib implementation.
Signed-off-by: Saikat Dey <saikatdey2100@gmail.com>
* Added WasmEdgeZlibDeflateSetDictionary and WasmEdgeZlibDeflateGetDictionary.
Signed-off-by: Saikat Dey <saikatdey2100@gmail.com>
* Added WasmEdgeZlibDeflateCopy with a comment on impl. ref.
Signed-off-by: Saikat Dey <saikatdey2100@gmail.com>
* Added deflateReset
Signed-off-by: Saikat Dey <saikatdey2100@gmail.com>
* Added deflateParams
Signed-off-by: Saikat Dey <saikatdey2100@gmail.com>
* Added deflateTune & deflateBound.
Signed-off-by: Saikat Dey <saikatdey2100@gmail.com>
* Added deflatePending & deflatePrime.
Signed-off-by: Saikat Dey <saikatdey2100@gmail.com>
* Defined the Wasm gz_header struct.
Signed-off-by: Saikat Dey <saikatdey2100@gmail.com>
* Added few function impl of zlib.
Signed-off-by: Saikat Dey <saikatdey2100@gmail.com>
* Added most of non gz functions.
Signed-off-by: Saikat Dey <saikatdey2100@gmail.com>
* Added adler32, adler32_z, crc32, crc32_z.
Signed-off-by: Saikat Dey <saikatdey2100@gmail.com>
* Remove _v2 postfix
Signed-off-by: Saikat Dey <saikatdey2100@gmail.com>
* Remove duplicate impl. of WasmEdgeZlibInflateSetDictionary.
Signed-off-by: Saikat Dey <saikatdey2100@gmail.com>
* Remove unused parameter 'Frame' from WasmEdgeZlibZlibCompilerFlags & WasmEdgeZlibCompressBound.
Signed-off-by: Saikat Dey <saikatdey2100@gmail.com>
* Correct few pointer value usage.
Signed-off-by: Saikat Dey <saikatdey2100@gmail.com>
* Added GZFile support Env & implemented WasmEdgeZlibGZDOpen.
Signed-off-by: Saikat Dey <saikatdey2100@gmail.com>
* Implemented gzbuffer, gzsetparams & gzread.
Signed-off-by: Saikat Dey <saikatdey2100@gmail.com>
* Added gzfread, gzwrite & gzfwrite.
Signed-off-by: Saikat Dey <saikatdey2100@gmail.com>
* Added gzputs, gzgets, gzputc, gzgetc.
Signed-off-by: Saikat Dey <saikatdey2100@gmail.com>
* Added gzflush & gzrewind
Signed-off-by: Saikat Dey <saikatdey2100@gmail.com>
* Remove unused parameter 'Frame'.
Signed-off-by: Saikat Dey <saikatdey2100@gmail.com>
* Added gzeof, gzdirect, gzclose, gzclose_r, gzclose_w.
Signed-off-by: Saikat Dey <saikatdey2100@gmail.com>
* Added gzclearerr.
Signed-off-by: Saikat Dey <saikatdey2100@gmail.com>
* Change void* to unsigned char*
Signed-off-by: Saikat Dey <saikatdey2100@gmail.com>
* Added gzgetc & gzungetc.
Signed-off-by: Saikat Dey <saikatdey2100@gmail.com>
* Fix name Spell mistake.
Signed-off-by: Saikat Dey <saikatdey2100@gmail.com>
* Fixed no-return on a Expect<void>.
Signed-off-by: Saikat Dey <saikatdey2100@gmail.com>
* Fix move semantics related to unique_ptr.
Signed-off-by: Saikat Dey <saikatdey2100@gmail.com>
* Added deflateInit2 & inflateInit2 & inflateBackInit2 & Refactor Part 1.
Signed-off-by: Saikat Dey <saikatdey2100@gmail.com>
* Added gzopen | gzseek | gztell | gzoffset | adler32_combine | crc32_combine & Refactor Part 2
Signed-off-by: Saikat Dey <saikatdey2100@gmail.com>
* Added deflateInit2_ | inflateInit2_ | inflateBackInit_.
Signed-off-by: Saikat Dey <saikatdey2100@gmail.com>
* Added gzgetc_
Signed-off-by: Saikat Dey <saikatdey2100@gmail.com>
* Added inflateSyncPoint | inflateUndermine | inflateValidate | inflateCodesUsed | inflateResetKeep | deflateResetKeep.
Signed-off-by: Saikat Dey <saikatdey2100@gmail.com>
* Added draft WasmEdgeZlibGZVPrintf.
Signed-off-by: Saikat Dey <saikatdey2100@gmail.com>
* Removed unused Frame parameter.
Signed-off-by: Saikat Dey <saikatdey2100@gmail.com>
* Change all remaining naming convention to LLVM style.
Signed-off-by: Saikat Dey <saikatdey2100@gmail.com>
* Added Host Func registration & Refactor Part 3.
Signed-off-by: Saikat Dey <saikatdey2100@gmail.com>
* Update function presence check to validate al 74 functions.
Signed-off-by: Saikat Dey <saikatdey2100@gmail.com>
* Update release.yml to include zlib.
Signed-off-by: Saikat Dey <saikatdey2100@gmail.com>
* Added deflatesetheader & inflategetheader.
Signed-off-by: Saikat Dey <saikatdey2100@gmail.com>
* Change return type of SyncRun.
Signed-off-by: Saikat Dey <saikatdey2100@gmail.com>
* SyncRun Func Design & Params Overhaul.
Signed-off-by: Saikat Dey <saikatdey2100@gmail.com>
* Remove access to moved unique_ptr.
Signed-off-by: Saikat Dey <saikatdey2100@gmail.com>
* Added GZHeader Sync steps in SyncRun.
Signed-off-by: Saikat Dey <saikatdey2100@gmail.com>
* Registered deflateSetHeader | inflateGetHeader.
Signed-off-by: Saikat Dey <saikatdey2100@gmail.com>
* Updated Test to check for deflateSetHeader & inflateGetHeader.
Signed-off-by: Saikat Dey <saikatdey2100@gmail.com>
* Updated function count test to check for 76 functions.
Signed-off-by: Saikat Dey <saikatdey2100@gmail.com>
* Check if SyncRun fails even with no call to zlib API.
Signed-off-by: Saikat Dey <saikatdey2100@gmail.com>
* Removed old unused comments, revert usage of named fields & naming convention fixes.
Signed-off-by: Saikat Dey <saikatdey2100@gmail.com>
* Added extensive error logging to Zlib Plugin.
Signed-off-by: Saikat Dey <saikatdey2100@gmail.com>
* Added Function Instance Name, to SyncRun Error messages for better debug experience.
Signed-off-by: Saikat Dey <saikatdey2100@gmail.com>
* Added a space between error msg tag & message.
Signed-off-by: Saikat Dey <saikatdey2100@gmail.com>
* Added info to error msg if the error is caught inside SyncRun.
Signed-off-by: Saikat Dey <saikatdey2100@gmail.com>
* Removed usage of a temporary ZRes variable wherever not absolutely necessary.
Signed-off-by: Saikat Dey <saikatdey2100@gmail.com>
* Fix Bug: Properly return a placeholder number to Module to act as a pointer to Host gzFile_s. We don't need to pass the raw pointer to Module, since gzFile_s is an opaque structure & the zlib app shouldn't try to access any of it's fields.
Signed-off-by: Saikat Dey <saikatdey2100@gmail.com>
* [Style Change] Remove trailing _s from GZFile_s.
Signed-off-by: Saikat Dey <saikatdey2100@gmail.com>
* Removed usage of decltype, due to gcc [error: type qualifiers ignored on cast result type]. Using remove_cv to supress, would create code bloat.
Signed-off-by: Saikat Dey <saikatdey2100@gmail.com>
---------
Signed-off-by: Saikat Dey <saikatdey2100@gmail.com>
Signed-off-by: Sarrah Bastawala <sarrah.basta@gmail.com>
#2546
Project Overview: #2244 (comment)
Improved version of PR #2395
CMake
option(WASMEDGE_PLUGIN_ZLIB "Enable WasmEdge zlib plugin." OFF)if(WASMEDGE_PLUGIN_ZLIB) add_subdirectory(wasmedge_zlib) endif()zlib-ngthroughFetchContentsources& buildlibraryWorkflows
build_ubuntubuild_manylinuxDocumentation
Tests
Implementation
Ready for Review