[Plugin] Implement OpenCV-mini #2648

dannypsnl · 2023-07-05T08:06:53Z

Feature

transform

normalize: not cv::normalize, from 77051da#diff-3333d926ca87cf4285bfcd6deae45ee310307be66fca8a4ca6f0f8a946743fccR50-R54
blur: blurring function
bilinear_sampling: bilinear sampler

read/write

imdecode: from image from instance buffer
imencode: put image into instance buffer
imwrite: write image into file

misc

imshow: show image (broken on MacOS)
waitkey: wait any keypress

Example: https://github.com/second-state/opencvmini-example
NOTE: since [Plugin][WIP] Implement OpenCV-mini #2403 is failed to trigger CI now, I reopen this PR

Signed-off-by: Lîm Tsú-thuàn <dannypsnl@secondstate.io>

1. imdecode 2. imshow 3. waitkey The `cv::Mat` will be cached in a map & wasm module will only get handle instead of passing huge multi-dim array (`cv::Mat`) around the host & wasm. Signed-off-by: Lîm Tsú-thuàn <dannypsnl@secondstate.io>

Signed-off-by: Lîm Tsú-thuàn <dannypsnl@secondstate.io>

`imwrite` will put matrix into a file, and hence. we can check the transformer result `blur` do simple blurring, this is the first transformer we introduce Signed-off-by: Lîm Tsú-thuàn <dannypsnl@secondstate.io>

The function will write compressed image back into instance's buffer Signed-off-by: Lîm Tsú-thuàn <dannypsnl@secondstate.io>

NOTE, this is a normalize function from 77051da#diff-3333d926ca87cf4285bfcd6deae45ee310307be66fca8a4ca6f0f8a946743fccR50-R54 not `cv::normalize` Signed-off-by: Lîm Tsú-thuàn <dannypsnl@secondstate.io>

Signed-off-by: Lîm Tsú-thuàn <dannypsnl@secondstate.io>

hydai · 2023-07-19T07:57:05Z

Please fix the failed CI.

Signed-off-by: Lîm Tsú-thuàn <dannypsnl@secondstate.io>

dannypsnl · 2023-07-20T04:54:55Z

Please fix the failed CI.

Fixed, I just pick a stable version of OpenCV

Signed-off-by: Lîm Tsú-thuàn <dannypsnl@secondstate.io>

.github/workflows/release.yml

plugins/CMakeLists.txt

plugins/wasmedge_opencvmini/CMakeLists.txt

plugins/wasmedge_opencvmini/opencvmini_func.cpp

Signed-off-by: Lîm Tsú-thuàn <dannypsnl@secondstate.io>

hydai

LGTM

* first draft to setup opencvmini plugin Signed-off-by: Lîm Tsú-thuàn <dannypsnl@secondstate.io> * fix porting name Signed-off-by: Lîm Tsú-thuàn <dannypsnl@secondstate.io> * missing include Signed-off-by: Lîm Tsú-thuàn <dannypsnl@secondstate.io> * update to 2023 Signed-off-by: Lîm Tsú-thuàn <dannypsnl@secondstate.io> * link opencv into plugin Signed-off-by: Lîm Tsú-thuàn <dannypsnl@secondstate.io> * implements three functions 1. imdecode 2. imshow 3. waitkey The `cv::Mat` will be cached in a map & wasm module will only get handle instead of passing huge multi-dim array (`cv::Mat`) around the host & wasm. Signed-off-by: Lîm Tsú-thuàn <dannypsnl@secondstate.io> * opencvmini has no need add options Signed-off-by: Lîm Tsú-thuàn <dannypsnl@secondstate.io> * fix to be workable Signed-off-by: Lîm Tsú-thuàn <dannypsnl@secondstate.io> * add opencvmini option Signed-off-by: Lîm Tsú-thuàn <dannypsnl@secondstate.io> * formatting Signed-off-by: Lîm Tsú-thuàn <dannypsnl@secondstate.io> * fixing linter problem Signed-off-by: Lîm Tsú-thuàn <dannypsnl@secondstate.io> * add `blur` function & `imwrite` `imwrite` will put matrix into a file, and hence. we can check the transformer result `blur` do simple blurring, this is the first transformer we introduce Signed-off-by: Lîm Tsú-thuàn <dannypsnl@secondstate.io> * implements `imencode` The function will write compressed image back into instance's buffer Signed-off-by: Lîm Tsú-thuàn <dannypsnl@secondstate.io> * normalize function NOTE, this is a normalize function from WasmEdge@77051da#diff-3333d926ca87cf4285bfcd6deae45ee310307be66fca8a4ca6f0f8a946743fccR50-R54 not `cv::normalize` Signed-off-by: Lîm Tsú-thuàn <dannypsnl@secondstate.io> * add function bilinear sampling Signed-off-by: Lîm Tsú-thuàn <dannypsnl@secondstate.io> * release adding opencvmini Signed-off-by: Lîm Tsú-thuàn <dannypsnl@secondstate.io> * build extensions Signed-off-by: Lîm Tsú-thuàn <dannypsnl@secondstate.io> * add test Signed-off-by: Lîm Tsú-thuàn <dannypsnl@secondstate.io> * cmake track testing Signed-off-by: Lîm Tsú-thuàn <dannypsnl@secondstate.io> * metas Signed-off-by: Lîm Tsú-thuàn <dannypsnl@secondstate.io> * install opencv Signed-off-by: Lîm Tsú-thuàn <dannypsnl@secondstate.io> * fix release name Signed-off-by: Lîm Tsú-thuàn <dannypsnl@secondstate.io> * fix dependencies Signed-off-by: Lîm Tsú-thuàn <dannypsnl@secondstate.io> * fix typo in CI configuration Signed-off-by: Lîm Tsú-thuàn <dannypsnl@secondstate.io> * fix name Signed-off-by: Lîm Tsú-thuàn <dannypsnl@secondstate.io> * fix export functions number test Signed-off-by: Lîm Tsú-thuàn <dannypsnl@secondstate.io> * try newer g++ Signed-off-by: Lîm Tsú-thuàn <dannypsnl@secondstate.io> * install libopencv-dev on ubuntu Signed-off-by: Lîm Tsú-thuàn <dannypsnl@secondstate.io> * yum can install opencv Signed-off-by: Lîm Tsú-thuàn <dannypsnl@secondstate.io> * build and limit build thread Signed-off-by: Lîm Tsú-thuàn <dannypsnl@secondstate.io> * retry with no sudo Signed-off-by: Lîm Tsú-thuàn <dannypsnl@secondstate.io> * independent Signed-off-by: Lîm Tsú-thuàn <dannypsnl@secondstate.io> * ninja Signed-off-by: Lîm Tsú-thuàn <dannypsnl@secondstate.io> * ubuntu also use build Signed-off-by: Lîm Tsú-thuàn <dannypsnl@secondstate.io> * extra module Signed-off-by: Lîm Tsú-thuàn <dannypsnl@secondstate.io> * add platform exclusive, and fix naming Signed-off-by: Lîm Tsú-thuàn <dannypsnl@secondstate.io> * remove contrib Signed-off-by: Lîm Tsú-thuàn <dannypsnl@secondstate.io> * fix binary name Signed-off-by: Lîm Tsú-thuàn <dannypsnl@secondstate.io> * macos missing opencv installation Signed-off-by: Lîm Tsú-thuàn <dannypsnl@secondstate.io> * install certain version Signed-off-by: Lîm Tsú-thuàn <dannypsnl@secondstate.io> * fix install script Signed-off-by: Lîm Tsú-thuàn <dannypsnl@secondstate.io> * fix upload name Signed-off-by: Lîm Tsú-thuàn <dannypsnl@secondstate.io> * fix wrong format Signed-off-by: Lîm Tsú-thuàn <dannypsnl@secondstate.io> * outdated trick Signed-off-by: Lîm Tsú-thuàn <dannypsnl@secondstate.io> * test if we remove devtoolset-8 Signed-off-by: Lîm Tsú-thuàn <dannypsnl@secondstate.io> * there has no http plugin now Signed-off-by: Lîm Tsú-thuàn <dannypsnl@secondstate.io> * remove do nothing configuration Signed-off-by: Lîm Tsú-thuàn <dannypsnl@secondstate.io> * blur export kernel parameters Signed-off-by: Lîm Tsú-thuàn <dannypsnl@secondstate.io> * let user can assign extension Signed-off-by: Lîm Tsú-thuàn <dannypsnl@secondstate.io> --------- Signed-off-by: Lîm Tsú-thuàn <dannypsnl@secondstate.io>

dannypsnl added 27 commits June 5, 2023 14:53

first draft to setup opencvmini plugin

86578ea

Signed-off-by: Lîm Tsú-thuàn <dannypsnl@secondstate.io>

fix porting name

b451d73

Signed-off-by: Lîm Tsú-thuàn <dannypsnl@secondstate.io>

missing include

bb7117d

Signed-off-by: Lîm Tsú-thuàn <dannypsnl@secondstate.io>

update to 2023

2b57c28

Signed-off-by: Lîm Tsú-thuàn <dannypsnl@secondstate.io>

link opencv into plugin

c823324

Signed-off-by: Lîm Tsú-thuàn <dannypsnl@secondstate.io>

implements three functions

4dcdd00

1. imdecode 2. imshow 3. waitkey The `cv::Mat` will be cached in a map & wasm module will only get handle instead of passing huge multi-dim array (`cv::Mat`) around the host & wasm. Signed-off-by: Lîm Tsú-thuàn <dannypsnl@secondstate.io>

opencvmini has no need add options

3b8785e

Signed-off-by: Lîm Tsú-thuàn <dannypsnl@secondstate.io>

fix to be workable

e5e22bc

Signed-off-by: Lîm Tsú-thuàn <dannypsnl@secondstate.io>

add opencvmini option

d77baab

Signed-off-by: Lîm Tsú-thuàn <dannypsnl@secondstate.io>

formatting

a75384d

Signed-off-by: Lîm Tsú-thuàn <dannypsnl@secondstate.io>

fixing linter problem

d71cf24

Signed-off-by: Lîm Tsú-thuàn <dannypsnl@secondstate.io>

Merge branch 'master' into plugin-opencvmini

6d86fd9

Signed-off-by: Lîm Tsú-thuàn <dannypsnl@secondstate.io>

add blur function & imwrite

a8e7439

`imwrite` will put matrix into a file, and hence. we can check the transformer result `blur` do simple blurring, this is the first transformer we introduce Signed-off-by: Lîm Tsú-thuàn <dannypsnl@secondstate.io>

Merge branch 'master' into plugin-opencvmini

27ae82e

implements imencode

28a9ddb

The function will write compressed image back into instance's buffer Signed-off-by: Lîm Tsú-thuàn <dannypsnl@secondstate.io>

normalize function

f9d2b2a

NOTE, this is a normalize function from 77051da#diff-3333d926ca87cf4285bfcd6deae45ee310307be66fca8a4ca6f0f8a946743fccR50-R54 not `cv::normalize` Signed-off-by: Lîm Tsú-thuàn <dannypsnl@secondstate.io>

Merge branch 'master' into plugin-opencvmini

e694696

add function bilinear sampling

8a509a2

Signed-off-by: Lîm Tsú-thuàn <dannypsnl@secondstate.io>

release adding opencvmini

a831e09

Signed-off-by: Lîm Tsú-thuàn <dannypsnl@secondstate.io>

build extensions

7861da9

Signed-off-by: Lîm Tsú-thuàn <dannypsnl@secondstate.io>

add test

256d758

Signed-off-by: Lîm Tsú-thuàn <dannypsnl@secondstate.io>

cmake track testing

1261bd9

Signed-off-by: Lîm Tsú-thuàn <dannypsnl@secondstate.io>

metas

235c67e

Signed-off-by: Lîm Tsú-thuàn <dannypsnl@secondstate.io>

Merge branch 'master' into plugin-opencvmini

cdf9482

install opencv

3792c15

Signed-off-by: Lîm Tsú-thuàn <dannypsnl@secondstate.io>

fix release name

30df90c

Signed-off-by: Lîm Tsú-thuàn <dannypsnl@secondstate.io>

fix dependencies

1368d1c

Signed-off-by: Lîm Tsú-thuàn <dannypsnl@secondstate.io>

dannypsnl requested review from hydai, ibmibmibm and q82419 as code owners July 5, 2023 08:06

This comment was marked as resolved.

Sign in to view

Merge branch 'master' into plugin-opencvmini

d679714

hydai mentioned this pull request Jul 19, 2023

LFX Workspace: OpenCV SDKs for Wasm #1836

Closed

5 tasks

dannypsnl added 3 commits July 20, 2023 11:44

Merge branch 'master' into plugin-opencvmini

9158a04

Signed-off-by: Lîm Tsú-thuàn <dannypsnl@secondstate.io>

install certain version

e4a8394

Signed-off-by: Lîm Tsú-thuàn <dannypsnl@secondstate.io>

fix install script

fc0c353

Signed-off-by: Lîm Tsú-thuàn <dannypsnl@secondstate.io>

dannypsnl added 3 commits July 20, 2023 12:57

fix upload name

755c9c0

Signed-off-by: Lîm Tsú-thuàn <dannypsnl@secondstate.io>

fix wrong format

2ea2aac

Signed-off-by: Lîm Tsú-thuàn <dannypsnl@secondstate.io>

Merge branch 'master' into plugin-opencvmini

3a4be9f

Signed-off-by: Lîm Tsú-thuàn <dannypsnl@secondstate.io>

github-actions bot added the c-CMake label Jul 24, 2023

Merge branch 'master' into plugin-opencvmini

5da484d

Signed-off-by: Lîm Tsú-thuàn <dannypsnl@secondstate.io>

dannypsnl force-pushed the plugin-opencvmini branch from 0d128b2 to 5da484d Compare July 24, 2023 05:10

github-actions bot removed the c-CMake label Jul 24, 2023

outdated trick

efbdb0b

Signed-off-by: Lîm Tsú-thuàn <dannypsnl@secondstate.io>

hydai requested changes Jul 24, 2023

View reviewed changes

dannypsnl added 6 commits July 25, 2023 08:40

Merge branch 'master' into plugin-opencvmini

d7f1842

Signed-off-by: Lîm Tsú-thuàn <dannypsnl@secondstate.io>

test if we remove devtoolset-8

3e0e05a

Signed-off-by: Lîm Tsú-thuàn <dannypsnl@secondstate.io>

there has no http plugin now

1617419

Signed-off-by: Lîm Tsú-thuàn <dannypsnl@secondstate.io>

remove do nothing configuration

751214e

Signed-off-by: Lîm Tsú-thuàn <dannypsnl@secondstate.io>

blur export kernel parameters

b6b82b6

Signed-off-by: Lîm Tsú-thuàn <dannypsnl@secondstate.io>

let user can assign extension

a663b7a

Signed-off-by: Lîm Tsú-thuàn <dannypsnl@secondstate.io>

dannypsnl requested a review from hydai July 25, 2023 02:34

dannypsnl mentioned this pull request Jul 25, 2023

LFX workspace: OpenCV SDKs for Wasm #1747

Closed

hydai approved these changes Jul 25, 2023

View reviewed changes

hydai merged commit 586675c into master Jul 25, 2023
50 checks passed

hydai deleted the plugin-opencvmini branch July 25, 2023 04:32

juntao mentioned this pull request Jul 25, 2023

[Misc] Update changelog for 0.13.3 release #2682

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Plugin] Implement OpenCV-mini #2648

[Plugin] Implement OpenCV-mini #2648

dannypsnl commented Jul 5, 2023 •

edited

hydai commented Jul 19, 2023

This comment was marked as resolved.

dannypsnl commented Jul 20, 2023

hydai left a comment

[Plugin] Implement OpenCV-mini #2648

[Plugin] Implement OpenCV-mini #2648

Conversation

dannypsnl commented Jul 5, 2023 • edited

Feature

transform

read/write

misc

hydai commented Jul 19, 2023

This comment was marked as resolved.

dannypsnl commented Jul 20, 2023

hydai left a comment

Choose a reason for hiding this comment

dannypsnl commented Jul 5, 2023 •

edited