-
Notifications
You must be signed in to change notification settings - Fork 716
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Proposal] Exception-Handling proposal for interpreter #3306
Conversation
Hello, I am a code review bot on flows.network. Here are my reviews of code commits in this PR. |
2cf1f5f
to
256135c
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #3306 +/- ##
==========================================
- Coverage 79.94% 79.83% -0.12%
==========================================
Files 251 253 +2
Lines 34396 34935 +539
Branches 5969 6150 +181
==========================================
+ Hits 27499 27890 +391
- Misses 5513 5622 +109
- Partials 1384 1423 +39 ☔ View full report in Codecov by Sentry. |
4787a52
to
49209c9
Compare
Test data: Function "br" - jump out the block and erase values on stack. (module
(func $f1 (export "br")
(block $b1
(i32.const 1)
(i32.const 2)
(i32.const 3)
(i32.const 4)
(i32.const 5)
(block $b2
(i32.const 1)
(i32.const 2)
(i32.const 3)
(i32.const 4)
(i32.const 5)
br $b1
)
unreachable
)
)
(func (export "iter") (param $n i32)
(loop $l
local.get $n
i32.const 1
i32.sub
local.tee $n
i32.const 0
i32.gt_u
call $f1
br_if $l
)
)
) Test command (with CLI): iterate 2M times. ./wasmedge --reactor test.wasm iter $ITER_NUM Time measurement:
|
e75430a
to
1f13cb9
Compare
d3712e7
to
ec727fe
Compare
9afcee9
to
a56e490
Compare
Signed-off-by: Harry Chiang <harry900831@gmail.com>
Signed-off-by: YiYing He <yiying@secondstate.io>
Signed-off-by: YiYing He <yiying@secondstate.io>
of br instructions. Signed-off-by: YiYing He <yiying@secondstate.io>
Signed-off-by: YiYing He <yiying@secondstate.io>
exception-handling proposal. Signed-off-by: YiYing He <yiying@secondstate.io>
c2e787f
to
a7df1d0
Compare
Implementation Status: