-
Notifications
You must be signed in to change notification settings - Fork 716
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WASI-NN] ggml: support grammar #3318
Conversation
Signed-off-by: dm4 <dm4@secondstate.io>
Hello, I am a code review bot on flows.network. Here are my reviews of code commits in this PR. Commit 1065aaccb5a8754648c90d5086995e48e454e415This patch adds support for a grammar attribute in the Graph structure used by the WASI-NN GGML backend. The following changes have been made:
Potential Problems:
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #3318 +/- ##
==========================================
- Coverage 77.29% 77.28% -0.01%
==========================================
Files 185 185
Lines 25614 25614
Branches 5651 5651
==========================================
- Hits 19799 19797 -2
- Misses 4386 4388 +2
Partials 1429 1429 ☔ View full report in Codecov by Sentry. |
grammar
for feat: ggml: support more parameters from llama.cpp #3314