Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WASI-NN] ggml: update ggml to b2636 #3333

Merged
merged 1 commit into from
Apr 12, 2024
Merged

[WASI-NN] ggml: update ggml to b2636 #3333

merged 1 commit into from
Apr 12, 2024

Conversation

dm4
Copy link
Collaborator

@dm4 dm4 commented Apr 10, 2024

  • This version of llama.cpp adds the support of command r plus model.

Signed-off-by: dm4 <dm4@secondstate.io>
Copy link
Member

juntao commented Apr 10, 2024

Hello, I am a code review bot on flows.network. Here are my reviews of code commits in this PR.


Commit d0797868fed0e4e8c86b9391f31ca32af562eba4

The main change in this patch is the update of the Git tag used by the project llama from b2534 to b2636. This was done in the CMakeLists.txt file of the wasi_nn plugin. This means that when FetchContent_Declare is called and the llama project source is fetched, the b2636 version of the project will be used instead of the b2534.

Potential issues could arise if the version b2636 of the llama project is incompatible with the existing codebase or dependencies. Additionally, if there are important changes, issues or bug fixes between b2534 and b2636 that significantly impact the functionality or safety of the software, then without proper review and testing of these changes, problems may arise. It's important to review the release notes of llama project for these versions to ensure that there will not be any unexpected issues.

@dm4 dm4 merged commit ef70dab into master Apr 12, 2024
70 of 71 checks passed
@dm4 dm4 deleted the dm4/update-ggml branch April 12, 2024 04:43
@hydai hydai added the v-0.14.0 label Apr 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c-Plugin An issue related to WasmEdge Plugin c-WASI-NN v-0.14.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants