-
-
Notifications
You must be signed in to change notification settings - Fork 334
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Windows Vista 64-bit & Waterfox 54 issue: TryAquireSRWLockExclusive could not be located in the Dynamic Link Library KERNEL32.DLL #166
Comments
Hi sorry about that! I'll have a look to see if I can fix it :-) |
Could you provisionally put 53.0.3 on that list. I'm going to do a fair bit of research for maybe doing a separate release for old systems. |
Although I don't use Windows Vista anymore, that sounds like an excellent idea, and I hope that it is materialized. |
Found the responsible: https://bugzilla.mozilla.org/show_bug.cgi?id=1331205 OTOH TryAcquireSRWLockExclusive/TryAcquireSRWLockShared were also introduced here. |
FTR: slim reader/writer (SRW) locks are the successor to CRITICAL_SECTION mutex locks in XP/Vista. They are a little easier to use in code and more performant, but functionally the same as using critical section locks. If you want XP/Vista compatibility, you have to use critical sections everywhere there are now SRW locks. This shouldn't influence any higher level code as long as you properly lock and unlock in the correct places. |
Kindly leave Vista in the past where it belongs. |
+1 in that Vista no longer meets the minimum requirements for Waterfox. https://web.archive.org/web/20190412134147/https://www.waterfoxproject.org/en-US/waterfox/new/ the mention of XP/Vista might have been a quirk of the period during which Waterfox site content was based on content that was open sourced by Mozilla. https://web.archive.org/web/20190420132504/https://www.waterfox.net/releases/ (2019-04-20) the minimum requirement for Windows was:
|
Isn't this what I just said? ;-) I'm all for SRW locks, in fact I've converted all of them for UXP quite a while ago and it makes sense for any modern software to do. |
Right after you kindly stop replying to a thread posted 3 years ago.. Looks like I'm not the only one "living in the past" 🙄 |
This issue was just referenced because someone wanted to run WF on vista. Maybe you need to live in the present? |
I’d hardly call Feb. 2018 “the present” so maybe you should take your own advice. Unsubscribing from this thread now, the best option for XP/Vista users is to simply use roytam1’s browser builds, available over at MSFN. Thank you to @MrAlex94 for showing interest in Vista regardless. |
Alex linked to this issue yesterday from https://www.reddit.com/r/waterfox/comments/fi0zrr/what_is_happening_on_windows_vista/fkfbgem/, the opening post there was firm but polite in this aspect:
i.e. the poster is aware of the lack of the support. I respect his wish for people to not question his use case. |
@WinClient5270 thank you, and for anyone with an interest: |
Hello everyone.
I just upgraded my Windows Vista virtual machine from Waterfox 53 to 54, and after doing so, I got the following error message:
The procedure entry point TryAquireSRWLockExclusive could not be located in the Dynamic Link Library KERNEL32.DLL.
According to the MSDN Library, TryAquireSRWLockExclusive is a Windows 7+ function, so of course when Waterfox looks for this function under Windows Vista, the user is presented with this error.
Since Waterfox still claims to support Windows Vista, I found it prudent to report this issue so it can either be fixed, or Waterfox can simply drop support for Vista and update the system requirements page to reflect this.
Now, I'm not trying to be rude, but I'm not interested in hearing "Why would you use Vista in 2017?" nonsense, because I don't use the OS myself (I'm perfectly happy with Windows 8.1, and I mentioned that this is a virtual machine in the first sentence of my post, not a physical computer). I just wanted to make Waterfox developers aware of this issue for the reasons listed above, in addition to the fact that I maintain a list on the MSFN forum called "Last versions of software for Windows Vista and Windows Server 2008" (link at the end of this post for those interested), and if this issue isn't going to get fixed, I will have to remove Waterfox from the list of browsers that actively continue to support Vista, and list Waterfox 53.0.3 as the final release for Vista.
Last versions of software for Vista/2008: http://www.msfn.org/board/topic/175262-last-versions-of-software-for-windows-vista-and-windows-server-2008/
Thanks,
WinClient5270
The text was updated successfully, but these errors were encountered: