New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Waterfox 56: Impossible to add spaces and separators to toolbars in customize mode #312
Comments
Also Aris-t2/ClassicThemeRestorer#383
Not specific to Waterfox. There's the same problem with Classic Theme Restorer with Firefox 56.0.2 (64-bit) on FreeBSD-CURRENT. @remez to reduce duplication/multiplication, maybe close this issue; things might be progressed under the earlier issues in the Classic Theme Restorer repository. |
@MrAlex94 |
The following commit broke the spacers and separators in CTR: Reverting it would probably restore their normal functioning. And of course the pref |
For me it was always clear Firefox code broke special toolbar items on purpose. There was no need to add such changes to Fx56, when it was actually meant for Fx57. Not sure, if this change can be reverted inside Waterfox code, but I'm optimistic. ;-) A workaround for CTR still does the job:
There is a discussion about this on CTRs Github support area too: Aris-t2/ClassicThemeRestorer#383 |
Thanks @Aris-t2 and NB (from the linked issue):
In other words:
If what's required is not present in that mode, then: a) quit/exit Waterfox |
From Aris-t2/ClassicThemeRestorer#383 (comment) (2017-12-02):
Also https://www.reddit.com/r/waterfox/comments/7jndj6/-/drbun04/ (2017-12-16):
We have limited workarounds, with extensions such as Classic Theme Restorer, but this is – essentially – an issue (by design) with Mozilla Firefox 56. #824 is a duplicate. |
I doubt that. Quoting the original description here:
In #824 those elements are not there at all – so of course they cannot be moved. Somehow same outcome (no spacers to use) – but I'm not sure these are dupes. |
Compare with a new profile with Firefox 56.0.2 … |
Note: in Waterfox/Firefox 56, the Flexible Space is available in the customization palette when the preference |
Modifying the preference to add spaces and separatorsThe method of editing the To place a special widget, for example, on the Navigation Toolbar, go to A flexible space (bold): "nav-bar":["urlbar-container","downloads-button","customizableui-special-spring2019","home-button"] A fixed space: "nav-bar":["urlbar-container","downloads-button","customizableui-special-spacer2019","home-button"] A separator: "nav-bar":["urlbar-container","downloads-button","customizableui-special-separator2019","home-button"] As you can see, the You can also move the Flexible Space from the customization palette onto the Navigation Toolbar, and then change the Another possibility is to manually edit the \"nav-bar\":[\"urlbar-container\",\"downloads-button\",\"customizableui-special-spacer2019\",\"home-button\"] The toolbar arrays include: nav-bar navigation toolbar
PersonalToolbar bookmarks toolbar
TabsToolbar tabs toolbar
toolbar-menubar menu bar ctraddon_addon-bar classic theme restorer: add-on bar
ctraddon_extra-bar classic theme restorer: additional bar |
Modifying the toolbar items with CSS to create spaces and separatorsYou can transform flexible spaces into other spacing items, hide buttons or increase their margins.
Transform all flexible spaces on the Navigation Toolbar except the first and the last ones into separators with the :root:not([customizing]) #nav-bar toolbarspring:nth-of-type(n+2):nth-last-of-type(n+2) {
-moz-appearance: separator !important;
min-width: 1px !important;
max-width: 1px !important;
-moz-margin-start: 1px !important;
} Make the first and the last flexible spaces on the Navigation Toolbar into separators using the #main-window:not([customizing]) #nav-bar toolbarspring:first-of-type,
#main-window:not([customizing]) #nav-bar toolbarspring:last-of-type {
-moz-appearance: separator !important;
min-width: 1px !important;
max-width: 1px !important;
-moz-margin-start: 1px !important;
} Turn, for example, the 3rd and the 5th flexible spaces on the Navigation Toolbar (counting from start/left) into fixed spaces with the #main-window:not([customizing]) #nav-bar toolbarspring:nth-of-type(2n+3):nth-of-type(-n+5) {
min-width: 15px !important;
max-width: 15px !important;
} Use the #main-window:not([customizing]) #nav-bar toolbarspring:nth-last-of-type(2) {
min-width: 15px !important;
max-width: 15px !important;
} Transform a particular flexible space into a separator of distinct style: :root {
--separators-width-spring2019: 4px;
}
#main-window:not([customizing]) #customizableui-special-spring2019 {
-moz-appearance: none !important;
min-width: var(--separators-width-spring2019) !important;
max-width: var(--separators-width-spring2019) !important;
margin: 0.4em 4px !important;
border-right-width: var(--separators-width-spring2019) !important;
border-right-style: dotted !important;
border-right-color: HotPink !important;
} Replace flexible spaces situated after the Location Bar with separators using the General / Following Sibling Combinator ( #main-window:not([customizing]) #urlbar-container ~ toolbarspring {
-moz-appearance: separator !important;
min-width: 1px !important;
max-width: 1px !important;
-moz-margin-start: 1px !important;
} Replace one flexible space situated immediately after a button with a separator using the Adjacent / Next Sibling Combinator ( #main-window:not([customizing]) #downloads-button + toolbarspring {
-moz-appearance: separator !important;
min-width: 1px !important;
max-width: 1px !important;
-moz-margin-start: 1px !important;
} Increase margins of individual buttons targeting them by #ID that can be found using the Browser Toolbox; within the string value of the #main-window:not([customizing]) #downloads-button,
#main-window:not([customizing]) #home-button {
margin-right: 15px !important;
} :-moz-any(#downloads-button, #home-button) {
margin-right: 15px !important;
} Leave empty space instead of an unneeded button: #main-window:not([customizing]) #home-button {
visibility: hidden !important;
} The set of pseudo-class selectors matching the sibling elements of the same type ( :first-of-type the first elements
:last-of-type the last elements
:only-of-type the only elements
:nth-of-type() the nth elements (counting from start)
:nth-last-of-type() the nth elements (counting from end) The toolbar ID selectors include: #nav-bar navigation toolbar
#PersonalToolbar bookmarks toolbar
#TabsToolbar tabs toolbar
#toolbar-menubar menu bar #ctraddon_addon-bar classic theme restorer: add-on bar
#ctraddon_extra-bar classic theme restorer: additional bar The element selectors of spaces and separators on toolbars and in the hamburger menu: toolbarspring flexible spaces
toolbarspacer fixed spaces
toolbarseparator separators The ID selectors of individual special widgets (custom spaces and separators on the main window toolbars): #customizableui-special-spring2019 [id$=spring2019] a flexible space #customizableui-special-spacer2019 [id$=spacer2019] a fixed space #customizableui-special-separator2019 [id$=separator2019] a separator |
Cross reference https://redd.it/dqk4h5 |
Hello,
I need to customize my toolbars adding a fixed space or other elements added by the CTR.
I go in "Hamburger" -> "Customize"
In the "Additional Tools And Features" Windows I see some elements that I want to move to my toolbars.
If I try to move "Space" or "Separator" or "Flexible Space" in any toolbar, when I release the left button of the mouse, the element isn't inserted in the toolbar.
Configuration:
Windows 7 64 bit
Waterfox 56.0 64bit English
Default Theme
Tried with a clean installation of Waterfox and CTR (last Official version and last beta)
Thank you
https://github.com/Aris-t2/ClassicThemeRestorer/issues/384
The text was updated successfully, but these errors were encountered: