Support TUIC #332
Merged
Support TUIC #332
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ibigbug
reviewed
Mar 22, 2024
ibigbug
reviewed
Mar 24, 2024
| .congestion_controller_factory(Arc::new(CubicConfig::default())); | ||
| quinn_config.transport_config(Arc::new(quinn_transport_config)); | ||
| // Try to create an IPv4 socket as the placeholder first, if it fails, try IPv6. | ||
| let socket = |
There was a problem hiding this comment.
would this work if server is v6 only and v4 is used locally?
There was a problem hiding this comment.
I won't think it will work. Should we check server dns record is A or AAAA?
And if server is daul-stack, does clash-rs supply options prefer IPv4 or IPv6?
There was a problem hiding this comment.
i think we should check.
if you use clash resolver, it will try v6 first https://github.com/Watfaq/clash-rs/blob/master/clash_lib/src/app/dns/resolver.rs#L423
There was a problem hiding this comment.
I'm approving this for now. feel free to check in and make a separate PR for this as well as other features mentioned in the PR desc.
thanks!
|
plz do a cargo fmt too |
ibigbug
approved these changes
Mar 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
馃 This is a ...
馃敆 Related issue link
Impl #190
Work in progress
Features
PR