Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

save named stage submission timing #815

Merged
merged 1 commit into from
Apr 9, 2024
Merged

Conversation

JamesPHoughton
Copy link
Collaborator

No description provided.

Copy link

github-actions bot commented Apr 9, 2024

/home/runner/work/deliberation-empirica/deliberation-empirica/client/src/components/HairCheck.jsx
  101:9  warning  Unexpected alert                                                                                                                                                                                                                                                               no-alert
  116:6  warning  React Hook useEffect has missing dependencies: 'dailyObject', 'mountListeners', 'player', 'refreshDeviceList', and 'roomUrl'. Either include them or remove the dependency array                                                                                               react-hooks/exhaustive-deps
  124:6  warning  React Hook useEffect has a missing dependency: 'onVideoSuccess'. Either include it or remove the dependency array. If 'onVideoSuccess' changes too often, find the parent component that defines it and wrap that definition in useCallback                                    react-hooks/exhaustive-deps
  145:6  warning  React Hook useEffect has missing dependencies: 'audioSuccess', 'fftArray', and 'onAudioSuccess'. Either include them or remove the dependency array. If 'onAudioSuccess' changes too often, find the parent component that defines it and wrap that definition in useCallback  react-hooks/exhaustive-deps

/home/runner/work/deliberation-empirica/deliberation-empirica/client/src/components/Markdown.jsx
  18:6  error  Unnecessary escape character: !  no-useless-escape

/home/runner/work/deliberation-empirica/deliberation-empirica/client/src/components/SharedNotepad.jsx
  26:6  warning  React Hook useEffect has missing dependencies: 'defaultText', 'game', and 'record'. Either include them or remove the dependency array  react-hooks/exhaustive-deps

/home/runner/work/deliberation-empirica/deliberation-empirica/client/src/components/TextChat.jsx
   72:6  warning  React Hook useEffect has a missing dependency: 'msgs.length'. Either include it or remove the dependency array  react-hooks/exhaustive-deps
  183:7  warning  Unexpected alert                                                                                                no-alert

/home/runner/work/deliberation-empirica/deliberation-empirica/client/src/components/VideoCall.jsx
  159:10  error  'state' is assigned a value but never used  no-unused-vars

/home/runner/work/deliberation-empirica/deliberation-empirica/client/src/elements/Qualtrics.jsx
  37:10  error  'state' is assigned a value but never used  no-unused-vars

/home/runner/work/deliberation-empirica/deliberation-empirica/client/src/elements/Survey.jsx
  15:6  warning  React Hook useEffect has missing dependencies: 'progressLabel' and 'surveyName'. Either include them or remove the dependency array  react-hooks/exhaustive-deps

/home/runner/work/deliberation-empirica/deliberation-empirica/client/src/elements/TrainingVideo.jsx
  48:6  warning  React Hook useEffect has missing dependencies: 'timer?.elapsed' and 'url'. Either include them or remove the dependency array  react-hooks/exhaustive-deps

/home/runner/work/deliberation-empirica/deliberation-empirica/client/src/intro-exit/Consent.jsx
  120:6  warning  React Hook useEffect has a missing dependency: 'player'. Either include it or remove the dependency array  react-hooks/exhaustive-deps

/home/runner/work/deliberation-empirica/deliberation-empirica/client/src/intro-exit/Countdown.jsx
  8:21  error  Use default import syntax to import 'ReactCountdown'  import/no-named-default

/home/runner/work/deliberation-empirica/deliberation-empirica/client/src/intro-exit/IdForm.jsx
  30:6  warning  React Hook useEffect has a missing dependency: 'setChecksPassed'. Either include it or remove the dependency array. If 'setChecksPassed' changes too often, find the parent component that defines it and wrap that definition in useCallback  react-hooks/exhaustive-deps

/home/runner/work/deliberation-empirica/deliberation-empirica/client/src/intro-exit/NoGames.jsx
  20:18  error  React Hook "usePlayer" is called in function "message" that is neither a React function component nor a custom React Hook function. React component names must start with an uppercase letter. React Hook names must start with the word "use"  react-hooks/rules-of-hooks

/home/runner/work/deliberation-empirica/deliberation-empirica/cypress/e2e/01_Normal_Paths_Omnibus.js
  149:34  error  'actualOrder' is already declared in the upper scope on line 130 column 13  no-shadow

/home/runner/work/deliberation-empirica/deliberation-empirica/cypress/support/sharedSteps.js
  10:11  error  'log' is assigned a value but never used  no-unused-vars

/home/runner/work/deliberation-empirica/deliberation-empirica/server/src/index.js
  42:43  error  'p' is defined but never used  no-unused-vars

/home/runner/work/deliberation-empirica/deliberation-empirica/server/src/preFlight/dispatch.js
  521:9  error  Unexpected use of continue statement  no-continue

✖ 20 problems (9 errors, 11 warnings)

Copy link

cypress bot commented Apr 9, 2024

Passing run #1352 ↗︎

0 16 0 0 Flakiness 0

Details:

save named stage submission timing
Project: Deliberation Commit: d4f6936376
Status: Passed Duration: 10:59 💡
Started: Apr 9, 2024 12:50 PM Ended: Apr 9, 2024 1:01 PM

Review all test suite changes for PR #815 ↗︎

@JamesPHoughton JamesPHoughton merged commit d107cf0 into main Apr 9, 2024
5 checks passed
@JamesPHoughton JamesPHoughton deleted the james-submit-timings branch April 9, 2024 13:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant