Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can't replicate the link behaviour when seletion is in a label #17

Closed
Garito opened this issue Dec 18, 2013 · 7 comments
Closed

Can't replicate the link behaviour when seletion is in a label #17

Garito opened this issue Dec 18, 2013 · 7 comments

Comments

@Garito
Copy link
Collaborator

Garito commented Dec 18, 2013

Hi!
Could you please checkout this: https://github.com/Garito/bootstrap3-wysihtml5-bower
and tell me why the Label button doesn't behaves like link even when they are almost identicall?

In theory, if you define a label (witch works correct) but then put the cursor over it, the label button don't changes to pushed and behavies like the link button

Is it possible that this occurs because of the parser? (trying to use intuition on this question)

Thanks!

@Waxolunist
Copy link
Owner

The parser is written in the wysihtml dependency. I saw already some forks which are developing on a next version. Maybe we should change this dependency, because wysihtml is not developed anymore by xing. But I have to investigate in this. Maybe we could acquire some more contributors. On the other fork you have asked the same question you got a reply.

@Garito
Copy link
Collaborator Author

Garito commented Dec 18, 2013

Sorry I lost the other fork and I can't see this on my github (I don't have any email notification neither)
Could you point me the reply?

@Garito
Copy link
Collaborator Author

Garito commented Dec 18, 2013

By the way: did you check the code?

@Waxolunist
Copy link
Owner

https://github.com/schnawel007/bootstrap3-wysihtml5/issues/1#issuecomment-30835787

I couldn't check at the Moment. I am having a tough time before holidays with loads of work in my paied Job as JEE backend developer. So dont expect too much work this year by me.
I'll try this evening.

@Garito
Copy link
Collaborator Author

Garito commented Dec 18, 2013

No problem... I''ll digging a little more...

About the other fork's comment: check it again and you will see I wasn't :D and the question is another :D:D

About my code: perhaps the correct way to proceed by my part is to make a pull request in order to make it easy to compare both versions and what's new?

Thanks!

@Waxolunist
Copy link
Owner

Proceed with one branch per Feature and pull em one by one.

@Waxolunist Waxolunist modified the milestones: v0.3.1 (current development), v0.3.0, v0.4.0 (not planned yet) Jun 11, 2014
@Waxolunist
Copy link
Owner

Label buttons are out of scope.

This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants